[alsa-devel] [PATCH] ASoC: rockchip-i2s: fix infinite loop in rockchip_snd_rxctrl
We can get into an infinite loop if the I2S_CLR register fails to clear due to a missing break statement, so add that.
Signed-off-by: Jianqun jay.xu@rock-chips.com --- sound/soc/rockchip/rockchip_i2s.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index f373e37..c74ba37 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -154,8 +154,10 @@ static void rockchip_snd_rxctrl(struct rk_i2s_dev *i2s, int on) while (val) { regmap_read(i2s->regmap, I2S_CLR, &val); retry--; - if (!retry) + if (!retry) { dev_warn(i2s->dev, "fail to clear\n"); + break; + } } } }
On Wed, Oct 29, 2014 at 05:45:51PM +0800, Jianqun wrote:
We can get into an infinite loop if the I2S_CLR register fails to clear due to a missing break statement, so add that.
Applied, thanks.
participants (2)
-
Jianqun
-
Mark Brown