[alsa-devel] [asoc:topic/rt5659 1/3] sound/soc/codecs/rt5659.c:4048:6: sparse: symbol 'rt5659_intel_hd_header_probe_setup' was not declared. Should it be static?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/rt5659 head: de86a33253d07675abbb1fa294ffb4f3df6f219e commit: 041e74b71491acadad74b275e8b05add165d92b4 [1/3] ASoC: rt5659: Add the support of Intel HDA Header reproduce: # apt-get install sparse git checkout 041e74b71491acadad74b275e8b05add165d92b4 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
sound/soc/codecs/rt5659.c:4048:6: sparse: symbol 'rt5659_intel_hd_header_probe_setup' was not declared. Should it be
Please review and possibly fold the followup patch.
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Fixes: 041e74b71491 ("ASoC: rt5659: Add the support of Intel HDA Header") Signed-off-by: Fengguang Wu fengguang.wu@intel.com --- rt5659.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c index ef3a44d..b772194 100644 --- a/sound/soc/codecs/rt5659.c +++ b/sound/soc/codecs/rt5659.c @@ -4038,7 +4038,7 @@ static void rt5659_calibrate(struct rt5659_priv *rt5659) regmap_write(rt5659->regmap, RT5659_HP_CHARGE_PUMP_1, 0x0c16); }
-void rt5659_intel_hd_header_probe_setup(struct rt5659_priv *rt5659) +static void rt5659_intel_hd_header_probe_setup(struct rt5659_priv *rt5659) { int value;
The patch
ASoC: rt5659: rt5659_intel_hd_header_probe_setup() can be static
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 2fa0b7fdf8bd16b6cdda8516793989511c9322ed Mon Sep 17 00:00:00 2001
From: Wu Fengguang fengguang.wu@intel.com Date: Tue, 13 Feb 2018 01:16:06 +0800 Subject: [PATCH] ASoC: rt5659: rt5659_intel_hd_header_probe_setup() can be static
Fixes: 041e74b71491 ("ASoC: rt5659: Add the support of Intel HDA Header") Signed-off-by: Fengguang Wu fengguang.wu@intel.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/rt5659.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c index ef3a44d6386b..b7721940b76f 100644 --- a/sound/soc/codecs/rt5659.c +++ b/sound/soc/codecs/rt5659.c @@ -4038,7 +4038,7 @@ static void rt5659_calibrate(struct rt5659_priv *rt5659) regmap_write(rt5659->regmap, RT5659_HP_CHARGE_PUMP_1, 0x0c16); }
-void rt5659_intel_hd_header_probe_setup(struct rt5659_priv *rt5659) +static void rt5659_intel_hd_header_probe_setup(struct rt5659_priv *rt5659) { int value;
participants (2)
-
kbuild test robot -
Mark Brown