On 11/16/2023 1:51 PM, Kamil Duljas wrote:

The resources should be freed when function return error.

Signed-off-by: Kamil Duljas kamil.duljas@gmail.com

sound/soc/intel/skylake/skl-pcm.c | 4 +++- sound/soc/intel/skylake/skl-sst-ipc.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c index d0c02e8a6785..18866bc415a5 100644 --- a/sound/soc/intel/skylake/skl-pcm.c +++ b/sound/soc/intel/skylake/skl-pcm.c @@ -240,8 +240,10 @@ static int skl_pcm_open(struct snd_pcm_substream *substream, snd_pcm_set_sync(substream);

mconfig = skl_tplg_fe_get_cpr_module(dai, substream->stream);

• if (!mconfig)

• if (!mconfig) {

• kfree(dma_params);
  

  return -EINVAL;

• }

  skl_tplg_d0i3_get(skl, mconfig->d0i3_caps);

diff --git a/sound/soc/intel/skylake/skl-sst-ipc.c b/sound/soc/intel/skylake/skl-sst-ipc.c index 7a425271b08b..fd9624ad5f72 100644 --- a/sound/soc/intel/skylake/skl-sst-ipc.c +++ b/sound/soc/intel/skylake/skl-sst-ipc.c @@ -1003,8 +1003,10 @@ int skl_ipc_get_large_config(struct sst_generic_ipc *ipc,

reply.size = (reply.header >> 32) & IPC_DATA_OFFSET_SZ_MASK; buf = krealloc(reply.data, reply.size, GFP_KERNEL);

• if (!buf)

• if (!buf) {

• kfree(reply.data);
  

  return -ENOMEM;
• } *payload = buf; *bytes = reply.size;

Seems ok, Reviewed-by: Amadeusz Sławiński amadeuszx.slawinski@linux.intel.com