[PATCH 0/2] ASoC: add compatible for ti,pcm5242
Update bindings and add a driver compatible for the pcm5242 chip used on the Odroid HiFi-Shield2 i2c mezzanine board.
Christian Hewitt (2): dt-bindings: sound: add ti,pcm5424 to pcm512x ASoC: Add support for ti,pcm5242 to the pcm512x driver
Documentation/devicetree/bindings/sound/pcm512x.txt | 2 +- sound/soc/codecs/pcm512x-i2c.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)
Add ti,pcm5424 to the list of pcm512x compatible chips
Signed-off-by: Christian Hewitt christianshewitt@gmail.com --- Documentation/devicetree/bindings/sound/pcm512x.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/pcm512x.txt b/Documentation/devicetree/bindings/sound/pcm512x.txt index 77006a4aec4a..47878a6df608 100644 --- a/Documentation/devicetree/bindings/sound/pcm512x.txt +++ b/Documentation/devicetree/bindings/sound/pcm512x.txt @@ -6,7 +6,7 @@ on the board). The TAS575x devices only support I2C. Required properties:
- compatible : One of "ti,pcm5121", "ti,pcm5122", "ti,pcm5141", - "ti,pcm5142", "ti,tas5754" or "ti,tas5756" + "ti,pcm5142", "ti,pcm5242", "ti,tas5754" or "ti,tas5756"
- reg : the I2C address of the device for I2C, the chip select number for SPI.
On Sat, Jun 22, 2024 at 12:46:02PM +0000, Christian Hewitt wrote:
Add ti,pcm5424 to the list of pcm512x compatible chips
Signed-off-by: Christian Hewitt christianshewitt@gmail.com
Documentation/devicetree/bindings/sound/pcm512x.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Ideally this would also be converted to YAML but for such a trivial addition I don't think this should be a blocker.
Add a compatible string to enable support for the ti,pcm5242 DAC chip in the pcm512x driver.
Signed-off-by: Christian Hewitt christianshewitt@gmail.com --- sound/soc/codecs/pcm512x-i2c.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/pcm512x-i2c.c b/sound/soc/codecs/pcm512x-i2c.c index 4be476a280e1..92bcf5179779 100644 --- a/sound/soc/codecs/pcm512x-i2c.c +++ b/sound/soc/codecs/pcm512x-i2c.c @@ -39,6 +39,7 @@ static const struct i2c_device_id pcm512x_i2c_id[] = { { "pcm5122", }, { "pcm5141", }, { "pcm5142", }, + { "pcm5242", }, { "tas5754", }, { "tas5756", }, { } @@ -51,6 +52,7 @@ static const struct of_device_id pcm512x_of_match[] = { { .compatible = "ti,pcm5122", }, { .compatible = "ti,pcm5141", }, { .compatible = "ti,pcm5142", }, + { .compatible = "ti,pcm5242", }, { .compatible = "ti,tas5754", }, { .compatible = "ti,tas5756", }, { }
On Sat, Jun 22, 2024 at 12:46:03PM +0000, Christian Hewitt wrote:
Add a compatible string to enable support for the ti,pcm5242 DAC chip in the pcm512x driver.
Signed-off-by: Christian Hewitt christianshewitt@gmail.com
sound/soc/codecs/pcm512x-i2c.c | 2 ++ 1 file changed, 2 insertions(+)
The device appears to have SPI support too like the other devices in the family, why not add the ID for SPI as well:
On 22 Jun 2024, at 5:03 PM, Mark Brown broonie@kernel.org wrote:
On Sat, Jun 22, 2024 at 12:46:03PM +0000, Christian Hewitt wrote:
Add a compatible string to enable support for the ti,pcm5242 DAC chip in the pcm512x driver.
Signed-off-by: Christian Hewitt christianshewitt@gmail.com
sound/soc/codecs/pcm512x-i2c.c | 2 ++ 1 file changed, 2 insertions(+)
The device appears to have SPI support too like the other devices in the family, why not add the ID for SPI as well:
Okay, will do. I need to send v2 anyway as I fat-fingered the chip number in the bindings patch subject/description :(
Christian
participants (2)
-
Christian Hewitt -
Mark Brown