[PATCH] ALSA: lola: add a check for the return of vmalloc()
From: Xiaoke Wang xkernel.wang@foxmail.com
vmalloc() is a memory allocation function which can return NULL when some internal memory errors happen. So it is better to check the return of it to catch the error in time.
Signed-off-by: Xiaoke Wang xkernel.wang@foxmail.com --- sound/pci/lola/lola_mixer.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/pci/lola/lola_mixer.c b/sound/pci/lola/lola_mixer.c index e2c8f14..6b16248 100644 --- a/sound/pci/lola/lola_mixer.c +++ b/sound/pci/lola/lola_mixer.c @@ -121,6 +121,8 @@ int lola_init_mixer_widget(struct lola *chip, int nid)
/* reserve memory to copy mixer data for sleep mode transitions */ chip->mixer.array_saved = vmalloc(sizeof(struct lola_mixer_array)); + if (!chip->mixer.array_saved) + return -ENOMEM;
/* mixer matrix sources are physical input data and play streams */ chip->mixer.src_stream_outs = chip->pcm[PLAY].num_streams; --
On Fri, 04 Mar 2022 09:38:20 +0100, xkernel.wang@foxmail.com wrote:
From: Xiaoke Wang xkernel.wang@foxmail.com
vmalloc() is a memory allocation function which can return NULL when some internal memory errors happen. So it is better to check the return of it to catch the error in time.
Signed-off-by: Xiaoke Wang xkernel.wang@foxmail.com
Thanks, applied.
Takashi
participants (2)
-
Takashi Iwai
-
xkernel.wang@foxmail.com