[alsa-devel] [PATCH] ASoC: ak4104: Remove superfluous codec->control_data initialization
The driver uses automatic IO setup, which will also initialize the control_data field of the CODEC, no need to do it manually.
Signed-off-by: Lars-Peter Clausen lars@metafoo.de --- sound/soc/codecs/ak4104.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/ak4104.c b/sound/soc/codecs/ak4104.c index b4819dc..10adf25 100644 --- a/sound/soc/codecs/ak4104.c +++ b/sound/soc/codecs/ak4104.c @@ -174,8 +174,6 @@ static int ak4104_probe(struct snd_soc_codec *codec) struct ak4104_private *ak4104 = snd_soc_codec_get_drvdata(codec); int ret;
- codec->control_data = ak4104->regmap; - /* set power-up and non-reset bits */ ret = regmap_update_bits(ak4104->regmap, AK4104_REG_CONTROL1, AK4104_CONTROL1_PW | AK4104_CONTROL1_RSTN,
On 03/04/2014 09:19 AM, Lars-Peter Clausen wrote:
The driver uses automatic IO setup, which will also initialize the control_data field of the CODEC, no need to do it manually.
Signed-off-by: Lars-Peter Clausen lars@metafoo.de
Acked-by: Daniel Mack daniel@zonque.org
Thanks! Daniel
sound/soc/codecs/ak4104.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/ak4104.c b/sound/soc/codecs/ak4104.c index b4819dc..10adf25 100644 --- a/sound/soc/codecs/ak4104.c +++ b/sound/soc/codecs/ak4104.c @@ -174,8 +174,6 @@ static int ak4104_probe(struct snd_soc_codec *codec) struct ak4104_private *ak4104 = snd_soc_codec_get_drvdata(codec); int ret;
- codec->control_data = ak4104->regmap;
- /* set power-up and non-reset bits */ ret = regmap_update_bits(ak4104->regmap, AK4104_REG_CONTROL1, AK4104_CONTROL1_PW | AK4104_CONTROL1_RSTN,
On Tue, Mar 04, 2014 at 09:19:37AM +0100, Lars-Peter Clausen wrote:
The driver uses automatic IO setup, which will also initialize the control_data field of the CODEC, no need to do it manually.
Applied, thanks.
participants (3)
-
Daniel Mack
-
Lars-Peter Clausen
-
Mark Brown