[alsa-devel] [PATCH] ASoC: amd: fix report accurate hw_ptr during dma
From: Guenter Roeck groeck@chromium.org
ERROR: "__aeabi_uldivmod" [sound/soc/amd/snd-soc-acp-pcm.ko] undefined!
64-bit divides require special operations to avoid build errors on 32-bit systems.
fixes: 61add8147942 (ASoC: amd: Report accurate hw_ptr during dma) Signed-off-by: Guenter Roeck groeck@chromium.org Reviewed-on: https://chromium-review.googlesource.com/678919 Reviewed-by: Jason Clinton jclinton@chromium.org (cherry picked from commit 7ca726e80f21abdbaed9a5a70def1c33a26f8533) Reviewed-on: https://chromium-review.googlesource.com/681618 Signed-off-by: Alex Deucher alexander.deucher@amd.com ---
v2: resend with the Chromium tags removed and the subject updated.
sound/soc/amd/acp-pcm-dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c index 13d040a4d26f..ef7e98ad960c 100644 --- a/sound/soc/amd/acp-pcm-dma.c +++ b/sound/soc/amd/acp-pcm-dma.c @@ -856,12 +856,11 @@ static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream) if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { if (bytescount > rtd->renderbytescount) bytescount = bytescount - rtd->renderbytescount; - pos = bytescount % buffersize; } else { if (bytescount > rtd->capturebytescount) bytescount = bytescount - rtd->capturebytescount; - pos = bytescount % buffersize; } + pos = do_div(bytescount, buffersize); return bytes_to_frames(runtime, pos); }
On Wed, Nov 08, 2017 at 01:18:41PM -0500, Alex Deucher wrote:
From: Guenter Roeck groeck@chromium.org
ERROR: "__aeabi_uldivmod" [sound/soc/amd/snd-soc-acp-pcm.ko] undefined!
64-bit divides require special operations to avoid build errors on 32-bit systems.
Like I said in reply to your other mail please don't resubmit already applied patches. The current tip of my topic/amd branch appears to be this very patch, if there's anything needs changing please send an incremental patch.
On Wed, Nov 8, 2017 at 1:22 PM, Mark Brown broonie@kernel.org wrote:
On Wed, Nov 08, 2017 at 01:18:41PM -0500, Alex Deucher wrote:
From: Guenter Roeck groeck@chromium.org
ERROR: "__aeabi_uldivmod" [sound/soc/amd/snd-soc-acp-pcm.ko] undefined!
64-bit divides require special operations to avoid build errors on 32-bit systems.
Like I said in reply to your other mail please don't resubmit already applied patches. The current tip of my topic/amd branch appears to be this very patch, if there's anything needs changing please send an incremental patch.
I'm not seeing this one in your tree either. This is just a resend of Guenter's patch from an hour ago with the chromium stuff removed. Maybe you already applied it in the interim?
Alex
On Wed, Nov 08, 2017 at 01:40:32PM -0500, Alex Deucher wrote:
On Wed, Nov 8, 2017 at 1:22 PM, Mark Brown broonie@kernel.org wrote:
Like I said in reply to your other mail please don't resubmit already applied patches. The current tip of my topic/amd branch appears to be this very patch, if there's anything needs changing please send an incremental patch.
I'm not seeing this one in your tree either. This is just a resend of Guenter's patch from an hour ago with the chromium stuff removed. Maybe you already applied it in the interim?
Is this different to "ASoC: amd: Report accurate hw_ptr during dma" which was applied at 16:07?
-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Wednesday, November 08, 2017 1:48 PM To: Alex Deucher Cc: amd-gfx list; alsa-devel@alsa-project.org; Maling list - DRI developers; Mukunda, Vijendar; Liam Girdwood; Takashi Iwai; Guenter Roeck; Deucher, Alexander Subject: Re: [PATCH] ASoC: amd: fix report accurate hw_ptr during dma
On Wed, Nov 08, 2017 at 01:40:32PM -0500, Alex Deucher wrote:
On Wed, Nov 8, 2017 at 1:22 PM, Mark Brown broonie@kernel.org
wrote:
Like I said in reply to your other mail please don't resubmit already applied patches. The current tip of my topic/amd branch appears to be this very patch, if there's anything needs changing please send an incremental patch.
I'm not seeing this one in your tree either. This is just a resend of Guenter's patch from an hour ago with the chromium stuff removed. Maybe you already applied it in the interim?
Is this different to "ASoC: amd: Report accurate hw_ptr during dma" which was applied at 16:07?
Yes, this is a fix for that patch. It fixes a 64 bit division that wasn't properly handled.
Alex
participants (3)
-
Alex Deucher -
Deucher, Alexander -
Mark Brown