Hi, Mark:

Mark Brown broonie@kernel.org 於 2021年10月5日 週二 下午8:44寫道：

On Tue, Oct 05, 2021 at 08:36:44PM +0800, ChiYuan Huang wrote:

...

Mark Brown broonie@kernel.org 於 2021年10月5日 週二 下午7:54寫道：

...

On Tue, Oct 05, 2021 at 09:16:55AM +0800, cy_huang wrote:

...

...

...

• /* Default config volume to 0dB */
  

• snd_soc_component_write(comp, RT9120_REG_MSVOL, 0x180);
  

• /* Mute by default */
  

• snd_soc_component_update_bits(comp, RT9120_REG_VOLRAMP,
  

•                               RT9120_MUTE_MASK, RT9120_MUTE_MASK);
  

...

...

As ever you should leave the defaults at whatever the hardware defaults to, the defaults for one machine may not be suitable for another so we shouldn't be trying to do that in software.

...

The default volume will be kept in value 0x7ff (mute). I just want to follow the ASoC flow to control mute/unmute mask by AMP on/off. If to default set volume to 0dB and mute is improper, user have to use mixer control to configure the volume. Does mute function also need to be removed also?

It's totally fine and indeed quite common for devices to be muted by default - usually systems will have UCM profiles that unmute things by the time users actually interact with them.

Please don't take things off-list unless there is a really strong reason to do so. Sending things to the list ensures that everyone gets a chance to read and comment on things.

After asking the HW member, there's already builtin HW volume ramp function. Mute API is still no need. There's already no pop issue without mute function.

So the next change, I'll remove the default volume and mute config, and also mute API.

Thx.