[alsa-devel] ALSA C++ API
Even though I got no replies to my original announcement, here is a new version that wraps hw and sw params completely, has a macro for checking ALSA C function return values (throws alsa::error) and uses different naming style (similar to the C++ standard library). It is better documented now, too.
The code is now largely generated with macros, so it isn't very readable anymore :/
Next I'll be trying to figure out how the PCM API itself should be wrapped, for C++ style callbacks, etc. I am using the test/pcm.c program for my tests. Does it use good style for error recovery, etc? Mine will base on it, so this is important.
Example of use (a port of what test/pcm.c does using a few separate functions and 140 lines of code):
alsa::pcm handle(device); unsigned int rrate = rate; alsa::hw_config(handle) .rate_resample(resample) .set(transfer_methods[method].access) .set(format) .channels(channels) .rate_near(rrate) .buffer_time_near(buffer_time) .get_buffer_size(buffer_size) .period_time_near(period_time) .get_period_size(period_size) .commit(); if (rate != rrate) { std::cout << "Requested rate " << rate << " Hz, got " << rrate << " Hz" << std::endl; rate = rrate; } alsa::sw_config(handle) .start_threshold((buffer_size / period_size) * period_size) .avail_min(period_size) .xfer_align(1) .commit();
I'd prefer to use the Boost libraries (boost::function, boost::noncopyable, etc), but I am afraid that a dependency on them might be problematic. What do you think?
#ifndef ALSA_HPP_INCLUDED #define ALSA_HPP_INCLUDED
/**
@file alsa.hpp @brief An experimental low-level C++ API to ALSA. @version 0.3 @author Lasse Kärkkäinen <tronic> @license GNU LGPL 2.1 or later
This is a header-only C++ wrapper for the ALSA library. This means that you do not need to add any new binary files to your build and you will only need to link with -lasound, as if you were using the C API directly. GCC will probably optimize all of the wrapper overhead away in any case, leaving you with a safer and easier API to ALSA, but leaving your binaries just as if you had used C.
The library is designed to be very closely related to the C API, so that you can still see what is going on under the hood, and also so that porting existing applications to it is trivial. The interoperatibility between C and C++ APIs is is a major design goal. What this means is that you can freely mix C and C++ API calls with no problems.
Usage example:
alsa::pcm alsa_pcm; // Create a PCM object (defaults to playback and mode = 0)
The above creates an equivalent for the snd_pcm_t*, which is what you need to play or record anything. Make sure that the alsa_pcm object stays alive as long as you need it (and preferrably not longer) by putting it inside a suitable class or even inside the main() function. The object cannot be copied, but you can pass references to it to other objects or functions.
The alsa_pcm also automatically converts into snd_pcm_t* as required, so you can use it as an argument for the C API functions.
Next you'll need to configure it:
unsigned int rate = 44100; unsigned int period;
alsa::hw_config(alsa_pcm) // Create a new config space .set(SND_PCM_ACCESS_RW_INTERLEAVED) .set(SND_PCM_FORMAT_S16_LE) .rate_near(rate) .channels(1) .period_size_first(period) // Get the smallest available period size .commit(); // Apply the config to the PCM
alsa::hw_config(pcm) constructs a new config space, using the current settings from the PCM, if available, or the "any" space, if not set yet. The any space contains all available hardware configurations and you have to narrow it down to exactly one option by setting some parameters. Trying to narrow it too much (by asking an amount of channels that is not available, for example) causes a failure.
In case of failure, an alsa::error is thrown. When this happens, the commit part never gets executed and thus the result is not stored to alsa_pcm and the failed operation will have no effect (even to the temporary hw_config object, which gets destroyed when the exception flies). However, all the operations already performed successfully remain in effect.
The rate_near functions behaves like the C API *_near functions do: they take the preferred value as an argument and then they modify the argument, returning the actual rate. For example, if your sound card only supports 48000 Hz, rate will be set to that on that call, even if some later part, such as setting the number of channels, fails.
In the example above, a temporary object of type alsa::hw_config was used, but you can also create a variable of it, should you need to test something in between, or if you want to call the C API functions directly (hw_config converts automatically into hw_params, which converts into snd_hw_params_t*).
For this, you may use a block like this:
{ alsa::hw_config hw(alsa_pcm); hw.set(SND_ACCESS_(SND_PCM_ACCESS_MMAP_INTERLEAVED); hw.set(SND_PCM_FORMAT_FLOAT_BE); if (!snd_pcm_hw_params_is_full_duplex(hw)) hw.channels(2); hw.commit(); }
(anyone got a better example?)
Software configuration works in the same way, using alsa::sw_config, just the parameters to be adjusted are different.
When constructed, both sw_config and hw_config try to load config from the given PCM. If that fails, sw_config throws, but hw_config still tries loading the any space. Alternatively, you may supply a snd_pcm_hw/sw_params_t const* as a second argument for the constructor to get a copy of the contents of that that instead.
The contents may be loaded (overwrites the old contents) with these functions: .any() Get the "any" configuration (hw_config only) .current() Get the currently active configuration from PCM Once finished with the changes, you should call: .commit() Store current config space to the PCM
For enum values SND_PCM_*, you may use the following functions: .get(var) Get the current setting into the given variable .set(val) Set the value requested (also supports masks) .enum_test(val) The same as .set, except that it does not set anything .enum_first(var) Set the first available option, store the selection in var .enum_last(var) Set the last available option, store the selection in var
The parameter to manipulate is chosen based on the argument type. The enum_* functions and masks are only available for hardware parameters, not for sw_param.
For integer values (times, sizes, counts), these functions are available: .get_X(var) Get the current setting into the given variable .X(val) Set the value requested For ranges, the following can also be used: .get_X_min(var) Get the smallest available value into var .get_X_max(var) Get the largest available value into var .X_min(var) Remove all values smaller than var and store the new smallest value into var. .X_max(var) Remove all values larger than var, store new max in var. .X_minmax(v1, v2) Limit to [v1, v2], store new range in v1, v2. .X_near(var) Set the closest available value and store it in var .X_first(var) Set the first available option, store the selection in var .X_last(var) Set the last available option, store the selection in var
For booleans, these functions are available: .get_X(var) Get the current setting (var must be unsigned int or bool) .set_X(val) Set the value (val can be anything that converts into bool)
Replace X with the name of the parameter that you want to set. Consult the ALSA C library reference for available options. All functions that modify their arguments require the same type as is used in the C API (often unsigned int or snd_pcm_uframes_t). The only exception is with bool types, where both bool and unsigned int are accepted.
For those ranged parameters that support the dir argument (see ALSA docs), the default value is always 0 when writing and NULL (none) when reading. You may supply the preferred dir value or variable as the second argument and then the value will be used or the result will be stored in the variable supplied.
For example, the following calls are equivalent: snd_pcm_hw_params_set_format(pcm, hw, SND_PCM_FORMAT_FLOAT_LE) <=> hw.set(SND_PCM_FORMAT_FLOAT_LE) snd_pcm_hw_params_set_rate_resample(pcm, hw, 1) <=> hw.rate_resample(true) snd_pcm_hw_params_set_channels_near(pcm, hw, &num) <=> hw.channels_near(num) snd_pcm_hw_params_get_rate(hw, &rate, NULL) <=> hw.get_rate(rate) snd_pcm_hw_params_get_rate(hw, &rate, &dir) <=> hw.get_rate(rate, dir)
... except for the fact that the C++ versions also check the return values and throw alsa::error if anything goes wrong. alsa::error inherits from std::runtime_error and thus eventually from std::exception, so you can catch pretty much everything by catching that somewhere in your code:
try { // do everything here } catch (std::exception& e) { std::cerr << "FATAL ERROR: " << e.what() << std::endl; }
However, recent versions of glibc seem to be handling uncaught exceptions quite nicely, so even without a try-catch you may get a nice printout in your console:
terminate called after throwing an instance of 'alsa::error' what(): ALSA snd_pcm_hw_params_set_channels failed: Invalid argument Aborted
If you need to know the error code, you may call e.code() after catching alsa::error& e.
When you want to get low-level, the ALSA_CHECKED macro may prove to be useful. It is used internally by the library for testing errors and throwing exceptions when calling the C API functions. It will throw alsa::error with a description of the error if the function returns a negative value.
The macro is well-behaving, so it does not mess up if-elses or other structures and it evaluates its arguments exactly once.
Usage: ALSA_CHECKED(snd_pcm_whatever, (arg1, arg2, arg2));
Note: a comma between function name and arguments.
In case you really want to get low-level, alsa::hw_params and alsa::sw_params are offered. These only contain the corresponding snd_pcm_*_params_t, but they allocate and free memory automatically and they can also properly copy the struct contents when they get copied. Be aware that the structure contents are not initialized during construction, so you have to initialize it yourself (just like with the C API). They are used internally by hw_config and sw_config and normally it should be better to use these instead of dealing directly with the params.
**/
#include <alsa/asoundlib.h> #include <stdexcept> #include <string>
/** * A macro that executes func with the given args and tests for errors. * @throws alsa::error if the return value is smaller than zero. **/ #define ALSA_CHECKED(func, args) do { int err = func args; if (err < 0) throw alsa::error(#func, err); } while (0)
namespace alsa { namespace util { /** * @short FOR INTERNAL USE ONLY. A utility class similar to * boost::noncopyable, duplicated here in order to avoid * a dependency on the Boost library. **/ class noncopyable { protected: noncopyable() {} ~noncopyable() {} private: noncopyable(noncopyable const&); noncopyable const& operator=(noncopyable const&); }; }
/** @short Exception class **/ class error: public std::runtime_error { int err; public: error(std::string const& function, int err): std::runtime_error("ALSA " + function + " failed: " + std::string(snd_strerror(err))), err(err) {} int code() const { return err; } };
/** * @short A minimal RAII wrapper for ALSA PCM. * Automatically converts into snd_pcm_t* as needed, so the ALSA C API * can be used directly with this. **/ class pcm: util::noncopyable { snd_pcm_t* handle; public: pcm(char const* device = "default", snd_pcm_stream_t stream = SND_PCM_STREAM_PLAYBACK, int mode = 0) { ALSA_CHECKED(snd_pcm_open, (&handle, device, stream, mode)); } ~pcm() { snd_pcm_close(handle); } operator snd_pcm_t*() { return handle; } operator snd_pcm_t const*() const { return handle; } };
// RAII wrapper for snd_pcm_hw/sw_params_t types. #define ALSA_HPP_PARAMWRAPPER(type) \ class type##_params {\ snd_pcm_##type##_params_t* handle;\ void init() { ALSA_CHECKED(snd_pcm_##type##_params_malloc, (&handle)); }\ public:\ type##_params() { init(); }\ ~type##_params() { snd_pcm_##type##_params_free(handle); }\ type##_params(type##_params const& orig) { init(); *this = orig; }\ type##_params(snd_pcm_##type##_params_t const* orig) { init(); *this = orig; }\ type##_params& operator=(snd_pcm_##type##_params_t const* params) {\ if (handle != params) snd_pcm_##type##_params_copy(handle, params);\ return *this;\ }\ operator snd_pcm_##type##_params_t*() { return handle; }\ operator snd_pcm_##type##_params_t const*() const { return handle; }\ };
ALSA_HPP_PARAMWRAPPER(hw) ALSA_HPP_PARAMWRAPPER(sw) #undef ALSA_HPP_PARAMWRAPPER
// Various helper macros used for generating code for hw_config and sw_config
#define ALSA_HPP_FUNC(name, suffix) ALSA_HPP_TEMPLATE(& name(), suffix, (pcm, params))
#define ALSA_HPP_VARGET(name, type) \ ALSA_HPP_TEMPLATE(& get_##name(type& val), _get_##name, (params, &val))\ ALSA_HPP_TEMPLATE(const& get_##name(type& val) const, _get_##name, (params, &val))
#define ALSA_HPP_VAR(name, type) ALSA_HPP_VARGET(name, type)\ ALSA_HPP_TEMPLATE(& name(type val), _set_##name, (pcm, params, val))
#define ALSA_HPP_ENUMVARMINIMAL(name) \ ALSA_HPP_TEMPLATE(& get(snd_pcm_##name##_t& name), _get_##name, (params, &name))\ ALSA_HPP_TEMPLATE(const& get(snd_pcm_##name##_t& name) const, _get_##name, (params, &name))\ ALSA_HPP_TEMPLATE(& set(snd_pcm_##name##_t name), _set_##name, (pcm, params, name))
#define ALSA_HPP_ENUMVAR(name) ALSA_HPP_ENUMVARMINIMAL(name)\ ALSA_HPP_TEMPLATE(& enum_test(snd_pcm_##name##_t name), _test_##name, (pcm, params, name))\ ALSA_HPP_TEMPLATE(& enum_first(snd_pcm_##name##_t& name), _set_##name##_first, (pcm, params, &name))\ ALSA_HPP_TEMPLATE(& enum_last(snd_pcm_##name##_t& name), _set_##name##_last, (pcm, params, &name))\ ALSA_HPP_TEMPLATE(& set(snd_pcm_##name##_mask_t* mask), _set_##name##_mask, (pcm, params, mask))
#define ALSA_HPP_BOOLVAR(name) \ ALSA_HPP_CLASS& get_##name(bool& val) { unsigned int tmp; get_##name(tmp); val = tmp; return *this; }\ /*ALSA_HPP_CLASS const& get_##name(bool& val) const { unsigned int tmp; get_##name(tmp); val = tmp; return *this; }*/\ ALSA_HPP_TEMPLATE(& get_##name(unsigned int& val), _get_##name, (pcm, params, &val))\ /*ALSA_HPP_TEMPLATE(const& get_##name(unsigned int& val) const, _get_##name, (pcm, params, &val))*/\ ALSA_HPP_TEMPLATE(& name(bool val = true), _set_##name, (pcm, params, val))
#define ALSA_HPP_RANGEVAR(name, type) ALSA_HPP_VAR(name, type)\ ALSA_HPP_TEMPLATE(& get_##name##_min(type& min), _get_##name##_min, (params, &min))\ ALSA_HPP_TEMPLATE(const& get_##name##_min(type& min) const, _get_##name##_min, (params, &min))\ ALSA_HPP_TEMPLATE(& get_##name##_max(type& max), _get_##name##_max, (params, &max))\ ALSA_HPP_TEMPLATE(const& get_##name##_max(type& max) const, _get_##name##_max, (params, &max))\ ALSA_HPP_TEMPLATE(& name##_min(type& min), _set_##name##_min, (pcm, params, &min))\ ALSA_HPP_TEMPLATE(& name##_max(type& max), _set_##name##_max, (pcm, params, &max))\ ALSA_HPP_TEMPLATE(& name##_minmax(type& min, type& max), _set_##name##_minmax, (pcm, params, &min, &max))\ ALSA_HPP_TEMPLATE(& name##_near(type& val), _set_##name##_near, (pcm, params, &val))\ ALSA_HPP_TEMPLATE(& name##_first(type& val), _set_##name##_first, (pcm, params, &val))\ ALSA_HPP_TEMPLATE(& name##_last(type& val), _set_##name##_last, (pcm, params, &val))
#define ALSA_HPP_RANGEVARDIR(name, type) \ ALSA_HPP_TEMPLATE(& get_##name(type& val), _get_##name, (params, &val, NULL))\ ALSA_HPP_TEMPLATE(const& get_##name(type& val) const, _get_##name, (params, &val, NULL))\ ALSA_HPP_TEMPLATE(& get_##name(type& val, int& dir), _get_##name, (params, &val, &dir))\ ALSA_HPP_TEMPLATE(const& get_##name(type& val, int& dir) const, _get_##name, (params, &val, &dir))\ ALSA_HPP_TEMPLATE(& get_##name##_min(type& min), _get_##name##_min, (params, &min, NULL))\ ALSA_HPP_TEMPLATE(const& get_##name##_min(type& min) const, _get_##name##_min, (params, &min, NULL))\ ALSA_HPP_TEMPLATE(& get_##name##_min(type& min, int& dir), _get_##name##_min, (params, &min, &dir))\ ALSA_HPP_TEMPLATE(const& get_##name##_min(type& min, int& dir) const, _get_##name##_min, (params, &min, &dir))\ ALSA_HPP_TEMPLATE(& get_##name##_max(type& max), _get_##name##_max, (params, &max, NULL))\ ALSA_HPP_TEMPLATE(const& get_##name##_max(type& max) const, _get_##name##_max, (params, &max, NULL))\ ALSA_HPP_TEMPLATE(& get_##name##_max(type& max, int& dir), _get_##name##_max, (params, &max, &dir))\ ALSA_HPP_TEMPLATE(const& get_##name##_max(type& max, int& dir) const, _get_##name##_max, (params, &max, &dir))\ ALSA_HPP_TEMPLATE(& name(type val, int dir = 0), _set_##name, (pcm, params, val, dir))\ ALSA_HPP_TEMPLATE(& name##_min(type& min), _set_##name##_min, (pcm, params, &min, NULL))\ ALSA_HPP_TEMPLATE(& name##_min(type& min, int& dir), _set_##name##_min, (pcm, params, &min, &dir))\ ALSA_HPP_TEMPLATE(& name##_max(type& max), _set_##name##_max, (pcm, params, &max, NULL))\ ALSA_HPP_TEMPLATE(& name##_max(type& max, int& dir), _set_##name##_max, (pcm, params, &max, &dir))\ ALSA_HPP_TEMPLATE(& name##_minmax(type& min, type& max), _set_##name##_minmax, (pcm, params, &min, NULL, &max, NULL))\ ALSA_HPP_TEMPLATE(& name##_minmax(type& min, int& mindir, type& max, int& maxdir), _set_##name##_minmax, (pcm, params, &min, &mindir, &max, &maxdir))\ ALSA_HPP_TEMPLATE(& name##_near(type& val), _set_##name##_near, (pcm, params, &val, NULL))\ ALSA_HPP_TEMPLATE(& name##_near(type& val, int& dir), _set_##name##_near, (pcm, params, &val, &dir))\ ALSA_HPP_TEMPLATE(& name##_first(type& val), _set_##name##_first, (pcm, params, &val, NULL))\ ALSA_HPP_TEMPLATE(& name##_first(type& val, int& dir), _set_##name##_first, (pcm, params, &val, &dir))\ ALSA_HPP_TEMPLATE(& name##_last(type& val), _set_##name##_last, (pcm, params, &val, NULL))\ ALSA_HPP_TEMPLATE(& name##_last(type& val, int& dir), _set_##name##_last, (pcm, params, &val, &dir))
/** @short A helper object for modifying hw_params of a PCM. **/ class hw_config: util::noncopyable { snd_pcm_t* pcm; hw_params params; public: /** * Construct a new config object, initialized with the current settings * of the PCM or with the "any" configuration space, if there are none. **/ hw_config(snd_pcm_t* pcm): pcm(pcm) { try { current(); } catch (std::runtime_error&) { any(); } } /** Construct a new config object, initialized with a copy from given parameters **/ hw_config(snd_pcm_t* pcm, snd_pcm_hw_params_t const* params): pcm(pcm), params(params) {} operator hw_params&() { return params; } operator hw_params const&() const { return params; } #define ALSA_HPP_CLASS hw_config #define ALSA_HPP_TEMPLATE(proto, suffix, params) ALSA_HPP_CLASS proto { ALSA_CHECKED(snd_pcm_hw_params##suffix, params); return *this; } // Load / store functions ALSA_HPP_FUNC(commit,) ALSA_HPP_FUNC(any, _any) ALSA_HPP_FUNC(current, _current) // Enum functions ALSA_HPP_ENUMVAR(access) ALSA_HPP_ENUMVAR(format) ALSA_HPP_ENUMVAR(subformat) // Bool functions ALSA_HPP_BOOLVAR(rate_resample) ALSA_HPP_BOOLVAR(export_buffer) // Range functions ALSA_HPP_RANGEVAR(channels, unsigned int) ALSA_HPP_RANGEVAR(buffer_size, snd_pcm_uframes_t) // Range functions with direction argument ALSA_HPP_RANGEVARDIR(rate, unsigned int) ALSA_HPP_RANGEVARDIR(period_time, unsigned int) ALSA_HPP_RANGEVARDIR(period_size, snd_pcm_uframes_t) ALSA_HPP_RANGEVARDIR(periods, unsigned int) ALSA_HPP_RANGEVARDIR(buffer_time, unsigned int) ALSA_HPP_RANGEVARDIR(tick_time, unsigned int) #undef ALSA_HPP_TEMPLATE #undef ALSA_HPP_CLASS };
class sw_config: util::noncopyable { snd_pcm_t* pcm; sw_params params; public: sw_config(snd_pcm_t* pcm): pcm(pcm) { current(); } /** Construct a new config object, initialized with a copy from given parameters **/ sw_config(snd_pcm_t* pcm, snd_pcm_sw_params_t const* params): pcm(pcm), params(params) {} operator sw_params&() { return params; } operator sw_params const&() const { return params; } #define ALSA_HPP_CLASS sw_config #define ALSA_HPP_TEMPLATE(proto, suffix, params) ALSA_HPP_CLASS proto { ALSA_CHECKED(snd_pcm_sw_params##suffix, params); return *this; } // Load / store functions ALSA_HPP_FUNC(commit,) ALSA_HPP_FUNC(current, _current) // Enum functions typedef snd_pcm_tstamp_t snd_pcm_tstamp_mode_t; // Workaround for inconsistent naming in asound ALSA_HPP_ENUMVARMINIMAL(tstamp_mode) // Simple variable functions ALSA_HPP_VAR(sleep_min, unsigned int) ALSA_HPP_VAR(avail_min, snd_pcm_uframes_t) ALSA_HPP_VAR(xfer_align, snd_pcm_uframes_t) ALSA_HPP_VAR(start_threshold, snd_pcm_uframes_t) ALSA_HPP_VAR(stop_threshold, snd_pcm_uframes_t) ALSA_HPP_VAR(silence_threshold, snd_pcm_uframes_t) ALSA_HPP_VAR(silence_size, snd_pcm_uframes_t) // Get-only variable ALSA_HPP_VARGET(boundary, snd_pcm_uframes_t) #undef ALSA_HPP_TEMPLATE #undef ALSA_HPP_CLASS };
#undef ALSA_HPP_FUNC #undef ALSA_HPP_VAR #undef ALSA_HPP_VARGET #undef ALSA_HPP_ENUMVAR #undef ALSA_HPP_ENUMVARMINIMAL #undef ALSA_HPP_BOOLVAR #undef ALSA_HPP_RANGEVAR #undef ALSA_HPP_RANGEVARDIR
}
#endif
On 09/18/2007 10:19 PM, Lasse Kärkkäinen wrote:
Even though I got no replies to my original announcement, here is a new version that wraps hw and sw params completely, has a macro for checking ALSA C function return values (throws alsa::error) and uses different naming style (similar to the C++ standard library). It is better documented now, too.
The code is now largely generated with macros, so it isn't very readable anymore :/
It's C++ -- what's new? :\
Rene.
At Wed, 19 Sep 2007 04:55:22 +0200, Rene Herman wrote:
On 09/18/2007 10:19 PM, Lasse Kärkkäinen wrote:
Even though I got no replies to my original announcement, here is a new version that wraps hw and sw params completely, has a macro for checking ALSA C function return values (throws alsa::error) and uses different naming style (similar to the C++ standard library). It is better documented now, too.
The code is now largely generated with macros, so it isn't very readable anymore :/
It's C++ -- what's new? :\
C++ isn't unreadable unless you use template :)
Takashi
On 09/19/2007 02:16 PM, Takashi Iwai wrote:
At Wed, 19 Sep 2007 04:55:22 +0200, Rene Herman wrote:
On 09/18/2007 10:19 PM, Lasse Kärkkäinen wrote:
Even though I got no replies to my original announcement, here is a new version that wraps hw and sw params completely, has a macro for checking ALSA C function return values (throws alsa::error) and uses different naming style (similar to the C++ standard library). It is better documented now, too.
The code is now largely generated with macros, so it isn't very readable anymore :/
It's C++ -- what's new? :\
C++ isn't unreadable unless you use template :)
And unless you use function and/or operator overloading, or exceptions, or well, any C++ feature really.
I'll admit that by now my C++ is becoming fairly historical (I'm from before the namespace thing...) but C++ very much by design has this major "behind your back" thing going which often means that it stays readable only as long as you don't actually _have_ to read it at any level of detail.
Well -- such is my impression. I did look at what was posted, and it didn't look too scary, just header mapping to libasound directly. If (other) C++ programmers would confirm this is useful, perhaps something for the main ALSA distribution?
Rene.
At Tue, 18 Sep 2007 23:19:10 +0300, Lasse Kärkkäinen wrote:
Even though I got no replies to my original announcement, here is a new version that wraps hw and sw params completely, has a macro for checking ALSA C function return values (throws alsa::error) and uses different naming style (similar to the C++ standard library). It is better documented now, too.
The code is now largely generated with macros, so it isn't very readable anymore :/
First, thanks for your work! I had little time to review and comment on it until now.
Honestly speaking, I prefer your former version to this new one. The readability is more important than a bit of performance improvement, especially for such a "wrapper". If we need more performance, we should rewrite it to bypass many redundant C bindings.
How about to put the most of implementation codes to .cc instead of inlining in the header? Also, we don't have to export every alsa-lib functionality. There are many rotten, obsolete and almost internal-only functions.
Next I'll be trying to figure out how the PCM API itself should be wrapped, for C++ style callbacks, etc. I am using the test/pcm.c program for my tests. Does it use good style for error recovery, etc? Mine will base on it, so this is important.
You can use snd_pcm_recover() as a generic solution. It handles both for XRUN and suspend/resume.
Example of use (a port of what test/pcm.c does using a few separate functions and 140 lines of code):
alsa::pcm handle(device); unsigned int rrate = rate; alsa::hw_config(handle) .rate_resample(resample) .set(transfer_methods[method].access) .set(format) .channels(channels) .rate_near(rrate) .buffer_time_near(buffer_time) .get_buffer_size(buffer_size) .period_time_near(period_time) .get_period_size(period_size) .commit(); if (rate != rrate) { std::cout << "Requested rate " << rate << " Hz, got " << rrate << " Hz" << std::endl; rate = rrate; } alsa::sw_config(handle) .start_threshold((buffer_size / period_size) * period_size) .avail_min(period_size) .xfer_align(1) .commit();
I'd prefer to use the Boost libraries (boost::function, boost::noncopyable, etc), but I am afraid that a dependency on them might be problematic. What do you think?
That's true. Boost is often a nightmare for distributions :) But, if it gives more benifits, it might be worth. Do you have a certain idea how will it be?
thanks,
Takashi
participants (3)
-
Lasse Kärkkäinen
-
Rene Herman
-
Takashi Iwai