[alsa-devel] [PATCH] ASoC: Intel: boards: add dmic format constraint
From: Mac Chiang mac.chiang@intel.com
platform dmic recording fixup 16bits
Signed-off-by: Mac Chiang mac.chiang@intel.com --- sound/soc/intel/boards/bxt_da7219_max98357a.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c b/sound/soc/intel/boards/bxt_da7219_max98357a.c index 5cadb7f..ac06408 100644 --- a/sound/soc/intel/boards/bxt_da7219_max98357a.c +++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c @@ -330,6 +330,9 @@ static int broxton_dmic_startup(struct snd_pcm_substream *substream) snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, &constraints_channels_quad);
+ runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE; + snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16); + return snd_pcm_hw_constraint_list(substream->runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &constraints_rates); }
On 6/18/19 7:48 AM, mac.chiang@intel.com wrote:
From: Mac Chiang mac.chiang@intel.com
platform dmic recording fixup 16bits
Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact. Thanks!
Signed-off-by: Mac Chiang mac.chiang@intel.com
sound/soc/intel/boards/bxt_da7219_max98357a.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c b/sound/soc/intel/boards/bxt_da7219_max98357a.c index 5cadb7f..ac06408 100644 --- a/sound/soc/intel/boards/bxt_da7219_max98357a.c +++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c @@ -330,6 +330,9 @@ static int broxton_dmic_startup(struct snd_pcm_substream *substream) snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, &constraints_channels_quad);
- runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE;
- snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16);
- return snd_pcm_hw_constraint_list(substream->runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &constraints_rates); }
Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact.
Hi Pierre, this is for APL platform.
-----Original Message----- From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@linux.intel.com] Sent: Tuesday, June 18, 2019 2:56 PM To: Chiang, Mac mac.chiang@intel.com; alsa-devel@alsa-project.org Cc: N, Harshapriya harshapriya.n@intel.com; broonie@kernel.org; Zhi, Yong yong.zhi@intel.com Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: boards: add dmic format constraint
On 6/18/19 7:48 AM, mac.chiang@intel.com wrote:
From: Mac Chiang mac.chiang@intel.com
platform dmic recording fixup 16bits
Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact. Thanks!
Signed-off-by: Mac Chiang mac.chiang@intel.com
sound/soc/intel/boards/bxt_da7219_max98357a.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c b/sound/soc/intel/boards/bxt_da7219_max98357a.c index 5cadb7f..ac06408 100644 --- a/sound/soc/intel/boards/bxt_da7219_max98357a.c +++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c @@ -330,6 +330,9 @@ static int broxton_dmic_startup(struct snd_pcm_substream *substream) snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, &constraints_channels_quad);
- runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE;
- snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16);
- return snd_pcm_hw_constraint_list(substream->runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &constraints_rates); }
On 6/18/19 10:41 AM, Chiang, Mac wrote:
Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact.
Hi Pierre, this is for APL platform.
ok. please don't top-post and copy/paste...
-----Original Message----- From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@linux.intel.com] Sent: Tuesday, June 18, 2019 2:56 PM To: Chiang, Mac mac.chiang@intel.com; alsa-devel@alsa-project.org Cc: N, Harshapriya harshapriya.n@intel.com; broonie@kernel.org; Zhi, Yong yong.zhi@intel.com Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: boards: add dmic format constraint
On 6/18/19 7:48 AM, mac.chiang@intel.com wrote:
From: Mac Chiang mac.chiang@intel.com
platform dmic recording fixup 16bits
Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact. Thanks!
Signed-off-by: Mac Chiang mac.chiang@intel.com
This change is only for front-ends that are overridden by SOF, so assuming the rest of the Chrome folks are aligned on this:
Acked-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
sound/soc/intel/boards/bxt_da7219_max98357a.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c b/sound/soc/intel/boards/bxt_da7219_max98357a.c index 5cadb7f..ac06408 100644 --- a/sound/soc/intel/boards/bxt_da7219_max98357a.c +++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c @@ -330,6 +330,9 @@ static int broxton_dmic_startup(struct snd_pcm_substream *substream) snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, &constraints_channels_quad);
- runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE;
- snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16);
- return snd_pcm_hw_constraint_list(substream->runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &constraints_rates); }
Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (3)
-
Chiang, Mac -
mac.chiang＠intel.com
-
Pierre-Louis Bossart