[PATCH AUTOSEL 5.16 54/59] ASoC: Intel: sof_es8336: log all quirks
From: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
[ Upstream commit 9c818d849192491a8799b1cb14ca0f7aead4fb09 ]
We only logged the SSP quirk, make sure the GPIO and DMIC quirks are exposed.
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com Reviewed-by: Bard Liao yung-chuan.liao@linux.intel.com Reviewed-by: Péter Ujfalusi peter.ujfalusi@linux.intel.com Link: https://lore.kernel.org/r/20220308192610.392950-16-pierre-louis.bossart@linu... Signed-off-by: Mark Brown broonie@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org --- sound/soc/intel/boards/sof_es8336.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/sof_es8336.c b/sound/soc/intel/boards/sof_es8336.c index 46e453915f82..764560439d46 100644 --- a/sound/soc/intel/boards/sof_es8336.c +++ b/sound/soc/intel/boards/sof_es8336.c @@ -63,7 +63,12 @@ static const struct acpi_gpio_mapping *gpio_mapping = acpi_es8336_gpios;
static void log_quirks(struct device *dev) { - dev_info(dev, "quirk SSP%ld", SOF_ES8336_SSP_CODEC(quirk)); + dev_info(dev, "quirk mask %#lx\n", quirk); + dev_info(dev, "quirk SSP%ld\n", SOF_ES8336_SSP_CODEC(quirk)); + if (quirk & SOF_ES8336_ENABLE_DMIC) + dev_info(dev, "quirk DMIC enabled\n"); + if (quirk & SOF_ES8336_TGL_GPIO_QUIRK) + dev_info(dev, "quirk TGL GPIO enabled\n"); }
static int sof_es8316_speaker_power_event(struct snd_soc_dapm_widget *w,
HI Sasha,
Em Wed, 30 Mar 2022 07:48:26 -0400 Sasha Levin sashal@kernel.org escreveu:
From: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
[ Upstream commit 9c818d849192491a8799b1cb14ca0f7aead4fb09 ]
We only logged the SSP quirk, make sure the GPIO and DMIC quirks are exposed.
Checking the backports for sof_es8336, it would be nice to also backport this one:
https://lore.kernel.org/all/20220308192610.392950-20-pierre-louis.bossart@li...
Without that, UCM won't detect a digital microphone and would fallback to analog mic, which won't work on machines with digital mic.
-
Btw, I'm testing those using upstream UCM plus a couple of fixes I applied on the top of it:
https://github.com/mchehab/alsa-ucm-conf/commits/master
there's a pending PR#144 for upstream's alsa-ucm-conf fixing 3 issues at the UCM logic for essx8336.
Tested on a Huawei Matebook D15 notebook.
Thanks, Mauro
participants (2)
-
Mauro Carvalho Chehab
-
Sasha Levin