On Sun 26 Mar 2023 at 14:43, Christophe JAILLET christophe.jaillet@wanadoo.fr wrote:

Use devm_clk_get_optional() instead of hand writing it. This saves some loC and improves the semantic.

Signed-off-by: Christophe JAILLET christophe.jaillet@wanadoo.fr

Thx.

Reviewed-by: Jerome Brunet jbrunet@baylibre.com

---

sound/soc/meson/axg-tdm-interface.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/sound/soc/meson/axg-tdm-interface.c b/sound/soc/meson/axg-tdm-interface.c index 7624aafe9009..5e5e4c56d505 100644 --- a/sound/soc/meson/axg-tdm-interface.c +++ b/sound/soc/meson/axg-tdm-interface.c @@ -496,7 +496,7 @@ static int axg_tdm_iface_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct snd_soc_dai_driver *dai_drv; struct axg_tdm_iface *iface;

• int ret, i;

• int i;

  iface = devm_kzalloc(dev, sizeof(*iface), GFP_KERNEL); if (!iface)

@@ -533,14 +533,9 @@ static int axg_tdm_iface_probe(struct platform_device *pdev) * At this point, ignore the error if mclk is missing. We'll * throw an error if the cpu dai is master and mclk is missing */

• iface->mclk = devm_clk_get(dev, "mclk");
• if (IS_ERR(iface->mclk)) {

• ret = PTR_ERR(iface->mclk);
  

• if (ret == -ENOENT)
  

• 	iface->mclk = NULL;
  

• else
  

• 	return dev_err_probe(dev, ret, "failed to get mclk\n");
  

• }

• iface->mclk = devm_clk_get_optional(dev, "mclk");

• if (IS_ERR(iface->mclk))

• return dev_err_probe(dev, PTR_ERR(iface->mclk), "failed to get mclk\n");
  
  

  return devm_snd_soc_register_component(dev, &axg_tdm_iface_component_drv, dai_drv,