[alsa-devel] 2.6.28-rc2-mm1 - sound semi-busted on Dell Latitude D820
Sometime between -mmotm1017 and -rc2-mm1, something odd happened to the sound subsystem. On my Dell Latitude D820, audio works OK if it's sitting there standalone, or in its docking station.
However, when I plug in headphones, it goes silent.
Sorry for not having any more detail, but I've not had a chance to bisect this down to a specific commit.
I did run alsa-info for the two kernels, here's a diff between them. I also attached a copy of the full output for working -mmotm1017.
(- lines are working -mmotm-1017, + are busted -rc2-mm1)
--- alsa-info-mmotm1017 2008-11-10 14:17:04.000000000 -0500 +++ alsa-info-rc3-mm1 2008-11-10 14:13:17.000000000 -0500 @@ -3,7 +3,7 @@ !!ALSA Information Script v 0.4.51 !!################################
-!!Script ran on: Mon Nov 10 14:16:47 EST 2008 +!!Script ran on: Mon Nov 10 14:12:28 EST 2008
!!Linux Distribution @@ -15,7 +15,7 @@ !!Kernel Information !!------------------
-Kernel release: 2.6.27-mmotm1017 +Kernel release: 2.6.28-rc3-mm1 Operating System: GNU/Linux Architecture: x86_64 Processor: x86_64 @@ -25,7 +25,7 @@ !!ALSA Version !!------------
-Driver version: 1.0.18rc3 +Driver version: 1.0.18 Library version: 1.0.18rc3 Utilities version: 1.0.18rc3
@@ -39,7 +39,7 @@ !!-----------------------------
0 [Intel ]: HDA-Intel - HDA Intel - HDA Intel at 0xefffc000 irq 314 + HDA Intel at 0xefffc000 irq 41
!!PCI Soundcards installed in the system @@ -165,8 +165,8 @@ Pin Default 0x0321121f: [Jack] HP Out at Ext Left Conn = 1/8, Color = Black DefAssociation = 0x1, Sequence = 0xf - Pin-ctls: 0xc0: OUT HP - Unsolicited: tag=30, enabled=1 + Pin-ctls: 0x00: + Unsolicited: tag=3d, enabled=1 Connection: 1 0x0b Node 0x0e [Pin Complex] wcaps 0x400181: Stereo @@ -234,12 +234,12 @@ !!ALSA Device nodes !!-----------------
Looks like it lost the bits that setup the headphone jack.
At Mon, 10 Nov 2008 14:35:58 -0500, Valdis.Kletnieks@vt.edu wrote:
Sometime between -mmotm1017 and -rc2-mm1, something odd happened to the sound subsystem. On my Dell Latitude D820, audio works OK if it's sitting there standalone, or in its docking station.
However, when I plug in headphones, it goes silent.
To confirm a regression, could you copy sound/pci/hda/patch_sigmatel.c from 2.6.27 kernel and check the driver works? Does the same problem exist in 2.6.28-rc kernel?
Also, just to make sure, try sound-2.6.git tree, too: git://git.kernel.org/pub/scm/linux/kenrel/git/tiwai/sound-2.6.git
thanks,
Takashi
Sorry for not having any more detail, but I've not had a chance to bisect this down to a specific commit.
I did run alsa-info for the two kernels, here's a diff between them. I also attached a copy of the full output for working -mmotm1017.
(- lines are working -mmotm-1017, + are busted -rc2-mm1)
--- alsa-info-mmotm1017 2008-11-10 14:17:04.000000000 -0500 +++ alsa-info-rc3-mm1 2008-11-10 14:13:17.000000000 -0500 @@ -3,7 +3,7 @@ !!ALSA Information Script v 0.4.51 !!################################
-!!Script ran on: Mon Nov 10 14:16:47 EST 2008 +!!Script ran on: Mon Nov 10 14:12:28 EST 2008
!!Linux Distribution @@ -15,7 +15,7 @@ !!Kernel Information !!------------------
-Kernel release: 2.6.27-mmotm1017 +Kernel release: 2.6.28-rc3-mm1 Operating System: GNU/Linux Architecture: x86_64 Processor: x86_64 @@ -25,7 +25,7 @@ !!ALSA Version !!------------
-Driver version: 1.0.18rc3 +Driver version: 1.0.18 Library version: 1.0.18rc3 Utilities version: 1.0.18rc3
@@ -39,7 +39,7 @@ !!-----------------------------
0 [Intel ]: HDA-Intel - HDA Intel
HDA Intel at 0xefffc000 irq 314
HDA Intel at 0xefffc000 irq 41!!PCI Soundcards installed in the system @@ -165,8 +165,8 @@ Pin Default 0x0321121f: [Jack] HP Out at Ext Left Conn = 1/8, Color = Black DefAssociation = 0x1, Sequence = 0xf
- Pin-ctls: 0xc0: OUT HP
- Unsolicited: tag=30, enabled=1
- Pin-ctls: 0x00:
- Unsolicited: tag=3d, enabled=1 Connection: 1 0x0b
Node 0x0e [Pin Complex] wcaps 0x400181: Stereo @@ -234,12 +234,12 @@ !!ALSA Device nodes !!-----------------
Looks like it lost the bits that setup the headphone jack.
[1.2 alsa-info-mmotm1017 <text/plain; us-ascii (7bit)>] upload=true&script=true&cardinfo= !!################################ !!ALSA Information Script v 0.4.51 !!################################
!!Script ran on: Mon Nov 10 14:16:47 EST 2008
!!Linux Distribution !!------------------
Fedora release 9.93 (Rawhide) Fedora release 9.93 (Rawhide) Fedora release 9.93 (Rawhide) Fedora release 9.93 (Rawhide)
!!Kernel Information !!------------------
Kernel release: 2.6.27-mmotm1017 Operating System: GNU/Linux Architecture: x86_64 Processor: x86_64 SMP Enabled: Yes
!!ALSA Version !!------------
Driver version: 1.0.18rc3 Library version: 1.0.18rc3 Utilities version: 1.0.18rc3
!!Loaded ALSA modules !!-------------------
!!Soundcards recognised by ALSA !!-----------------------------
0 [Intel ]: HDA-Intel - HDA Intel HDA Intel at 0xefffc000 irq 314
!!PCI Soundcards installed in the system !!--------------------------------------
00:1b.0 Audio device: Intel Corporation 82801G (ICH7 Family) High Definition Audio Controller (rev 01)
!!Advanced information - PCI Vendor/Device/Susbsystem ID's !!--------------------------------------------------------
00:1b.0 0403: 8086:27d8 (rev 01) Subsystem: 1028:01cc
!!Modprobe options (Sound related) !!--------------------------------
snd-card-0: index=0 snd-hda-intel: index=0 enable_msi=1 power_save=5
!!Loaded sound module options !!--------------------------
!!HDA-Intel Codec information !!--------------------------- --startcollapse--
Codec: SigmaTel STAC9200 Address: 0 Vendor Id: 0x83847690 Subsystem Id: 0x102801cc Revision Id: 0x102201 No Modem Function Group found Default PCM: rates [0x7e0]: 44100 48000 88200 96000 176400 192000 bits [0xe]: 16 20 24 formats [0x1]: PCM Default Amp-In caps: N/A Default Amp-Out caps: ofs=0x1f, nsteps=0x1f, stepsize=0x05, mute=1 GPIO: io=4, o=0, i=0, unsolicited=1, wake=1 IO[0]: enable=0, dir=0, wake=0, sticky=0, data=0 IO[1]: enable=0, dir=0, wake=0, sticky=0, data=0 IO[2]: enable=0, dir=0, wake=0, sticky=0, data=0 IO[3]: enable=0, dir=0, wake=0, sticky=0, data=0 Node 0x02 [Audio Output] wcaps 0xd0401: Stereo Converter: stream=0, channel=0 Power: setting=D0, actual=D0 Delay: 13 samples Node 0x03 [Audio Input] wcaps 0x1d0541: Stereo Converter: stream=0, channel=0 SDI-Select: 0 Power: setting=D0, actual=D0 Delay: 13 samples Connection: 1 0x0a Processing caps: benign=0, ncoeff=0 Node 0x04 [Audio Input] wcaps 0x140311: Stereo Digital Converter: stream=0, channel=0 SDI-Select: 0 Digital: Digital category: 0x0 PCM: rates [0x160]: 44100 48000 96000 bits [0xe]: 16 20 24 formats [0x5]: PCM AC3 Delay: 4 samples Connection: 1 0x08 Node 0x05 [Audio Output] wcaps 0x40211: Stereo Digital Converter: stream=0, channel=0 Digital: Digital category: 0x0 PCM: rates [0x1e0]: 44100 48000 88200 96000 bits [0xe]: 16 20 24 formats [0x5]: PCM AC3 Delay: 4 samples Node 0x06 [Vendor Defined Widget] wcaps 0xf30201: Stereo Digital Delay: 3 samples Node 0x07 [Audio Selector] wcaps 0x300901: Stereo R/L Connection: 3 0x02* 0x08 0x0a Node 0x08 [Pin Complex] wcaps 0x430681: Stereo Digital Pincap 0x00010024: IN EAPD Detect EAPD 0x0: Pin Default 0x40c003fa: [N/A] SPDIF In at Ext N/A Conn = Unknown, Color = Unknown DefAssociation = 0xf, Sequence = 0xa Misc = NO_PRESENCE Pin-ctls: 0x00: Unsolicited: tag=00, enabled=0 Power: setting=D0, actual=D0 Delay: 3 samples Node 0x09 [Pin Complex] wcaps 0x400301: Stereo Digital Pincap 0x00000010: OUT Pin Default 0x0144131f: [Jack] SPDIF Out at Ext Rear Conn = RCA, Color = Black DefAssociation = 0x1, Sequence = 0xf Misc = NO_PRESENCE Pin-ctls: 0x40: OUT Connection: 2 0x05* 0x0a Node 0x0a [Audio Selector] wcaps 0x30090d: Stereo Amp-Out R/L Amp-Out caps: ofs=0x00, nsteps=0x0f, stepsize=0x05, mute=1 Amp-Out vals: [0x0d 0x0d] Connection: 1 0x0c Node 0x0b [Audio Selector] wcaps 0x300105: Stereo Amp-Out Amp-Out caps: N/A Amp-Out vals: [0x80 0x80] Connection: 1 0x07 Node 0x0c [Audio Selector] wcaps 0x30010d: Stereo Amp-Out Amp-Out caps: ofs=0x00, nsteps=0x04, stepsize=0x27, mute=0 Amp-Out vals: [0x00 0x00] Connection: 5 0x10 0x0f* 0x0e 0x0d 0x12 Node 0x0d [Pin Complex] wcaps 0x400181: Stereo Pincap 0x0000003f: IN OUT HP Detect Trigger ImpSense Pin Default 0x0321121f: [Jack] HP Out at Ext Left Conn = 1/8, Color = Black DefAssociation = 0x1, Sequence = 0xf Pin-ctls: 0xc0: OUT HP Unsolicited: tag=30, enabled=1 Connection: 1 0x0b Node 0x0e [Pin Complex] wcaps 0x400181: Stereo Pincap 0x0000003f: IN OUT HP Detect Trigger ImpSense Pin Default 0x90170310: [Fixed] Speaker at Int N/A Conn = Analog, Color = Unknown DefAssociation = 0x1, Sequence = 0x0 Misc = NO_PRESENCE Pin-ctls: 0x40: OUT Unsolicited: tag=00, enabled=0 Connection: 1 0x0b Node 0x0f [Pin Complex] wcaps 0x400181: Stereo Pincap 0x00000037: IN OUT Detect Trigger ImpSense Pin Default 0x90a70321: [Fixed] Mic at Int N/A Conn = Analog, Color = Unknown DefAssociation = 0x2, Sequence = 0x1 Misc = NO_PRESENCE Pin-ctls: 0x20: IN Unsolicited: tag=00, enabled=0 Connection: 1 0x0b Node 0x10 [Pin Complex] wcaps 0x400181: Stereo Pincap 0x00001737: IN OUT Detect Trigger ImpSense Vref caps: HIZ 50 GRD 80 Pin Default 0x03a11020: [Jack] Mic at Ext Left Conn = 1/8, Color = Black DefAssociation = 0x2, Sequence = 0x0 Pin-ctls: 0x20: IN VREF_HIZ Unsolicited: tag=00, enabled=0 Connection: 1 0x0b Node 0x11 [Pin Complex] wcaps 0x400104: Mono Amp-Out Amp-Out caps: N/A Amp-Out vals: [0x00] Pincap 0x00000010: OUT Pin Default 0x401003fb: [N/A] Speaker at Ext N/A Conn = Unknown, Color = Unknown DefAssociation = 0xf, Sequence = 0xb Misc = NO_PRESENCE Pin-ctls: 0x00: Connection: 1 0x13 Node 0x12 [Pin Complex] wcaps 0x400001: Stereo Pincap 0x00000020: IN Pin Default 0x40f000fc: [N/A] Other at Ext N/A Conn = Unknown, Color = Unknown DefAssociation = 0xf, Sequence = 0xc Pin-ctls: 0x20: IN Node 0x13 [Audio Mixer] wcaps 0x200100: Mono Connection: 1 0x07 Node 0x14 [Beep Generator Widget] wcaps 0x70000c: Mono Amp-Out Amp-Out caps: ofs=0x03, nsteps=0x03, stepsize=0x17, mute=1 Amp-Out vals: [0x00] Codec: Conexant ID 2bfa Address: 1 Vendor Id: 0x14f12bfa Subsystem Id: 0x14f100c3 Revision Id: 0x90000 Modem Function Group: 0x2 --endcollapse--
!!ALSA Device nodes !!-----------------
crw-rw----+ 1 valdis root 116, 7 2008-11-10 14:14 /dev/snd/controlC0 crw-rw----+ 1 valdis root 116, 6 2008-11-10 14:16 /dev/snd/pcmC0D0c crw-rw----+ 1 valdis root 116, 5 2008-11-10 14:16 /dev/snd/pcmC0D0p crw-rw----+ 1 valdis root 116, 4 2008-11-10 14:14 /dev/snd/pcmC0D1p crw-rw----+ 1 valdis root 116, 3 2008-11-10 14:14 /dev/snd/seq crw-rw----+ 1 valdis root 116, 2 2008-11-10 14:14 /dev/snd/timer
!!ALSA configuration files !!------------------------
!!User specific config file (~/.asoundrc)
pcm.!default { type pulse }
ctl.!default { type pulse }
!!System wide config file (/etc/asound.conf)
# # Place your global alsa-lib configuration here... #
@hooks [ { func load files [ "/etc/alsa/pulse-default.conf" ] errors false } ]
!!Aplay/Arecord output !!------------
APLAY
**** List of PLAYBACK Hardware Devices **** card 0: Intel [HDA Intel], device 0: STAC92xx Analog [STAC92xx Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: Intel [HDA Intel], device 1: STAC92xx Digital [STAC92xx Digital] Subdevices: 1/1 Subdevice #0: subdevice #0
ARECORD
**** List of CAPTURE Hardware Devices **** card 0: Intel [HDA Intel], device 0: STAC92xx Analog [STAC92xx Analog] Subdevices: 1/1 Subdevice #0: subdevice #0
!!Amixer output !!-------------
!!-------Mixer controls for card 0 [Intel]
Card hw:0 'Intel'/'HDA Intel at 0xefffc000 irq 314' Mixer name : 'SigmaTel STAC9200' Components : 'HDA:83847690,102801cc,00102201 HDA:14f12bfa,14f100c3,00090000' Controls : 10 Simple ctrls : 5 Simple mixer control 'Master',0 Capabilities: pvolume pswitch Playback channels: Front Left - Front Right Limits: Playback 0 - 31 Mono: Front Left: Playback 0 [0%] [-46.50dB] [off] Front Right: Playback 0 [0%] [-46.50dB] [off] Simple mixer control 'IEC958',0 Capabilities: pswitch pswitch-joined Playback channels: Mono Mono: Playback [off] Simple mixer control 'IEC958 Default PCM',0 Capabilities: pswitch pswitch-joined Playback channels: Mono Mono: Playback [on] Simple mixer control 'Capture',0 Capabilities: cvolume cswitch Capture channels: Front Left - Front Right Limits: Capture 0 - 15 Front Left: Capture 13 [87%] [19.50dB] [on] Front Right: Capture 13 [87%] [19.50dB] [on] Simple mixer control 'Input Source',0 Capabilities: cenum Items: 'Mic' 'Front Mic' Item0: 'Mic'
!!Alsactl output !!-------------
--startcollapse-- state.Intel { control.1 { comment.access 'read write' comment.type INTEGER comment.count 2 comment.range '0 - 31' comment.dbmin -4650 comment.dbmax 0 iface MIXER name 'Master Playback Volume' value.0 0 value.1 0 } control.2 { comment.access 'read write' comment.type BOOLEAN comment.count 2 iface MIXER name 'Master Playback Switch' value.0 false value.1 false } control.3 { comment.access 'read write' comment.type ENUMERATED comment.count 1 comment.item.0 Mic comment.item.1 'Front Mic' iface MIXER name 'Input Source' value Mic } control.4 { comment.access 'read write' comment.type INTEGER comment.count 2 comment.range '0 - 15' comment.dbmin 0 comment.dbmax 2250 iface MIXER name 'Capture Volume' value.0 13 value.1 13 } control.5 { comment.access 'read write' comment.type BOOLEAN comment.count 2 iface MIXER name 'Capture Switch' value.0 true value.1 true } control.6 { comment.access read comment.type IEC958 comment.count 1 iface MIXER name 'IEC958 Playback Con Mask' value '0fff000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000' } control.7 { comment.access read comment.type IEC958 comment.count 1 iface MIXER name 'IEC958 Playback Pro Mask' value '0f00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000' } control.8 { comment.access 'read write' comment.type IEC958 comment.count 1 iface MIXER name 'IEC958 Playback Default' value '0400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000' } control.9 { comment.access 'read write' comment.type BOOLEAN comment.count 1 iface MIXER name 'IEC958 Playback Switch' value false } control.10 { comment.access 'read write' comment.type BOOLEAN comment.count 1 iface MIXER name 'IEC958 Default PCM Playback Switch' value true } } --endcollapse--
!!All Loaded Modules !!------------------
Module irnet ppp_generic slhc irtty_sir sir_dev ircomm_tty ircomm irda crc_ccitt coretemp nf_conntrack_ftp xt_pkttype ipt_REJECT nf_conntrack_ipv4 nf_defrag_ipv4 xt_ipisforif xt_recent ipt_LOG xt_u32 iptable_filter ip_tables xt_tcpudp nf_conntrack_ipv6 xt_state nf_conntrack ip6t_LOG xt_limit ip6table_filter ip6_tables x_tables sha256_generic aes_x86_64 aes_generic rtc acpi_cpufreq tpm_tis tpm tpm_bios gspca_spca561 gspca_main compat_ioctl32 videodev arc4 ecb v4l1_compat nvidia pcmcia iwl3945 rfkill mac80211 ohci1394 snd_hda_intel ieee1394 yenta_socket rsrc_nonstatic pcmcia_core video led_class uhci_hcd output iTCO_wdt cfg80211 iTCO_vendor_support thermal intel_agp processor battery button dcdbas ac
[2 <application/pgp-signature (7bit)>]
At Tue, 11 Nov 2008 08:47:54 +0100, I wrote:
At Mon, 10 Nov 2008 14:35:58 -0500, Valdis.Kletnieks@vt.edu wrote:
Sometime between -mmotm1017 and -rc2-mm1, something odd happened to the sound subsystem. On my Dell Latitude D820, audio works OK if it's sitting there standalone, or in its docking station.
However, when I plug in headphones, it goes silent.
To confirm a regression, could you copy sound/pci/hda/patch_sigmatel.c from 2.6.27 kernel and check the driver works? Does the same problem exist in 2.6.28-rc kernel?
Could you try the patch below?
There is another patch for a missing capture mux control, but in your case, it doesn't matter because you didn't change the value. I'll post that patch later, too.
thanks,
Takashi
=== From 4f1e6bc3646ab50b8181555ab7e6eeab68b8632a Mon Sep 17 00:00:00 2001 From: Takashi Iwai tiwai@suse.de Date: Tue, 11 Nov 2008 16:47:24 +0100 Subject: [PATCH] ALSA: hda - Fix input pin initialization for STAC/IDT codecs
The input pins are sometimes not initialized properly because of the optimization check of the current pinctl code.
Force to initialize the mic input pins so that they can be set up properly even if they were in a weird state. But keep other input pins if already set up as input, since this could be an extra mic pin.
Reference: Novell bnc#443738 https://bugzilla.novell.com/show_bug.cgi?id=443738
Signed-off-by: Takashi Iwai tiwai@suse.de --- sound/pci/hda/patch_sigmatel.c | 20 ++++++++++++-------- 1 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 1627756..a511601 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -3653,14 +3653,18 @@ static int stac92xx_init(struct hda_codec *codec) for (i = 0; i < AUTO_PIN_LAST; i++) { hda_nid_t nid = cfg->input_pins[i]; if (nid) { - unsigned int pinctl = snd_hda_codec_read(codec, nid, - 0, AC_VERB_GET_PIN_WIDGET_CONTROL, 0); - /* if PINCTL already set then skip */ - if (pinctl & AC_PINCAP_IN) - continue; - pinctl = AC_PINCTL_IN_EN; - if (i == AUTO_PIN_MIC || i == AUTO_PIN_FRONT_MIC) - pinctl |= stac92xx_get_vref(codec, nid); + unsigned int pinctl; + if (i == AUTO_PIN_MIC || i == AUTO_PIN_FRONT_MIC) { + /* for mic pins, force to initialize */ + pinctl = stac92xx_get_vref(codec, nid); + } else { + pinctl = snd_hda_codec_read(codec, nid, 0, + AC_VERB_GET_PIN_WIDGET_CONTROL, 0); + /* if PINCTL already set then skip */ + if (pinctl & AC_PINCTL_IN_EN) + continue; + } + pinctl |= AC_PINCTL_IN_EN; stac92xx_auto_set_pinctl(codec, nid, pinctl); } }
At Tue, 11 Nov 2008 18:03:22 +0100, I wrote:
At Tue, 11 Nov 2008 08:47:54 +0100, I wrote:
At Mon, 10 Nov 2008 14:35:58 -0500, Valdis.Kletnieks@vt.edu wrote:
Sometime between -mmotm1017 and -rc2-mm1, something odd happened to the sound subsystem. On my Dell Latitude D820, audio works OK if it's sitting there standalone, or in its docking station.
However, when I plug in headphones, it goes silent.
To confirm a regression, could you copy sound/pci/hda/patch_sigmatel.c from 2.6.27 kernel and check the driver works? Does the same problem exist in 2.6.28-rc kernel?
Could you try the patch below?
There is another patch for a missing capture mux control, but in your case, it doesn't matter because you didn't change the value. I'll post that patch later, too.
Here is another fix.
Takashi
=== From 355a0ec471377a8a907b79c8fba3f0f09b44656e Mon Sep 17 00:00:00 2001 From: Takashi Iwai tiwai@suse.de Date: Tue, 11 Nov 2008 16:46:19 +0100 Subject: [PATCH] ALSA: hda - Add missing analog-mux mixer creation for STAC9200
The creation of analog-mux mixer element is missing in patch_stac9200() due to the dynamic allocation patch.
Signed-off-by: Takashi Iwai tiwai@suse.de --- sound/pci/hda/patch_sigmatel.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index e608591..1627756 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -3530,6 +3530,12 @@ static int stac9200_parse_auto_config(struct hda_codec *codec) if ((err = stac9200_auto_create_lfe_ctls(codec, &spec->autocfg)) < 0) return err;
+ if (spec->num_muxes > 0) { + err = stac92xx_auto_create_mux_input_ctls(codec); + if (err < 0) + return err; + } + if (spec->autocfg.dig_out_pin) spec->multiout.dig_out_nid = 0x05; if (spec->autocfg.dig_in_pin)
On Tue, 11 Nov 2008 18:04:56 +0100, Takashi Iwai said:
Could you try the patch below?
There is another patch for a missing capture mux control, but in your case, it doesn't matter because you didn't change the value. I'll post that patch later, too.
Here is another fix.
Thanks for the fast reply for admittedly not-major problem. I'll give these patches a try tonight and report back tomorrow how things went...
On Tue, 11 Nov 2008 18:04:56 +0100, Takashi Iwai said:
Following up...
To confirm a regression, could you copy sound/pci/hda/patch_sigmatel.c from 2.6.27 kernel and check the driver works? Does the same problem exist in 2.6.28-rc kernel?
Yes, it was a regression - using the older patch_sigmatel.c in the -rc4-mm kernel worked fine.
Could you try the patch below?
There is another patch for a missing capture mux control, but in your case, it doesn't matter because you didn't change the value. I'll post that patch later, too.
Here is another fix.
Subject: [PATCH] ALSA: hda - Add missing analog-mux mixer creation for STAC9200
Running with a current patch_sigmatel.c plus the two patches also works fine, so feel free to stick a Tested-By: on it if you wish...
Thanks for the speedy patches..
At Wed, 12 Nov 2008 16:09:37 -0500, Valdis.Kletnieks@vt.edu wrote:
On Tue, 11 Nov 2008 18:04:56 +0100, Takashi Iwai said:
Following up...
To confirm a regression, could you copy sound/pci/hda/patch_sigmatel.c from 2.6.27 kernel and check the driver works? Does the same problem exist in 2.6.28-rc kernel?
Yes, it was a regression - using the older patch_sigmatel.c in the -rc4-mm kernel worked fine.
Could you try the patch below?
There is another patch for a missing capture mux control, but in your case, it doesn't matter because you didn't change the value. I'll post that patch later, too.
Here is another fix.
Subject: [PATCH] ALSA: hda - Add missing analog-mux mixer creation for STAC9200
Running with a current patch_sigmatel.c plus the two patches also works fine, so feel free to stick a Tested-By: on it if you wish...
Thanks for checking.
FYI, the patches have been already merged to Linus tree yesterday, as I could confirm with other test cases.
Takashi
participants (2)
-
Takashi Iwai -
Valdis.Kletnieks＠vt.edu