[alsa-devel] [patch] Fix bug with bt87x driver's load_all option
snd-bt87x: Make the load_all option work correctly
If the load_all option was turned on all cards would be treated as unknown, even those which are in the database. Of course, if the card is in the database there is no reason to use the load_all option. It's there to force loading when the card isn't in the database. But there are out of date wikis that say to do this and some distros might turn this option on by default.
So, we keep the load_all option from turning known cards into unknown cards.
Signed-off-by: Trent Piepho xyzzy@speakeasy.org
diff --git a/pci/bt87x.c b/pci/bt87x.c --- a/pci/bt87x.c +++ b/pci/bt87x.c @@ -1021,7 +1021,7 @@ static int __devinit snd_bt87x_detect_ca int i; const struct pci_device_id *supported;
- supported = pci_match_device(&driver, pci); + supported = pci_match_id(snd_bt87x_ids, pci); if (supported && supported->driver_data > 0) return supported->driver_data;
At Wed, 17 Oct 2007 15:55:54 -0700 (PDT), Trent Piepho wrote:
snd-bt87x: Make the load_all option work correctly
If the load_all option was turned on all cards would be treated as unknown, even those which are in the database. Of course, if the card is in the database there is no reason to use the load_all option. It's there to force loading when the card isn't in the database. But there are out of date wikis that say to do this and some distros might turn this option on by default.
So, we keep the load_all option from turning known cards into unknown cards.
Signed-off-by: Trent Piepho xyzzy@speakeasy.org
Thanks, applied to HG tree now.
Takashi
participants (2)
-
Takashi Iwai
-
Trent Piepho