[alsa-devel] [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
From: Libin Yang libin.yang@intel.com
Add HD Audio Device PCI ID for the Intel Braswell platform.
Signed-off-by: Libin Yang libin.yang@intel.com --- sound/pci/hda/hda_intel.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 387fc73..5db1948 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = { /* BayTrail */ { PCI_DEVICE(0x8086, 0x0f04), .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM }, + /* Braswell */ + { PCI_DEVICE(0x8086, 0x2284), + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH }, /* ICH */ { PCI_DEVICE(0x8086, 0x2668), .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
From: Libin Yang libin.yang@intel.com
This patch adds codec ID (0x80862883) and module alias for Braswell display codec.
Signed-off-by: Libin Yang libin.yang@intel.com --- sound/pci/hda/patch_hdmi.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index a21090b..36badba 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -3356,6 +3356,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = { { .id = 0x80862808, .name = "Broadwell HDMI", .patch = patch_generic_hdmi }, { .id = 0x80862880, .name = "CedarTrail HDMI", .patch = patch_generic_hdmi }, { .id = 0x80862882, .name = "Valleyview2 HDMI", .patch = patch_generic_hdmi }, +{ .id = 0x80862883, .name = "Braswell HDMI", .patch = patch_generic_hdmi }, { .id = 0x808629fb, .name = "Crestline HDMI", .patch = patch_generic_hdmi }, {} /* terminator */ }; @@ -3415,6 +3416,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862807"); MODULE_ALIAS("snd-hda-codec-id:80862808"); MODULE_ALIAS("snd-hda-codec-id:80862880"); MODULE_ALIAS("snd-hda-codec-id:80862882"); +MODULE_ALIAS("snd-hda-codec-id:80862883"); MODULE_ALIAS("snd-hda-codec-id:808629fb");
MODULE_LICENSE("GPL");
At Fri, 25 Jul 2014 16:19:15 +0800, libin.yang@intel.com wrote:
From: Libin Yang libin.yang@intel.com
Add HD Audio Device PCI ID for the Intel Braswell platform.
So, you confirmed that runtime PM works? Also, the device doesn't need the buffer size alignment unlike Haswell & co? If these were already confirmed, describe in the patch description (also mention that it's an HDMI controller).
Takashi
Signed-off-by: Libin Yang libin.yang@intel.com
sound/pci/hda/hda_intel.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 387fc73..5db1948 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = { /* BayTrail */ { PCI_DEVICE(0x8086, 0x0f04), .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
- /* Braswell */
- { PCI_DEVICE(0x8086, 0x2284),
.driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },-- 1.9.1
Hi Takashi,
Please see my comments below
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Friday, July 25, 2014 4:31 PM To: Yang, Libin Cc: alsa-devel@alsa-project.org; Lin, Mengdong Subject: Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
At Fri, 25 Jul 2014 16:19:15 +0800, libin.yang@intel.com wrote:
From: Libin Yang libin.yang@intel.com
Add HD Audio Device PCI ID for the Intel Braswell platform.
So, you confirmed that runtime PM works? Also, the device doesn't need the buffer size alignment unlike Haswell & co? If these were already confirmed, describe in the patch description (also mention that it's an HDMI controller).
Yes, I have tested the runtime PM, and it works. Besides, I think you are right, if the HDMI codec doesn't support, we should leave it to codec to decide not to use the runtime PM.
For the buffer size alignment, I will confirm with our HW team. Thanks for reminding me.
I will add the comments in the patch description.
BTW: this is not a HDMI audio controller. The HDMI codec and analog codec will both connect to the controller. It's not embedded into the HDMI controller.
Takashi
Signed-off-by: Libin Yang libin.yang@intel.com
sound/pci/hda/hda_intel.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 387fc73..5db1948 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = { /* BayTrail */ { PCI_DEVICE(0x8086, 0x0f04), .driver_data = AZX_DRIVER_PCH |
AZX_DCAPS_INTEL_PCH_NOPM },
- /* Braswell */
- { PCI_DEVICE(0x8086, 0x2284),
.driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },-- 1.9.1
participants (3)
-
libin.yang＠intel.com -
Takashi Iwai -
Yang, Libin