Re: [PATCH 4/4] ASoC: wm8904: add DMIC support
Via firmware description.
Can you please provide any reference approach in the kernel code ?
git grep of_ git grep fwnode_
and I don't immediately remember what the prefix is for ACPI functions.
Just for my understanding, are you suggesting to set a device tree property to force a fixed behavior in the driver ? WM8904 allows using both a DMIC and LINEIN, switching between one or the other and this is how we currently use it. Why the user should not be allowed to switch between DMIC and LINEIN ?
On Mon, Jun 20, 2022 at 03:30:45PM +0000, Pierluigi Passaro wrote:
Just for my understanding, are you suggesting to set a device tree property to force a fixed behavior in the driver ?
Yes.
WM8904 allows using both a DMIC and LINEIN, switching between one or the other and this is how we currently use it. Why the user should not be allowed to switch between DMIC and LINEIN ?
The device shares pins between the line inputs and the DMIC inputs so at least some of the configuration is going to be determinted at system design time, that will fix the usable values of at least one of the controls which ought to be reflected in the runtime behaviour.
Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to.
participants (2)
-
Mark Brown -
Pierluigi Passaro