[PATCH] ASoC: max98088: make it selectable
There is no way to select max98088 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone.
Signed-off-by: Maxim Kochetkov fido_max@inbox.ru --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 79d2362ad055..8020097d4e4c 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1090,7 +1090,7 @@ config SND_SOC_MAX98088 depends on I2C
config SND_SOC_MAX98090 - tristate + tristate "Maxim MAX98090 CODEC" depends on I2C
config SND_SOC_MAX98095
On 21/04/2023 22:01, Maxim Kochetkov wrote:
There is no way to select max98088 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone.
Just like many other codecs used in embedded designs. Why exactly this one should be user selectable, but others not?
Best regards, Krzysztof
On Fri, Apr 21, 2023 at 10:41:00PM +0200, Krzysztof Kozlowski wrote:
On 21/04/2023 22:01, Maxim Kochetkov wrote:
There is no way to select max98088 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone.
Just like many other codecs used in embedded designs. Why exactly this one should be user selectable, but others not?
Not all drivers are capable of interoperating with the generic cards, some require things like specifically programmed clocking setup.
On 21/04/2023 22:43, Mark Brown wrote:
On Fri, Apr 21, 2023 at 10:41:00PM +0200, Krzysztof Kozlowski wrote:
On 21/04/2023 22:01, Maxim Kochetkov wrote:
There is no way to select max98088 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone.
Just like many other codecs used in embedded designs. Why exactly this one should be user selectable, but others not?
Not all drivers are capable of interoperating with the generic cards, some require things like specifically programmed clocking setup.
This one so far is not used in any generic card, so I wonder...
Best regards, Krzysztof
On 21/04/2023 22:54, Krzysztof Kozlowski wrote:
On 21/04/2023 22:43, Mark Brown wrote:
On Fri, Apr 21, 2023 at 10:41:00PM +0200, Krzysztof Kozlowski wrote:
On 21/04/2023 22:01, Maxim Kochetkov wrote:
There is no way to select max98088 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone.
Just like many other codecs used in embedded designs. Why exactly this one should be user selectable, but others not?
Not all drivers are capable of interoperating with the generic cards, some require things like specifically programmed clocking setup.
This one so far is not used in any generic card, so I wonder...
I found one generic user - at least one board (Odroid XU) uses it with generic simple audio card, so probably this makes sense.
Best regards, Krzysztof
On Fri, Apr 21, 2023 at 10:57:31PM +0200, Krzysztof Kozlowski wrote:
On 21/04/2023 22:54, Krzysztof Kozlowski wrote:
This one so far is not used in any generic card, so I wonder...
I found one generic user - at least one board (Odroid XU) uses it with generic simple audio card, so probably this makes sense.
One can also imagine that someone who was contemplating building a board might upstream before the board was available as part of enablement. Since the audio signals tend to be brought out to expansion connectors you also often see the CODECs added on plugin modules, this would generally mean an overlay which isn't something that's upstreamable at the minute, things like the HiFiBerry boards for example.
On 21.04.2023 23:41, Krzysztof Kozlowski wrote:
On 21/04/2023 22:01, Maxim Kochetkov wrote:
There is no way to select max98088 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone.
Just like many other codecs used in embedded designs. Why exactly this one should be user selectable, but others not?
I can tell nothing about any other codecs. But this one has no external dependencies. I just need to enable it and assign DT node to bring it up. So we can let them be user selectable.
Best regards, Krzysztof
On 21/04/2023 22:51, Maxim Kochetkov wrote:
On 21.04.2023 23:41, Krzysztof Kozlowski wrote:
On 21/04/2023 22:01, Maxim Kochetkov wrote:
There is no way to select max98088 from menuconfig right now. Add a Kconfig menu description to allow building the driver standalone.
Just like many other codecs used in embedded designs. Why exactly this one should be user selectable, but others not?
I can tell nothing about any other codecs. But this one has no external dependencies. I just need to enable it and assign DT node to bring it up. So we can let them be user selectable.
Why your sound-card cannot select it? IOW, what is so different in your design from existing upstream sound cards and choices? Commit should answer to "why" you are doing it and in current Linux sources I do not see the need for it to be user-selectable. Commit msg does not explain it either.
Best regards, Krzysztof
participants (3)
-
Krzysztof Kozlowski -
Mark Brown -
Maxim Kochetkov