[alsa-devel] [PATCH] sound: pci: es1968: use pci_device_id
Uses the struct pci_device_id instead of the depreciated macro DEFINE_PCI_DEVICE_TABLE.
Signed-off-by: Sudip Mukherjee sudip@vectorindia.org --- sound/pci/es1968.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/es1968.c b/sound/pci/es1968.c index 5bb1cf6..a9956a7 100644 --- a/sound/pci/es1968.c +++ b/sound/pci/es1968.c @@ -570,7 +570,7 @@ struct es1968 {
static irqreturn_t snd_es1968_interrupt(int irq, void *dev_id);
-static DEFINE_PCI_DEVICE_TABLE(snd_es1968_ids) = { +static const struct pci_device_id snd_es1968_ids[] = { /* Maestro 1 */ { 0x1285, 0x0100, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_MULTIMEDIA_AUDIO << 8, 0xffff00, TYPE_MAESTRO }, /* Maestro 2 */
On Tue, Aug 12, 2014 at 5:56 PM, Takashi Iwai tiwai@suse.de wrote:
At Tue, 12 Aug 2014 17:45:40 +0530, Sudip Mukherjee wrote:
Uses the struct pci_device_id instead of the depreciated macro DEFINE_PCI_DEVICE_TABLE.
If we do this, better to apply to all sound/pci/* at once after 3.17-rc1 is released.
thanks,
Takashi
If we apply to all sound.pci/* , then it will be 69 replacements in one go. If you all want that way , then will do it after 3.17-rc1 is releases .
Thanks Sudip
At Tue, 12 Aug 2014 18:11:19 +0530, Sudip Mukherjee wrote:
On Tue, Aug 12, 2014 at 5:56 PM, Takashi Iwai tiwai@suse.de wrote:
At Tue, 12 Aug 2014 17:45:40 +0530, Sudip Mukherjee wrote:
Uses the struct pci_device_id instead of the depreciated macro DEFINE_PCI_DEVICE_TABLE.
If we do this, better to apply to all sound/pci/* at once after 3.17-rc1 is released.
thanks,
Takashi
If we apply to all sound.pci/* , then it will be 69 replacements in one go. If you all want that way , then will do it after 3.17-rc1 is releases .
Yes, that's what I suggested :) It's a pretty dumb systematic replacement, so can be done via scripting.
thanks,
Takashi
participants (2)
-
Sudip Mukherjee -
Takashi Iwai