[alsa-devel] [PATCH] Support for Roland SonicCell sound module
I'm not sure if this is the right place for it, but I've added support for the Roland SonicCell sound module. Patches were made against alsa-driver-1.0.16 source. Please let me know if there's a better place to post this:
--- usbquirks.h 2008-02-05 04:23:24.000000000 -0500 +++ usbquirks.h 2008-05-18 13:02:32.000000000 -0400 @@ -1367,6 +1367,39 @@ } },
+{ + /* Roland SonicCell */ + USB_DEVICE(0x0582, 0x00c2), + .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { + .vendor_name = "Roland", + .product_name = "SonicCell", + .ifnum = QUIRK_ANY_INTERFACE, + .type = QUIRK_COMPOSITE, + .data = (const struct snd_usb_audio_quirk[]) { + { + .ifnum = 0, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 1, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 2, + .type = QUIRK_MIDI_FIXED_ENDPOINT, + .data = & (const struct snd_usb_midi_endpoint_info) { + .out_cables = 0x0001, + .in_cables = 0x0001 + } + }, + { + .ifnum = -1 + } + } + } +}, + + /* Guillemot devices */ { /*
At Sun, 18 May 2008 13:22:11 -0400, Chris Mennie wrote:
I'm not sure if this is the right place for it, but I've added support for the Roland SonicCell sound module. Patches were made against alsa-driver-1.0.16 source. Please let me know if there's a better place to post this:
The patch looks fine. Could you give your sign-off for merging to the upstream together with a changelog?
Thanks,
Takashi
--- usbquirks.h 2008-02-05 04:23:24.000000000 -0500 +++ usbquirks.h 2008-05-18 13:02:32.000000000 -0400 @@ -1367,6 +1367,39 @@ } },
+{
- /* Roland SonicCell */
- USB_DEVICE(0x0582, 0x00c2),
- .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
.vendor_name = "Roland",.product_name = "SonicCell",.ifnum = QUIRK_ANY_INTERFACE,.type = QUIRK_COMPOSITE,.data = (const struct snd_usb_audio_quirk[]) {{.ifnum = 0,.type = QUIRK_AUDIO_STANDARD_INTERFACE},{.ifnum = 1,.type = QUIRK_AUDIO_STANDARD_INTERFACE},{.ifnum = 2,.type = QUIRK_MIDI_FIXED_ENDPOINT,.data = & (const struct snd_usb_midi_endpoint_info) {.out_cables = 0x0001,.in_cables = 0x0001}},{.ifnum = -1}}- }
+},
/* Guillemot devices */ { /* _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
On Monday 19 May 2008 6:30:00 am Takashi Iwai wrote:
Chris Mennie wrote:
I'm not sure if this is the right place for it, but I've added support for the Roland SonicCell sound module. Patches were made against alsa-driver-1.0.16 source. Please let me know if there's a better place to post this:
The patch looks fine. Could you give your sign-off for merging to the upstream together with a changelog?
I'm certainly happy with donating the code (if that's what you're asking?) :). As for a changelog entry, I suggest:
usb-audio: Added support for Roland SonicCell
At Mon, 19 May 2008 09:11:36 -0400, Chris Mennie wrote:
On Monday 19 May 2008 6:30:00 am Takashi Iwai wrote:
Chris Mennie wrote:
I'm not sure if this is the right place for it, but I've added support for the Roland SonicCell sound module. Patches were made against alsa-driver-1.0.16 source. Please let me know if there's a better place to post this:
The patch looks fine. Could you give your sign-off for merging to the upstream together with a changelog?
I'm certainly happy with donating the code (if that's what you're asking?) :). As for a changelog entry, I suggest:
usb-audio: Added support for Roland SonicCell
Well, usually the patch must be signed off by the author to be merged to the upstream for avoiding possible legal and other problems. See Documentation/SubmittingPatches in Linux kernel tree for details.
About the changelog, I prefer a bit more descrictive one.
Thanks,
Takashi
Well, usually the patch must be signed off by the author to be merged to the upstream for avoiding possible legal and other problems. See Documentation/SubmittingPatches in Linux kernel tree for details.
About the changelog, I prefer a bit more descrictive one.
Ok, how about this:
Added entry into usbquirks.h to recognize Roland SonicCell sound module by mostly duplicating the entry for the Roland SH-201. USB MIDI works just fine, though the USB audio is a little unreliable (but still works well enough).
Signed-off-by: Chris Mennie <camennie at alumni dot uwaterloo dot ca>
participants (2)
-
Chris Mennie -
Takashi Iwai