On Thu, 2020-05-07 at 14:48 +0800, Samuel Zou wrote:

Fix the following coccinelle warning:

sound/drivers/portman2x4.c:460:34-35: WARNING: sum of probable bitmasks, consider |

This one is reasonable.

Reported-by: Hulk Robot hulkci@huawei.com Signed-off-by: Samuel Zou zou_wei@huawei.com

---

sound/drivers/portman2x4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c index ecefa7c..38603cb 100644 --- a/sound/drivers/portman2x4.c +++ b/sound/drivers/portman2x4.c @@ -457,7 +457,7 @@ static int portman_probe(struct parport *p)

/* Set for RXDATA0 where no damage will be done. */ /* 5 */

• parport_write_control(p, RXDATA0 + STROBE); /* Write Strobe=1 to command reg. */

• parport_write_control(p, RXDATA0 | STROBE); /* Write Strobe=1 to command reg. */

  /* 6 */ if ((parport_read_status(p) & ESTB) != ESTB)