[PATCH] ASoC: amd: acp3x-rt5682-max9836: Configure jack as not detecting Line Out
The RT5682, RT1015 and RT1015p codecs used in this driver do not seem capable of distinguishing Line Out connections from Headphone, but the driver configures its jack object as if it can. Remove the wrong value from the jack creation call to avoid any confusion.
Signed-off-by: Alper Nebi Yasak alpernebiyasak@gmail.com --- Depends on [1] which applies onto of linux-next. Untested, see [2]: [1] https://lore.kernel.org/alsa-devel/20230802175737.263412-5-alpernebiyasak@gm... [2] https://lore.kernel.org/alsa-devel/3d6794c9-60d3-b8f3-99d2-afdc69593d9f@gmai...
sound/soc/amd/acp3x-rt5682-max9836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/acp3x-rt5682-max9836.c b/sound/soc/amd/acp3x-rt5682-max9836.c index 3bf7e1e83c36..28ad5f5b9a76 100644 --- a/sound/soc/amd/acp3x-rt5682-max9836.c +++ b/sound/soc/amd/acp3x-rt5682-max9836.c @@ -98,7 +98,7 @@ static int acp3x_5682_init(struct snd_soc_pcm_runtime *rtd) rt5682_dai_bclk = clk_get(component->dev, "rt5682-dai-bclk");
ret = snd_soc_card_jack_new_pins(card, "Headset Jack", - SND_JACK_HEADSET | SND_JACK_LINEOUT | + SND_JACK_HEADSET | SND_JACK_BTN_0 | SND_JACK_BTN_1 | SND_JACK_BTN_2 | SND_JACK_BTN_3, &pco_jack,
base-commit: 626c67169f9972fffcdf3bc3864de421f162ebf5 prerequisite-patch-id: 7158530856f8f97324906b342528a5ffe7b4032b
On 2023/08/06 1:22, Alper Nebi Yasak wrote:
The RT5682, RT1015 and RT1015p codecs used in this driver do not seem capable of distinguishing Line Out connections from Headphone, but the driver configures its jack object as if it can. Remove the wrong value from the jack creation call to avoid any confusion.
Signed-off-by: Alper Nebi Yasak alpernebiyasak@gmail.com
Reviewed-by: Akihiko Odaki akihiko.odaki@daynix.com Tested-by: Akihiko Odaki akihiko.odaki@daynix.com
On 2023/08/06 1:22, Alper Nebi Yasak wrote:
The RT5682, RT1015 and RT1015p codecs used in this driver do not seem capable of distinguishing Line Out connections from Headphone, but the driver configures its jack object as if it can. Remove the wrong value from the jack creation call to avoid any confusion.
Signed-off-by: Alper Nebi Yasak alpernebiyasak@gmail.com
Reviewed-by: Akihiko Odaki akihiko.odaki@daynix.com Tested-by: Akihiko Odaki akihiko.odaki@daynix.com
On Sat, 05 Aug 2023 19:22:16 +0300, Alper Nebi Yasak wrote:
The RT5682, RT1015 and RT1015p codecs used in this driver do not seem capable of distinguishing Line Out connections from Headphone, but the driver configures its jack object as if it can. Remove the wrong value from the jack creation call to avoid any confusion.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: amd: acp3x-rt5682-max9836: Configure jack as not detecting Line Out commit: 94c40dbbffa11bec54b5ca74df1c5bb0f52995b9
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (4)
-
Akihiko Odaki -
Akihiko Odaki -
Alper Nebi Yasak -
Mark Brown