[PATCH] ALSA: hda/tas2781: annotate calibration data endianness
Sparse reports an endian mismatch. The amplifier expects the calibration data as big-endian. Use the __be32 type to express endianness better.
Reported-by: kernel test robot lkp@intel.com Closes: https://lore.kernel.org/oe-kbuild-all/202401072137.Oc7pQgRW-lkp@intel.com/
Signed-off-by: Gergo Koteles soyer@irl.hu --- sound/pci/hda/tas2781_hda_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c index 4805cf0b6480..2dd809de62e5 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -424,8 +424,8 @@ static const struct snd_kcontrol_new tas2781_dsp_conf_ctrl = {
static void tas2563_apply_calib(struct tasdevice_priv *tas_priv) { - unsigned int data; int offset = 0; + __be32 data; int ret;
for (int i = 0; i < tas_priv->ndev; i++) {
base-commit: 736c40609d31481b3b2fffe8c239f2c86fb2b54c
On Mon, 08 Jan 2024 22:16:46 +0100, Gergo Koteles wrote:
Sparse reports an endian mismatch. The amplifier expects the calibration data as big-endian. Use the __be32 type to express endianness better.
Reported-by: kernel test robot lkp@intel.com Closes: https://lore.kernel.org/oe-kbuild-all/202401072137.Oc7pQgRW-lkp@intel.com/
Signed-off-by: Gergo Koteles soyer@irl.hu
Thanks, applied with the additional Fixes tag to the commit.
Takashi
participants (2)
-
Gergo Koteles
-
Takashi Iwai