mainline build failure due to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
Hi All,
The latest mainline kernel branch fails to build alpha, csky and s390 allmodconfig with the error:
drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] 1138 | static int cs42l43_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function] 1124 | static int cs42l43_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function] 1106 | static int cs42l43_resume(struct device *dev) | ^~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function] 1076 | static int cs42l43_suspend(struct device *dev) | ^~~~~~~~~~~~~~~
git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
I will be happy to test any patch or provide any extra log if needed.
On Wed, 30 Aug 2023 13:29:57 +0200, Sudip Mukherjee (Codethink) wrote:
Hi All,
The latest mainline kernel branch fails to build alpha, csky and s390 allmodconfig with the error:
drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] 1138 | static int cs42l43_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function] 1124 | static int cs42l43_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function] 1106 | static int cs42l43_resume(struct device *dev) | ^~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function] 1076 | static int cs42l43_suspend(struct device *dev) | ^~~~~~~~~~~~~~~
git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
I will be happy to test any patch or provide any extra log if needed.
Adding __maybe_unused for those PM functions should work around it, something like below. Could you check it? If it's confirmed to work, I'll submit properly.
thanks,
Takashi
-- 8< -- From: Takashi Iwai tiwai@suse.de Subject: [PATCH] mfd: cs42l43: Fix unused function errors for PM callbacks
Add __maybe_unused prefix for suppressing the build errors due to defined-but-not-used PM callbacks.
Reported-by: Sudip Mukherjee (Codethink) sudipm.mukherjee@gmail.com Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver") Signed-off-by: Takashi Iwai tiwai@suse.de --- drivers/mfd/cs42l43.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 37b23e9bae82..e94b73e6869a 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -1073,7 +1073,7 @@ void cs42l43_dev_remove(struct cs42l43 *cs42l43) } EXPORT_SYMBOL_NS_GPL(cs42l43_dev_remove, MFD_CS42L43);
-static int cs42l43_suspend(struct device *dev) +static int __maybe_unused cs42l43_suspend(struct device *dev) { struct cs42l43 *cs42l43 = dev_get_drvdata(dev); int ret; @@ -1103,7 +1103,7 @@ static int cs42l43_suspend(struct device *dev) return 0; }
-static int cs42l43_resume(struct device *dev) +static int __maybe_unused cs42l43_resume(struct device *dev) { struct cs42l43 *cs42l43 = dev_get_drvdata(dev); int ret; @@ -1121,7 +1121,7 @@ static int cs42l43_resume(struct device *dev) return 0; }
-static int cs42l43_runtime_suspend(struct device *dev) +static int __maybe_unused cs42l43_runtime_suspend(struct device *dev) { struct cs42l43 *cs42l43 = dev_get_drvdata(dev);
@@ -1135,7 +1135,7 @@ static int cs42l43_runtime_suspend(struct device *dev) return 0; }
-static int cs42l43_runtime_resume(struct device *dev) +static int __maybe_unused cs42l43_runtime_resume(struct device *dev) { struct cs42l43 *cs42l43 = dev_get_drvdata(dev); unsigned int reset_canary;
On Wed, Aug 30, 2023 at 03:09:13PM +0200, Takashi Iwai wrote:
On Wed, 30 Aug 2023 13:29:57 +0200, Sudip Mukherjee (Codethink) wrote:
Hi All,
The latest mainline kernel branch fails to build alpha, csky and s390 allmodconfig with the error:
drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] 1138 | static int cs42l43_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function] 1124 | static int cs42l43_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function] 1106 | static int cs42l43_resume(struct device *dev) | ^~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function] 1076 | static int cs42l43_suspend(struct device *dev) | ^~~~~~~~~~~~~~~
git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
I will be happy to test any patch or provide any extra log if needed.
Adding __maybe_unused for those PM functions should work around it, something like below. Could you check it? If it's confirmed to work, I'll submit properly.
This is probably the correct fix:
https://lore.kernel.org/lkml/20230822114914.340359-1-ckeepax@opensource.cirr...
Just waiting on it to be reviewed.
Thanks, Charles
On Wed, 30 Aug 2023 17:00:37 +0200, Charles Keepax wrote:
On Wed, Aug 30, 2023 at 03:09:13PM +0200, Takashi Iwai wrote:
On Wed, 30 Aug 2023 13:29:57 +0200, Sudip Mukherjee (Codethink) wrote:
Hi All,
The latest mainline kernel branch fails to build alpha, csky and s390 allmodconfig with the error:
drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] 1138 | static int cs42l43_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function] 1124 | static int cs42l43_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function] 1106 | static int cs42l43_resume(struct device *dev) | ^~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function] 1076 | static int cs42l43_suspend(struct device *dev) | ^~~~~~~~~~~~~~~
git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
I will be happy to test any patch or provide any extra log if needed.
Adding __maybe_unused for those PM functions should work around it, something like below. Could you check it? If it's confirmed to work, I'll submit properly.
This is probably the correct fix:
https://lore.kernel.org/lkml/20230822114914.340359-1-ckeepax@opensource.cirr...
Just waiting on it to be reviewed.
Thanks, that looks better. Let's wait for the patch acceptance.
Takashi
On 30.08.23 13:29, Sudip Mukherjee (Codethink) wrote:
The latest mainline kernel branch fails to build alpha, csky and s390 allmodconfig with the error:
Thx for the report and involving regzbot.
FWIW, 0day bot noticed this earlier and Charles Keepax (now CCed) afaics even submitted a fix a bit more than a week ago, but that didn't get any further it seems: https://lore.kernel.org/all/202308212225.fGjY1rr6-lkp@intel.com/ https://lore.kernel.org/all/20230822114914.340359-1-ckeepax@opensource.cirru...
Ciao, Thorsten
drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] 1138 | static int cs42l43_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function] 1124 | static int cs42l43_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function] 1106 | static int cs42l43_resume(struct device *dev) | ^~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function] 1076 | static int cs42l43_suspend(struct device *dev) | ^~~~~~~~~~~~~~~
git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
I will be happy to test any patch or provide any extra log if needed.
P.S.:
#regzbot monitor: https://lore.kernel.org/all/20230822114914.340359-1-ckeepax@opensource.cirru... #regzbot monitor: https://lore.kernel.org/all/202308212225.fGjY1rr6-lkp@intel.com/ #regzbot fix: mfd: cs42l43: Use correct macro for new-style PM runtime ops
Hi All,
On Wed, 30 Aug 2023 at 12:29, Sudip Mukherjee (Codethink) sudipm.mukherjee@gmail.com wrote:
Hi All,
The latest mainline kernel branch fails to build alpha, csky and s390 allmodconfig with the error:
drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] 1138 | static int cs42l43_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function] 1124 | static int cs42l43_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function] 1106 | static int cs42l43_resume(struct device *dev) | ^~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function] 1076 | static int cs42l43_suspend(struct device *dev) | ^~~~~~~~~~~~~~~
git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
Since its almost time for v6.6-rc3, so just a quick reminder that this build failure is still not fixed.
On 23.09.23 17:02, Sudip Mukherjee wrote:
On Wed, 30 Aug 2023 at 12:29, Sudip Mukherjee (Codethink) sudipm.mukherjee@gmail.com wrote:
Hi All,
The latest mainline kernel branch fails to build alpha, csky and s390 allmodconfig with the error:
drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] 1138 | static int cs42l43_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function] 1124 | static int cs42l43_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function] 1106 | static int cs42l43_resume(struct device *dev) | ^~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function] 1076 | static int cs42l43_suspend(struct device *dev) | ^~~~~~~~~~~~~~~
git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
Since its almost time for v6.6-rc3, so just a quick reminder that this build failure is still not fixed.
Are you sure? I had expected eb72d5207008db ("mfd: cs42l43: Use correct macro for new-style PM runtime ops")[1] that was merged this week would have fixed this. Or am I mixing different problems up here?
Ciao, Thorsten
[1] https://lore.kernel.org/all/20230919110320.1388527-1-u.kleine-koenig@pengutr...
On 24.09.23 09:58, Thorsten Leemhuis wrote:
On 23.09.23 17:02, Sudip Mukherjee wrote:
On Wed, 30 Aug 2023 at 12:29, Sudip Mukherjee (Codethink) sudipm.mukherjee@gmail.com wrote:
The latest mainline kernel branch fails to build alpha, csky and s390 allmodconfig with the error:
drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] 1138 | static int cs42l43_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function] 1124 | static int cs42l43_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function] 1106 | static int cs42l43_resume(struct device *dev) | ^~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function] 1076 | static int cs42l43_suspend(struct device *dev) | ^~~~~~~~~~~~~~~
git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
Since its almost time for v6.6-rc3, so just a quick reminder that this build failure is still not fixed.
Are you sure? I had expected eb72d5207008db ("mfd: cs42l43: Use correct macro for new-style PM runtime ops")[1] that was merged this week would have fixed this. Or am I mixing different problems up here?
Ahh, sorry, just noticed Linus merged that fix a few hours after your mail, so I guess everything should be settled now. Ciao, Thorsten
participants (6)
-
Charles Keepax -
Linux regression tracking (Thorsten Leemhuis) -
Sudip Mukherjee -
Sudip Mukherjee (Codethink)
-
Takashi Iwai -
Thorsten Leemhuis