[alsa-devel] [PATCH] ASoC: sigmadsp: Fix missleading return value
From: Pascal Huerst pascal.huerst@gmail.com
Forwarding the return value of i2c_master_send, leads to errors later on, since i2c_master_send returns the number of bytes transmittet. Check for ret < 0 instead and return 0 otherwise.
Signed-off-by: Pascal Huerst pascal.huerst@gmail.com --- sound/soc/codecs/sigmadsp-i2c.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/sigmadsp-i2c.c b/sound/soc/codecs/sigmadsp-i2c.c index 21ca3a5..d374c18 100644 --- a/sound/soc/codecs/sigmadsp-i2c.c +++ b/sound/soc/codecs/sigmadsp-i2c.c @@ -31,7 +31,10 @@ static int sigmadsp_write_i2c(void *control_data,
kfree(buf);
- return ret; + if (ret < 0) + return ret; + + return 0; }
static int sigmadsp_read_i2c(void *control_data,
On 02/10/2016 03:59 PM, pascal.huerst@gmail.com wrote:
From: Pascal Huerst pascal.huerst@gmail.com
Forwarding the return value of i2c_master_send, leads to errors later on, since i2c_master_send returns the number of bytes transmittet. Check for ret < 0 instead and return 0 otherwise.
Signed-off-by: Pascal Huerst pascal.huerst@gmail.com
Acked-by: Lars-Peter Clausen lars@metafoo.de
sound/soc/codecs/sigmadsp-i2c.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/sigmadsp-i2c.c b/sound/soc/codecs/sigmadsp-i2c.c index 21ca3a5..d374c18 100644 --- a/sound/soc/codecs/sigmadsp-i2c.c +++ b/sound/soc/codecs/sigmadsp-i2c.c @@ -31,7 +31,10 @@ static int sigmadsp_write_i2c(void *control_data,
kfree(buf);
- return ret;
- if (ret < 0)
return ret;
- return 0;
}
static int sigmadsp_read_i2c(void *control_data,
participants (2)
-
Lars-Peter Clausen
-
pascal.huerst@gmail.com