[alsa-devel] Palm27x-asoc: fix it to work without jack gpio specified
Hi,
the patch follows. The problem was with palmz72 which doesn't have the jack detection.
On Mon, Jun 01, 2009 at 10:30:58PM +0200, Marek Vasut wrote:
- if (!(machine_is_palmtx() || machine_is_palmt5() ||
machine_is_palmld() || machine_is_palmte2()))return -ENODEV;- if (pdev->dev.platform_data)
These machine_is_() checks don't get re-added elsehwere (and it looks like you generated the diff against a different verison of the file to the one that's in ALSA git). It'd be better to keep them here and just add the { to the platform_data check.
Otherwise this is fine.
On Tuesday 02 of June 2009 00:58:44 Mark Brown wrote:
On Mon, Jun 01, 2009 at 10:30:58PM +0200, Marek Vasut wrote:
- if (!(machine_is_palmtx() || machine_is_palmt5() ||
machine_is_palmld() || machine_is_palmte2()))return -ENODEV;- if (pdev->dev.platform_data)
These machine_is_() checks don't get re-added elsehwere (and it looks like you generated the diff against a different verison of the file to the one that's in ALSA git). It'd be better to keep them here and just add the { to the platform_data check.
But do we need those checks? The driver is registered only on those machines anyway.
Otherwise this is fine.
On Tue, Jun 02, 2009 at 02:11:46AM +0200, Marek Vasut wrote:
On Tuesday 02 of June 2009 00:58:44 Mark Brown wrote:
These machine_is_() checks don't get re-added elsehwere (and it looks like you generated the diff against a different verison of the file to the one that's in ALSA git). It'd be better to keep them here and just add the { to the platform_data check.
But do we need those checks? The driver is registered only on those machines anyway.
Yes, they're not needed since it's a platform driver - that's not obvious when looking at the context diffs (this is one of those cases where explaining what you're doing in the changelog helps!).
participants (2)
-
Marek Vasut -
Mark Brown