On Thu, 26 Oct 2017 16:13:14 +0200, Mark Brown wrote:

The following changes since commit bb176f67090ca54869fc1262c913aa69d2ede070:

Linux 4.14-rc6 (2017-10-23 06:49:47 -0400)

are available in the git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v4.14-rc6

for you to fetch changes up to 0bebd2f1bfcbf954a93b65d4b2848488fd049c78:

Merge remote-tracking branches 'asoc/fix/topology' and 'asoc/fix/wm8998' into asoc-linus (2017-10-26 09:45:52 +0200)

---------------------------------------------------------------- ASoC: Fixes for v4.14

I've been quite lax in sending these due to conference season but here's a fairly large collection of ASoC updates. The one thing that's not device specific is Takashi's fix for races between delayed work and PCM destruction, otherwise everything is specific to an individual device.

Well, I have a concern about the size like this at the late stage. Can we try to shrink a bit harder? IMO, my PCM unbind workaround can be postponed to 4.15, as the unbind is still broken even with this. It can be combined with other unbind fixes. Also, topology fixes are only potential issues, and no urgent fixes for the bugs we're hitting now. So they can be postponed, too. stm32 are small fixes but they all have too bad patch descriptions... It's still OK-ish to take them, as the changes themselves are fairly easy, though. Two rt5514 changes are a bit large, but they are basically fixes and reverts for the stuff that has been added 4.14, so they should be included before the final. One Skylake jack name fix is actually wrong. It sets "HDMI/DP, pcm=%d Jack", but the right name is without space, i.e. "HDMI/DP,pcm=%d Jack". All others seem device-specific small fixes, so we can take them, I suppose, as long as they are a kind of stable-targeted fixes. (Basically the fixes with Fixes tag are candidates for stable.) Care to rearrange and resend, at the next time, to the right country? thanks, Takashi

---------------------------------------------------------------- Bard Liao (3): ASoC: rt5659: register power bit of LOUT Amp ASoC: rt5659: connect LOUT Amp with Charge Pump ASoC: rt5616: fix 0x91 default value

Charles Keepax (1): ASoC: wm8998: Correct handling of input muxes

Chintan Patel (1): ASoC: Intel: Skylake: Fix jack name format substitution

Christophe JAILLET (2): ASoC: topology: Fix a potential NULL pointer dereference in 'soc_tplg_dapm_widget_denum_create()' ASoC: topology: Fix a potential memory leak in 'soc_tplg_dapm_widget_denum_create()'

Christophe Jaillet (2): ASoC: samsung: i2s: Fix error handling path in i2s_set_sysclk() ASoC: davinci-mcasp: Fix an error handling path in 'davinci_mcasp_probe()'

Colin Ian King (1): ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index

Hsin-Yu Chao (2): ASoC: rt5514-spi: check irq status to schedule data copy ASoC: rt5514: Revert Hotword Model control

Jean-François Têtu (2): ASoC: msm8916-wcd-digital: fix RX2 MIX1 and RX3 MIX1 ASoC: codecs: msm8916-wcd-analog: fix micbias level

John Keeping (1): ASoC: rockchip: i2s: fix unbalanced clk_disable

Kuninori Morimoto (2): ASoC: rsnd: fix ADG flags ASoC: rcar: skip disabled-SSI nodes

Marek Szyprowski (1): ASoC: samsung: i2s: disable secondary DAI until it gets fixed

Mark Brown (8): Merge remote-tracking branch 'asoc/fix/intel' into asoc-linus Merge remote-tracking branch 'asoc/fix/msm8916' into asoc-linus Merge remote-tracking branch 'asoc/fix/pcm' into asoc-linus Merge remote-tracking branch 'asoc/fix/rcar' into asoc-linus Merge remote-tracking branch 'asoc/fix/rockchip' into asoc-linus Merge remote-tracking branches 'asoc/fix/adau17x1', 'asoc/fix/davinci' and 'asoc/fix/max98090' into asoc-linus Merge remote-tracking branches 'asoc/fix/rt5514', 'asoc/fix/rt5616', 'asoc/fix/rt5659', 'asoc/fix/rt5663', 'asoc/fix/samsung' and 'asoc/fix/stm32' into asoc-linus Merge remote-tracking branches 'asoc/fix/topology' and 'asoc/fix/wm8998' into asoc-linus

Olivier Moysan (3): ASoC: stm32: sai: fix stop management in isr ASoC: stm32: sai: Fix DMA burst size ASoC: stm32: sai: Fix get reset controller

Pierre-Louis Bossart (2): ASoC: max98090: reduce verbosity on PLL unlock ASoC: Intel: cht_bsw_max98090: Fix I2S config + unused code

Ricard Wanderlof (1): ASoC: adau17x1: Workaround for noise bug in ADC

Takashi Iwai (1): ASoC: pcm: Sync delayed work before releasing resources

oder_chiou@realtek.com (1): ASoC: rt5663: Change the dev getting function in rt5663_irq

sound/soc/codecs/adau17x1.c | 24 ++++++- sound/soc/codecs/adau17x1.h | 2 + sound/soc/codecs/max98090.c | 2 +- sound/soc/codecs/msm8916-wcd-analog.c | 7 +- sound/soc/codecs/msm8916-wcd-digital.c | 4 +- sound/soc/codecs/rt5514-spi.c | 17 ++++- sound/soc/codecs/rt5514-spi.h | 3 + sound/soc/codecs/rt5514.c | 63 ---------------- sound/soc/codecs/rt5514.h | 3 - sound/soc/codecs/rt5616.c | 2 +- sound/soc/codecs/rt5659.c | 4 +- sound/soc/codecs/rt5663.c | 3 +- sound/soc/codecs/wm8998.c | 84 +++++----------------- sound/soc/davinci/davinci-mcasp.c | 6 +- sound/soc/intel/boards/cht_bsw_max98090_ti.c | 6 +- .../soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 + sound/soc/intel/skylake/skl-topology.c | 2 +- sound/soc/rockchip/rockchip_i2s.c | 1 - sound/soc/samsung/i2s.c | 6 +- sound/soc/sh/rcar/adg.c | 4 +- sound/soc/sh/rcar/ssi.c | 5 +- sound/soc/soc-pcm.c | 13 +++- sound/soc/soc-topology.c | 5 +- sound/soc/stm/stm32_sai.c | 2 +- sound/soc/stm/stm32_sai_sub.c | 33 +++++---- 25 files changed, 134 insertions(+), 169 deletions(-) [1.2 signature.asc <application/pgp-signature (7bit)>]

_______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

On Fri, Oct 27, 2017 at 08:39:16AM +0200, Mark Brown wrote:

On Thu, Oct 26, 2017 at 09:39:39PM +0200, Takashi Iwai wrote:

...

IMO, my PCM unbind workaround can be postponed to 4.15, as the unbind is still broken even with this. It can be combined with other unbind fixes.

...

Also, topology fixes are only potential issues, and no urgent fixes for the bugs we're hitting now. So they can be postponed, too.

For me I'd prioritize getting things into the core over other things (and both fixes are small) but these are the ones you want to drop. I'd say the topology bugs are just straight up bugs, someone with the ability to replace the topology file can readily trigger them (as could disk corruption) and the null pointer dereference is definitely severe enough that we should just fix it.

I guess we could try to drop all the resource leak fixes but several of them are in with other patches in branches.

...

One Skylake jack name fix is actually wrong. It sets "HDMI/DP, pcm=%d Jack", but the right name is without space, i.e. "HDMI/DP,pcm=%d Jack".

So how did they test that fix then... bah.

Oops, this came from Chrome, so I guess CRAS is happy with space. I will send fix and yes they can goto next merge window. Sorry for the miss -- ~Vinod