[PATCH v2 0/2] Update lpass dt-bindings
Update va-macro driver dt-bindings and add missing properties in sc7280 machine driver dt-bindings.
Changes since v1: -- Remove sound-dai cells property patch. -- Update example in clock name change patch. -- Update commit message and add maxItems in platform proerty patch.
Srinivasa Rao Mandadapu (2): ASoC: qcom: dt-bindings: lpass-va-macro: Update clock name ASoC: dt-bindings: google,sc7280-herobrine: Add platform property
.../devicetree/bindings/sound/google,sc7280-herobrine.yaml | 12 ++++++++++++ .../devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-)
Update clock name from core to macro in lpass-va-macro node to make it compatible with existing driver and device tree node.
Fixes: 67d99b23c881 ("ASoC: qcom: dt-bindings: add bindings for lpass va macro codec") Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Reported-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml index 26f0343..0a3c688 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml @@ -36,7 +36,7 @@ properties: oneOf: - items: #for ADSP based platforms - const: mclk - - const: core + - const: macro - const: dcodec - items: #for ADSP bypass based platforms - const: mclk @@ -77,7 +77,7 @@ examples: clocks = <&aoncc 0>, <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; - clock-names = "mclk", "core", "dcodec"; + clock-names = "mclk", "macro", "dcodec"; clock-output-names = "fsgen"; qcom,dmic-sample-rate = <600000>; vdd-micb-supply = <&vreg_s4a_1p8>;
Subject prefix: ASoC: dt-bindings: qcom,lpass-va-macro: (you got such comment few days ago)
On 20/01/2023 11:31, Srinivasa Rao Mandadapu wrote:
Update clock name from core to macro in lpass-va-macro node to make it compatible with existing driver and device tree node.
s/device tree node/existing DTS files/
Reviewed-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Fixes: 67d99b23c881 ("ASoC: qcom: dt-bindings: add bindings for lpass va macro codec") Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Reported-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
You also got this comment last time... so I don't know what to do more here...
Best regards, Krzysztof
Add platform property in sc7280 machine driver bindings for including platform subnode in dai-links. This is required for binding the frontend dai driver with codec driver and cpu driver and to do dynamic pcm routing in ADSP based platforms.
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com --- .../devicetree/bindings/sound/google,sc7280-herobrine.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml index 869b403..0b1a01a 100644 --- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml @@ -75,6 +75,18 @@ patternProperties:
additionalProperties: false
+ platform: + description: Holds subnode which includes the phandle of q6apm platform device. + type: object + properties: + sound-dai: + maxItems: 1 + + required: + - sound-dai + + additionalProperties: false + required: - link-name - cpu
On 20/01/2023 11:31, Srinivasa Rao Mandadapu wrote:
Add platform property in sc7280 machine driver bindings for including platform subnode in dai-links. This is required for binding the frontend dai driver with codec driver and cpu driver and to do dynamic pcm routing in ADSP based platforms.
I have doubts that this is for binding frontend driver with codec and CPU. The CPU and codec phandles are already there, so they are bound...
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com
.../devicetree/bindings/sound/google,sc7280-herobrine.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml index 869b403..0b1a01a 100644 --- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml @@ -75,6 +75,18 @@ patternProperties:
additionalProperties: false
platform:description: Holds subnode which includes the phandle of q6apm platform device.type: objectproperties:sound-dai:maxItems: 1required:- sound-daiadditionalProperties: false- required: - link-name - cpu
Add it also to existing example.
Best regards, Krzysztof
participants (2)
-
Krzysztof Kozlowski -
Srinivasa Rao Mandadapu