[alsa-devel] [PATCH] ASoC: tlv320aic23: Remove spurious bits per word setting
From: Mark Brown broonie@linaro.org
regmap should handle any byte ordering issues required, it is looking for a byte stream from the bus, so don't set 16 bits per word. This is likely to have tested out OK due to use of an unmerged SPI controller driver.
Signed-off-by: Mark Brown broonie@linaro.org --- sound/soc/codecs/tlv320aic23-spi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic23-spi.c b/sound/soc/codecs/tlv320aic23-spi.c index 585aea436c6a..3b387e41d75d 100644 --- a/sound/soc/codecs/tlv320aic23-spi.c +++ b/sound/soc/codecs/tlv320aic23-spi.c @@ -25,7 +25,6 @@ static int aic23_spi_probe(struct spi_device *spi)
dev_dbg(&spi->dev, "probing tlv320aic23 spi device\n");
- spi->bits_per_word = 16; spi->mode = SPI_MODE_0; ret = spi_setup(spi); if (ret < 0)
On Wed, Mar 12, 2014 at 5:33 PM, Mark Brown broonie@kernel.org wrote:
From: Mark Brown broonie@linaro.org
regmap should handle any byte ordering issues required, it is looking for a byte stream from the bus, so don't set 16 bits per word. This is likely to have tested out OK due to use of an unmerged SPI controller driver.
Signed-off-by: Mark Brown broonie@linaro.org
sound/soc/codecs/tlv320aic23-spi.c | 1 - 1 file changed, 1 deletion(-)
Tested-by: Max Filippov jcmvbkbc@gmail.com
diff --git a/sound/soc/codecs/tlv320aic23-spi.c b/sound/soc/codecs/tlv320aic23-spi.c index 585aea436c6a..3b387e41d75d 100644 --- a/sound/soc/codecs/tlv320aic23-spi.c +++ b/sound/soc/codecs/tlv320aic23-spi.c @@ -25,7 +25,6 @@ static int aic23_spi_probe(struct spi_device *spi)
dev_dbg(&spi->dev, "probing tlv320aic23 spi device\n");
spi->bits_per_word = 16; spi->mode = SPI_MODE_0; ret = spi_setup(spi); if (ret < 0)
-- 1.9.0
participants (2)
-
Mark Brown
-
Max Filippov