I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu chuansheng.liu@intel.com Signed-off-by: Baole Ni baolex.ni@intel.com --- sound/pci/als4000.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/pci/als4000.c b/sound/pci/als4000.c index ff39a0c..8e95206 100644 --- a/sound/pci/als4000.c +++ b/sound/pci/als4000.c @@ -95,14 +95,14 @@ static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP; /* Enable this card static int joystick_port[SNDRV_CARDS]; #endif

-module_param_array(index, int, NULL, 0444); +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(index, "Index value for ALS4000 soundcard."); -module_param_array(id, charp, NULL, 0444); +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(id, "ID string for ALS4000 soundcard."); -module_param_array(enable, bool, NULL, 0444); +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable, "Enable ALS4000 soundcard."); #ifdef SUPPORT_JOYSTICK -module_param_array(joystick_port, int, NULL, 0444); +module_param_array(joystick_port, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(joystick_port, "Joystick port address for ALS4000 soundcard. (0 = disabled)"); #endif