[PATCH v1 1/1] rsnd: ssiu: add missing .quit callback for gen2
From: Wang Jiada jiada_wang@mentor.com
commit 83b220cf8eb2a ("ASoC: rsnd: implement BUSIF related code in ssiu.c") moved BUSIF related code in ssiu.c which added .quit callback in ssiu.c to disable error irq when ssiu quits.
But .quit callback was added only for gen1 and is missing for gen2, this causes error irq is left enabled after ssiu quits on gen2.
This commit adds missing .quit callback for gen2
Signed-off-by: Wang Jiada jiada_wang@mentor.com Cc: Dean Jenkins Dean_Jenkins@mentor.com Cc: Eugeniu Rosca erosca@de.adit-jv.com --- sound/soc/sh/rcar/ssiu.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c index 4b8a63e336c7..19a8030a660d 100644 --- a/sound/soc/sh/rcar/ssiu.c +++ b/sound/soc/sh/rcar/ssiu.c @@ -417,6 +417,7 @@ static struct rsnd_mod_ops rsnd_ssiu_ops_gen2 = { .name = SSIU_NAME, .dma_req = rsnd_ssiu_dma_req, .init = rsnd_ssiu_init_gen2, + .quit = rsnd_ssiu_quit, .start = rsnd_ssiu_start_gen2, .stop = rsnd_ssiu_stop_gen2, .get_status = rsnd_ssiu_get_status,
Hi
From: Wang Jiada jiada_wang@mentor.com
commit 83b220cf8eb2a ("ASoC: rsnd: implement BUSIF related code in ssiu.c") moved BUSIF related code in ssiu.c which added .quit callback in ssiu.c to disable error irq when ssiu quits.
But .quit callback was added only for gen1 and is missing for gen2, this causes error irq is left enabled after ssiu quits on gen2.
This commit adds missing .quit callback for gen2
Signed-off-by: Wang Jiada jiada_wang@mentor.com Cc: Dean Jenkins Dean_Jenkins@mentor.com Cc: Eugeniu Rosca erosca@de.adit-jv.com
Acked-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Thank you for your help !!
Best regards --- Kuninori Morimoto
On Mon, 18 Jul 2022 20:04:04 +0900, Jiada Wang wrote:
From: Wang Jiada jiada_wang@mentor.com
commit 83b220cf8eb2a ("ASoC: rsnd: implement BUSIF related code in ssiu.c") moved BUSIF related code in ssiu.c which added .quit callback in ssiu.c to disable error irq when ssiu quits.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] rsnd: ssiu: add missing .quit callback for gen2 commit: 11e9318ff7486f375cf246c172c3206a731a2254
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (3)
-
Jiada Wang -
Kuninori Morimoto -
Mark Brown