[alsa-devel] [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h
Include <linux/module.h> to fix below build error:
CC sound/soc/samsung/s3c-i2s-v2.o sound/soc/samsung/s3c-i2s-v2.c:573: warning: data definition has no type or storage class sound/soc/samsung/s3c-i2s-v2.c:573: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' sound/soc/samsung/s3c-i2s-v2.c:573: warning: parameter names (without types) in function declaration sound/soc/samsung/s3c-i2s-v2.c:638: warning: data definition has no type or storage class sound/soc/samsung/s3c-i2s-v2.c:638: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' sound/soc/samsung/s3c-i2s-v2.c:638: warning: parameter names (without types) in function declaration sound/soc/samsung/s3c-i2s-v2.c:677: warning: data definition has no type or storage class sound/soc/samsung/s3c-i2s-v2.c:677: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' sound/soc/samsung/s3c-i2s-v2.c:677: warning: parameter names (without types) in function declaration sound/soc/samsung/s3c-i2s-v2.c: In function 's3c_i2sv2_register_dai': sound/soc/samsung/s3c-i2s-v2.c:736: warning: initialization discards qualifiers from pointer target type sound/soc/samsung/s3c-i2s-v2.c: At top level: sound/soc/samsung/s3c-i2s-v2.c:754: warning: data definition has no type or storage class sound/soc/samsung/s3c-i2s-v2.c:754: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' sound/soc/samsung/s3c-i2s-v2.c:754: warning: parameter names (without types) in function declaration sound/soc/samsung/s3c-i2s-v2.c:756: error: expected declaration specifiers or '...' before string constant sound/soc/samsung/s3c-i2s-v2.c:756: warning: data definition has no type or storage class sound/soc/samsung/s3c-i2s-v2.c:756: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' sound/soc/samsung/s3c-i2s-v2.c:756: warning: function declaration isn't a prototype make[3]: *** [sound/soc/samsung/s3c-i2s-v2.o] Error 1 make[2]: *** [sound/soc/samsung] Error 2 make[1]: *** [sound/soc] Error 2 make: *** [sound] Error 2
Signed-off-by: Axel Lin axel.lin@gmail.com --- This patch is against linux-next (20110930).
sound/soc/samsung/s3c-i2s-v2.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c index 52074a2b..7a73380 100644 --- a/sound/soc/samsung/s3c-i2s-v2.c +++ b/sound/soc/samsung/s3c-i2s-v2.c @@ -16,6 +16,7 @@ * option) any later version. */
+#include <linux/module.h> #include <linux/delay.h> #include <linux/clk.h> #include <linux/io.h>
On Sun, Oct 02, 2011 at 09:34:26PM +0800, Axel Lin wrote:
Include <linux/module.h> to fix below build error:
CC sound/soc/samsung/s3c-i2s-v2.o sound/soc/samsung/s3c-i2s-v2.c:573: warning: data definition has no type or storage class
What tree is this for? My primary development platform is based on this driver, I'd expect to have noticed any build issues and I rather suspect this isn't what you're supposed to do after all the module.h stuff has settled down.
2011/10/3 Mark Brown broonie@opensource.wolfsonmicro.com:
On Sun, Oct 02, 2011 at 09:34:26PM +0800, Axel Lin wrote:
Include <linux/module.h> to fix below build error:
CC sound/soc/samsung/s3c-i2s-v2.o sound/soc/samsung/s3c-i2s-v2.c:573: warning: data definition has no type or storage class
What tree is this for? My primary development platform is based on this driver, I'd expect to have noticed any build issues and I rather suspect this isn't what you're supposed to do after all the module.h stuff has settled down.
I got the build error on linux-next (20110930).
On Mon, Oct 03, 2011 at 08:17:21AM +0800, Axel Lin wrote:
2011/10/3 Mark Brown broonie@opensource.wolfsonmicro.com:
What tree is this for? ?My primary development platform is based on this driver, I'd expect to have noticed any build issues and I rather suspect this isn't what you're supposed to do after all the module.h stuff has settled down.
I got the build error on linux-next (20110930).
That's exactly what I'm running at the minute with no problem...
participants (2)
-
Axel Lin -
Mark Brown