[alsa-devel] [PATCH 1/2] aplay: Show usage if no parameter is passed
From: Fabio Estevam fabio.estevam@freescale.com
When aplay/arecord are called without any argument the application hangs forever.
Instead of hanging, print the usage and exit.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- aplay/aplay.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/aplay/aplay.c b/aplay/aplay.c index 741979a..9cc5063 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -519,6 +519,11 @@ int main(int argc, char *argv[]) return 1; }
+ if (argc == 1) { + usage(command); + return 0; + } + chunk_size = -1; rhwparams.format = DEFAULT_FORMAT; rhwparams.rate = DEFAULT_SPEED;
From: Fabio Estevam fabio.estevam@freescale.com
When ac3dec is called without any argument the application hangs forever.
Instead of hanging, print the usage and exit.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- ac3dec/ac3dec.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/ac3dec/ac3dec.c b/ac3dec/ac3dec.c index 00c4f1a..f1423e3 100644 --- a/ac3dec/ac3dec.c +++ b/ac3dec/ac3dec.c @@ -130,6 +130,11 @@ int main(int argc,char *argv[]) out_config.spdif = SPDIF_NONE; out_config.hdmi = 0;
+ if (argc == 1) { + help(); + return 0; + } + morehelp = 0; while (1) { int c;
Fabio Estevam wrote:
When aplay/arecord are called without any argument the application hangs forever.
Instead of hanging, print the usage and exit.
- if (argc == 1) {
usage(command);return 0;- }
It's possible to call it with "aplay < somefile". Better add a check like isatty(fileno(stdin)).
Regards, Clemens
participants (2)
-
Clemens Ladisch -
Fabio Estevam