[alsa-devel] [PATCH] ALSA: hda - Refer to macmini3 channel mode functions
From: Luke Yelavich luke.yelavich@canonical.com
Refer to alc885_macmini3_{2,6}ch_mode_init functions instead of those for the mb5 model quirk. While they are the functino contents are the same now, things may change later. This also gets rid of compiler warnings about initialized, but unused functions.
Signed-off-by: Luke Yelavich luke.yelavich@canonical.com --- sound/pci/hda/patch_realtek.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index f8fb260..9e5ea9e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7033,8 +7033,8 @@ static struct hda_verb alc885_macmini3_ch6_init[] = { };
static struct hda_channel_mode alc885_macmini3_6ch_modes[2] = { - { 2, alc885_mb5_ch2_init }, - { 6, alc885_mb5_ch6_init }, + { 2, alc885_macmini3_ch2_init }, + { 6, alc885_macmini3_ch6_init }, };
Am Dienstag, den 23.02.2010, 16:25 +1100 schrieb Luke Yelavich:
From: Luke Yelavich luke.yelavich@canonical.com
Refer to alc885_macmini3_{2,6}ch_mode_init functions instead of those for the mb5 model quirk. While they are the functino contents are the same now, things
While the functions are the same now, …
may change later. This also gets rid of compiler warnings about initialized, but unused functions.
Signed-off-by: Luke Yelavich luke.yelavich@canonical.com
Maybe you can send a v2 patch (see `--subject-prefix` in `git help format-patch` or edit manually) and CC the maintainers (for example `--cc`) [2] as documented in [1]. At least I was told so [3] and I think you patch will be taken care off earlier when doing so.
Thanks,
Paul
[1] http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=blob;f=Docum... [2] http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=blob;f=MAINT... [3] http://www.spinics.net/lists/alsa-devel/msg31371.html
At Tue, 23 Feb 2010 11:34:31 +0100, Paul Menzel wrote:
Am Dienstag, den 23.02.2010, 16:25 +1100 schrieb Luke Yelavich:
From: Luke Yelavich luke.yelavich@canonical.com
Refer to alc885_macmini3_{2,6}ch_mode_init functions instead of those for the mb5 model quirk. While they are the functino contents are the same now, things
While the functions are the same now, …
Yeah, I already fixed it differently (rather a clean-up).
may change later. This also gets rid of compiler warnings about initialized, but unused functions.
Signed-off-by: Luke Yelavich luke.yelavich@canonical.com
Maybe you can send a v2 patch (see `--subject-prefix` in `git help format-patch` or edit manually) and CC the maintainers (for example `--cc`) [2] as documented in [1]. At least I was told so [3] and I think you patch will be taken care off earlier when doing so.
That's helpful indeed.
thanks,
Takashi
Thanks,
Paul
[1] http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=blob;f=Docum... [2] http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=blob;f=MAINT... [3] http://www.spinics.net/lists/alsa-devel/msg31371.html [1.2 Dies ist ein digital signierter Nachrichtenteil <application/pgp-signature (7bit)>]
[2 <text/plain; us-ascii (7bit)>] _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (3)
-
Luke Yelavich -
Paul Menzel -
Takashi Iwai