Re: [alsa-devel] [PATCH 00/10] patch set about the MXS-DMA
On Thu, Jan 19, 2012 at 02:15:57PM +0800, Huang Shijie wrote:
This patch set does two things about the MXS-DMA: [1] patch 1 ~ patch 5: move the mxs dma header to a more common place. Beside the mx23/mx28, the APBH-DMA is also used by MX50 and MX6Q. So move the mxs dma header file to a more common place, and rename it to mxs-dma.h
For the sake of bitsec, these 5 patches need to be one.
[2] patch 6 ~ patch 10: rewrite the last parameter of mxs_dma_prep_slave_sg().
For the sake of bitsec, at least patches #7 and #8 need to be one patch. That said, if I apply the series and then check out the commit at patch #7, you need to all mxs-dma client drivers, mxs-mmc, gpmi do not break.
In the new GPMI version, some hardware behavior changes. The WAIT4END bit should be set in the middle one of the ECC READ page DMA chain. The DMA chain should be set like this:
+-----+ +-----+ +-----+ | cmd | ------------> | cmd | ------------------> | cmd | +-----+ +-----+ +-----+ ^ ^ | | | | set WAIT4END here too set WAIT4END here Please read the comment in patch "MXS-DMA : add more flags for MXS-DMA".
Huang Shijie (10): MXS-DMA : move the mxs-dma.h to a more common place MXS-DMA : change the header MXS-MMC : change the DMA header file MTD/GPMI : change the DMA header file ASoc : change the DMA header file MXS-DMA : add more flags for MXS-DMA MXS-DMA : change the last parameter of mxs_dma_prep_slave_sg() MXS-MMC : use the new DMA flags MTD/GPMI : add a new field `gpmi_version` MTD/GPMI : change the code for new DMA interface
Please try to make these subject prefix consistent with the existing ones in the tree. You can get them from 'git log' output. For example "mxs-dma: ..." is better than "MXS-DMA : ...".
[2] patch 6 ~ patch 10: rewrite the last parameter of mxs_dma_prep_slave_sg().
For the sake of bitsec, at least patches #7 and #8 need to be one patch. That said, if I apply the series and then check out the commit at patch #7, you need to all mxs-dma client drivers, mxs-mmc, gpmi do not break.
I'd say patch 6-10 should be squashed, simply. My personal preference is to change #9 to simply read the register when needed and do not expand the struct, but this is a minor thing.
Regards,
Wolfram
participants (2)
-
Shawn Guo
-
Wolfram Sang