[alsa-devel] [PATCH 1/2] ASoC: Remove unused DAPM_DOUBLE control types

Mark Brown

14 Dec 2010 14 Dec '10

5:53 p.m.

There are no users of these and it's not clear what they would do given the mono flow modelling which DAPM does. If need arises we can add them again.

Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com ---

May as well do this anyway, regardless of the fate of patch 2/2 but patch 2/2 will remove the implementation of stereo controls so depends on this one.

include/sound/soc-dapm.h | 16 ---------------- 1 files changed, 0 insertions(+), 16 deletions(-)

diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h index 2f76a51..aef975f 100644 --- a/include/sound/soc-dapm.h +++ b/include/sound/soc-dapm.h @@ -227,13 +227,6 @@ .info = snd_soc_info_volsw, \ .get = snd_soc_dapm_get_volsw, .put = snd_soc_dapm_put_volsw, \ .private_value = SOC_SINGLE_VALUE(reg, shift, max, invert) } -#define SOC_DAPM_DOUBLE(xname, reg, shift_left, shift_right, max, invert, \ - power) \ -{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = (xname), \ - .info = snd_soc_info_volsw, \ - .get = snd_soc_dapm_get_volsw, .put = snd_soc_dapm_put_volsw, \ - .private_value = (reg) | ((shift_left) << 8) | ((shift_right) << 12) |\ - ((max) << 16) | ((invert) << 24) } #define SOC_DAPM_SINGLE_TLV(xname, reg, shift, max, invert, tlv_array) \ { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, \ .info = snd_soc_info_volsw, \ @@ -241,15 +234,6 @@ .tlv.p = (tlv_array), \ .get = snd_soc_dapm_get_volsw, .put = snd_soc_dapm_put_volsw, \ .private_value = SOC_SINGLE_VALUE(reg, shift, max, invert) } -#define SOC_DAPM_DOUBLE_TLV(xname, reg, shift_left, shift_right, max, invert, \ - power, tlv_array) \ -{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = (xname), \ - .access = SNDRV_CTL_ELEM_ACCESS_TLV_READ | SNDRV_CTL_ELEM_ACCESS_READWRITE,\ - .tlv.p = (tlv_array), \ - .info = snd_soc_info_volsw, \ - .get = snd_soc_dapm_get_volsw, .put = snd_soc_dapm_put_volsw, \ - .private_value = (reg) | ((shift_left) << 8) | ((shift_right) << 12) |\ - ((max) << 16) | ((invert) << 24) } #define SOC_DAPM_ENUM(xname, xenum) \ { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, \ .info = snd_soc_info_enum_double, \

-- 1.7.1

Show replies by date

Mark Brown

14 Dec 14 Dec

5:53 p.m.

New subject: [alsa-devel] [PATCH 2/2] ASoC: Do DAPM control updates in the middle of DAPM sequences

Attempt to minimise audible effects from mixer and mux updates by implementing the actual register changes between powering down widgets that have become unused and powering up widgets that are newly used.

This means that we're making the change with the minimum set of widgets powered, that the input path is connected when we're powering up widgets (so things like DC offset correction can run with their signal active) and that we bring things down to cold before switching away. Since hardware tends to be designed for the power on/off case more than for dynamic reconfiguration this should minimise pops and clicks during reconfiguration while active.

Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com ---

Peter, I think this will address your widget reordering issue - I'd appreciate it if you could test and let me know if it helps. If this works it avoids the need for the the widget to know anything about the particular algorithm implemented by DAPM which seems more robust to me.

Sorry about how long it took to get this done.

include/sound/soc-dapm.h | 10 ++++ sound/soc/soc-dapm.c | 130 +++++++++++++++++++++++++-------------------- 2 files changed, 82 insertions(+), 58 deletions(-)

diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h index aef975f..1490c72 100644 --- a/include/sound/soc-dapm.h +++ b/include/sound/soc-dapm.h @@ -460,6 +460,14 @@ struct snd_soc_dapm_widget { struct list_head power_list; };

+struct snd_soc_dapm_update { + struct snd_soc_dapm_widget *widget; + struct snd_kcontrol *kcontrol; + int reg; + int mask; + int val; +}; + /* DAPM context */ struct snd_soc_dapm_context { struct list_head widgets; @@ -469,6 +477,8 @@ struct snd_soc_dapm_context { struct delayed_work delayed_work; unsigned int idle_bias_off:1; /* Use BIAS_OFF instead of STANDBY */

+ struct snd_soc_dapm_update *update; + struct device *dev; /* from parent - for debug */ struct snd_soc_codec *codec; /* parent codec */ struct snd_soc_card *card; /* parent card */ diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 3d310af..9077cf0 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -916,6 +916,41 @@ static void dapm_seq_run(struct snd_soc_dapm_context *dapm, dapm_seq_run_coalesced(dapm, &pending); }

+static void dapm_widget_update(struct snd_soc_dapm_context *dapm) +{ + struct snd_soc_dapm_update *update = dapm->update; + struct snd_soc_dapm_widget *w; + int ret; + + if (!update) + return; + + w = update->widget; + + if (w->event && + (w->event_flags & SND_SOC_DAPM_PRE_REG)) { + ret = w->event(w, update->kcontrol, SND_SOC_DAPM_PRE_REG); + if (ret != 0) + pr_err("%s DAPM pre-event failed: %d\n", + w->name, ret); + } + + ret = snd_soc_update_bits(w->codec, update->reg, update->mask, + update->val); + if (ret < 0) + pr_err("%s DAPM update failed: %d\n", w->name, ret); + + if (w->event && + (w->event_flags & SND_SOC_DAPM_POST_REG)) { + ret = w->event(w, update->kcontrol, SND_SOC_DAPM_POST_REG); + if (ret != 0) + pr_err("%s DAPM post-event failed: %d\n", + w->name, ret); + } +} + + + /* * Scan each dapm widget for complete audio path. * A complete path is a route that has valid endpoints i.e.:- @@ -1026,6 +1061,8 @@ static int dapm_power_widgets(struct snd_soc_dapm_context *dapm, int event) /* Power down widgets first; try to avoid amplifying pops. */ dapm_seq_run(dapm, &down_list, event, dapm_down_seq);

+ dapm_widget_update(dapm); + /* Now power up. */ dapm_seq_run(dapm, &up_list, event, dapm_up_seq);

@@ -1634,13 +1671,12 @@ int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol, (struct soc_mixer_control *)kcontrol->private_value; unsigned int reg = mc->reg; unsigned int shift = mc->shift; - unsigned int rshift = mc->rshift; int max = mc->max; unsigned int mask = (1 << fls(max)) - 1; unsigned int invert = mc->invert; - unsigned int val, val2, val_mask; - int connect; - int ret; + unsigned int val, val_mask; + int connect, change; + struct snd_soc_dapm_update update;

val = (ucontrol->value.integer.value[0] & mask);

@@ -1648,18 +1684,12 @@ int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol, val = max - val; val_mask = mask << shift; val = val << shift; - if (shift != rshift) { - val2 = (ucontrol->value.integer.value[1] & mask); - if (invert) - val2 = max - val2; - val_mask |= mask << rshift; - val |= val2 << rshift; - }

mutex_lock(&widget->codec->mutex); widget->value = val;

- if (snd_soc_test_bits(widget->codec, reg, val_mask, val)) { + change = snd_soc_test_bits(widget->codec, reg, val_mask, val); + if (change) { if (val) /* new connection */ connect = invert ? 0:1; @@ -1667,28 +1697,20 @@ int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol, /* old connection must be powered down */ connect = invert ? 1:0;

+ update.kcontrol = kcontrol; + update.widget = widget; + update.reg = reg; + update.mask = mask; + update.val = val; + widget->dapm->update = &update; + dapm_mixer_update_power(widget, kcontrol, connect); + + widget->dapm->update = NULL; }

- if (widget->event) { - if (widget->event_flags & SND_SOC_DAPM_PRE_REG) { - ret = widget->event(widget, kcontrol, - SND_SOC_DAPM_PRE_REG); - if (ret < 0) { - ret = 1; - goto out; - } - } - ret = snd_soc_update_bits(widget->codec, reg, val_mask, val); - if (widget->event_flags & SND_SOC_DAPM_POST_REG) - ret = widget->event(widget, kcontrol, - SND_SOC_DAPM_POST_REG); - } else - ret = snd_soc_update_bits(widget->codec, reg, val_mask, val); - -out: mutex_unlock(&widget->codec->mutex); - return ret; + return 0; } EXPORT_SYMBOL_GPL(snd_soc_dapm_put_volsw);

@@ -1736,7 +1758,7 @@ int snd_soc_dapm_put_enum_double(struct snd_kcontrol *kcontrol, struct soc_enum *e = (struct soc_enum *)kcontrol->private_value; unsigned int val, mux, change; unsigned int mask, bitmask; - int ret = 0; + struct snd_soc_dapm_update update;

for (bitmask = 1; bitmask < e->max; bitmask <<= 1) ; @@ -1755,24 +1777,20 @@ int snd_soc_dapm_put_enum_double(struct snd_kcontrol *kcontrol, mutex_lock(&widget->codec->mutex); widget->value = val; change = snd_soc_test_bits(widget->codec, e->reg, mask, val); - dapm_mux_update_power(widget, kcontrol, change, mux, e);

- if (widget->event_flags & SND_SOC_DAPM_PRE_REG) { - ret = widget->event(widget, - kcontrol, SND_SOC_DAPM_PRE_REG); - if (ret < 0) - goto out; - } + update.kcontrol = kcontrol; + update.widget = widget; + update.reg = e->reg; + update.mask = mask; + update.val = val; + widget->dapm->update = &update;

- ret = snd_soc_update_bits(widget->codec, e->reg, mask, val); + dapm_mux_update_power(widget, kcontrol, change, mux, e);

- if (widget->event_flags & SND_SOC_DAPM_POST_REG) - ret = widget->event(widget, - kcontrol, SND_SOC_DAPM_POST_REG); + widget->dapm->update = NULL;

-out: mutex_unlock(&widget->codec->mutex); - return ret; + return change; } EXPORT_SYMBOL_GPL(snd_soc_dapm_put_enum_double);

@@ -1884,7 +1902,7 @@ int snd_soc_dapm_put_value_enum_double(struct snd_kcontrol *kcontrol, struct soc_enum *e = (struct soc_enum *)kcontrol->private_value; unsigned int val, mux, change; unsigned int mask; - int ret = 0; + struct snd_soc_dapm_update update;

if (ucontrol->value.enumerated.item[0] > e->max - 1) return -EINVAL; @@ -1901,24 +1919,20 @@ int snd_soc_dapm_put_value_enum_double(struct snd_kcontrol *kcontrol, mutex_lock(&widget->codec->mutex); widget->value = val; change = snd_soc_test_bits(widget->codec, e->reg, mask, val); - dapm_mux_update_power(widget, kcontrol, change, mux, e);

- ret = snd_soc_update_bits(widget->codec, e->reg, mask, val); + dapm_mux_update_power(widget, kcontrol, change, mux, e);

- if (widget->event_flags & SND_SOC_DAPM_POST_REG) - ret = widget->event(widget, - kcontrol, SND_SOC_DAPM_POST_REG); + widget->dapm->update = NULL;

-out: mutex_unlock(&widget->codec->mutex); - return ret; + return change; } EXPORT_SYMBOL_GPL(snd_soc_dapm_put_value_enum_double);

-- 1.7.1

Peter Ujfalusi

16 Dec 16 Dec

8:39 a.m.

New subject: [alsa-devel] [PATCH 2/2] ASoC: Do DAPM control updates in the middle of DAPM sequences

On Tuesday 14 December 2010 19:53:22 ext Mark Brown wrote:

...

Attempt to minimise audible effects from mixer and mux updates by implementing the actual register changes between powering down widgets that have become unused and powering up widgets that are newly used.

This means that we're making the change with the minimum set of widgets powered, that the input path is connected when we're powering up widgets (so things like DC offset correction can run with their signal active) and that we bring things down to cold before switching away. Since hardware tends to be designed for the power on/off case more than for dynamic reconfiguration this should minimise pops and clicks during reconfiguration while active.

Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com

Peter, I think this will address your widget reordering issue - I'd appreciate it if you could test and let me know if it helps. If this works it avoids the need for the the widget to know anything about the particular algorithm implemented by DAPM which seems more robust to me.

Sorry about how long it took to get this done.

I'll try to give this one a try soon, sorry for the delay, but I got sidetracked...

-- Péter

Peter Ujfalusi

1:03 p.m.

New subject: [alsa-devel] [PATCH 2/2] ASoC: Do DAPM control updates in the middle of DAPM sequences

On Tuesday 14 December 2010 19:53:22 ext Mark Brown wrote:

...

@@ -1634,13 +1671,12 @@ int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol, (struct soc_mixer_control *)kcontrol->private_value; unsigned int reg = mc->reg; unsigned int shift = mc->shift;
  unsigned int rshift = mc->rshift;
  int max = mc->max;
  unsigned int mask = (1 << fls(max)) - 1;
  unsigned int invert = mc->invert;
  unsigned int val, val2, val_mask;
  int connect;
  int ret;
  unsigned int val, val_mask;
  int connect, change;

You do not need the change variable, since

...

  struct snd_soc_dapm_update update;

  val = (ucontrol->value.integer.value[0] & mask);

@@ -1648,18 +1684,12 @@ int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol, val = max - val; val_mask = mask << shift; val = val << shift;

```
  if (shift != rshift) {
```

          val2 = (ucontrol->value.integer.value[1] & mask);

```
          if (invert)
```
```
                  val2 = max - val2;
```
```
          val_mask |= mask << rshift;
```
```
          val |= val2 << rshift;
```

  }

  mutex_lock(&widget->codec->mutex);
  widget->value = val;

  if (snd_soc_test_bits(widget->codec, reg, val_mask, val)) {

  change = snd_soc_test_bits(widget->codec, reg, val_mask, val);

```
  if (change) {
```

it is used only here, so you could just keep the old if () way.

...

            if (val)
                    /* new connection */
                    connect = invert ? 0:1;

@@ -1667,28 +1697,20 @@ int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol, /* old connection must be powered down */ connect = invert ? 1:0;

```
          update.kcontrol = kcontrol;
```
```
          update.widget = widget;
```
```
          update.reg = reg;
```
```
          update.mask = mask;
```
```
          update.val = val;
```

          widget->dapm->update = &update;

          dapm_mixer_update_power(widget, kcontrol, connect);

          widget->dapm->update = NULL;
  }

```
  if (widget->event) {
```

          if (widget->event_flags & SND_SOC_DAPM_PRE_REG) {

                  ret = widget->event(widget, kcontrol,

                                          SND_SOC_DAPM_PRE_REG);

```
                  if (ret < 0) {
```
```
                          ret = 1;
```
```
                          goto out;
```
```
                  }
```
```
          }
```

          ret = snd_soc_update_bits(widget->codec, reg, val_mask,

val); - if (widget->event_flags & SND_SOC_DAPM_POST_REG)

                  ret = widget->event(widget, kcontrol,

                                          SND_SOC_DAPM_POST_REG);

```
  } else
```

          ret = snd_soc_update_bits(widget->codec, reg, val_mask,

val); - -out: mutex_unlock(&widget->codec->mutex);

```
  return ret;
```

```
  return 0;
```

} EXPORT_SYMBOL_GPL(snd_soc_dapm_put_volsw);

-- Péter

Peter Ujfalusi

1:51 p.m.

New subject: [alsa-devel] [PATCH 2/2] ASoC: Do DAPM control updates in the middle of DAPM sequences

On Tuesday 14 December 2010 19:53:22 ext Mark Brown wrote:

...

Attempt to minimise audible effects from mixer and mux updates by implementing the actual register changes between powering down widgets that have become unused and powering up widgets that are newly used.

This means that we're making the change with the minimum set of widgets powered, that the input path is connected when we're powering up widgets (so things like DC offset correction can run with their signal active) and that we bring things down to cold before switching away. Since hardware tends to be designed for the power on/off case more than for dynamic reconfiguration this should minimise pops and clicks during reconfiguration while active.

Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com

Peter, I think this will address your widget reordering issue - I'd appreciate it if you could test and let me know if it helps. If this works it avoids the need for the the widget to know anything about the particular algorithm implemented by DAPM which seems more robust to me.

Sorry about how long it took to get this done.

Well, it is good, and bad. It behaves mostly OK, but there's a strange side effect: I noticed a pop on playback stream start on the twl4030 codec. I'll look into it, but I do not see how this patch can affect the stream start.. Could you hold this patch for some time, so I can look at this?

Thanks, Péter

Mark Brown

1:55 p.m.

New subject: [alsa-devel] [PATCH 2/2] ASoC: Do DAPM control updates in the middle of DAPM sequences

On Thu, Dec 16, 2010 at 03:51:13PM +0200, Peter Ujfalusi wrote:

...

It behaves mostly OK, but there's a strange side effect: I noticed a pop on playback stream start on the twl4030 codec. I'll look into it, but I do not see how this patch can affect the stream start..

Indeed, it should result in an extra comparison in the middle of the DAPM sequence which oughtn't to have any effect here. Is it possible that some of the other updates that have been going in recently such as the cross-device changes introduced this, or is it definitely just this one patch?

...

Could you hold this patch for some time, so I can look at this?

Sure.

Peter Ujfalusi

17 Dec 17 Dec

7:08 a.m.

New subject: [alsa-devel] [PATCH 2/2] ASoC: Do DAPM control updates in the middle of DAPM sequences

On Thursday 16 December 2010 15:55:05 ext Mark Brown wrote:

...

On Thu, Dec 16, 2010 at 03:51:13PM +0200, Peter Ujfalusi wrote:

...
It behaves mostly OK, but there's a strange side effect: I noticed a pop on playback stream start on the twl4030 codec. I'll look into it, but I do not see how this patch can affect the stream start..

Indeed, it should result in an extra comparison in the middle of the DAPM sequence which oughtn't to have any effect here. Is it possible that some of the other updates that have been going in recently such as the cross-device changes introduced this, or is it definitely just this one patch?

Found the reason.. The pop is there without this patch, it is coming from the output amp power up. In normal use case, it is filtered by the external amp, but I use non convetional setup at the moment, and that is the reason for the pop. I need to take a look at this at some time :(

...

...
Could you hold this patch for some time, so I can look at this?

Sure.

Thanks, You can pick either of my:

Acked-by: Peter Ujfalusi peter.ujfalusi@nokia.com Tested-by: Peter Ujfalusi peter.ujfalusi@nokia.com

Mark Brown

11:45 a.m.

New subject: [alsa-devel] [PATCH 2/2] ASoC: Do DAPM control updates in the middle of DAPM sequences

On Fri, Dec 17, 2010 at 09:08:41AM +0200, Peter Ujfalusi wrote:

...

In normal use case, it is filtered by the external amp, but I use non convetional setup at the moment, and that is the reason for the pop. I need to take a look at this at some time :(

Ah, well. At least the mux issue should be fixed now.

...

You can pick either of my:

...

Acked-by: Peter Ujfalusi peter.ujfalusi@nokia.com Tested-by: Peter Ujfalusi peter.ujfalusi@nokia.com

Why choose? :)

Liam Girdwood

15 Dec 15 Dec

1:37 p.m.

New subject: [alsa-devel] [PATCH 1/2] ASoC: Remove unused DAPM_DOUBLE control types

On Tue, 2010-12-14 at 17:53 +0000, Mark Brown wrote:

...

There are no users of these and it's not clear what they would do given the mono flow modelling which DAPM does. If need arises we can add them again.

Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com

All

Acked-by: Liam Girdwood lrg@slimlogic.co.uk

-- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk

Mark Brown

6:10 p.m.

New subject: [alsa-devel] [PATCH 1/2] ASoC: Remove unused DAPM_DOUBLE control types

On Wed, Dec 15, 2010 at 01:37:09PM +0000, Liam Girdwood wrote:

...

On Tue, 2010-12-14 at 17:53 +0000, Mark Brown wrote:

...
There are no users of these and it's not clear what they would do given the mono flow modelling which DAPM does. If need arises we can add them again.

Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com

...

All

...

Acked-by: Liam Girdwood lrg@slimlogic.co.uk

I've pushed the first patch out now but I'll wait for Peter's testing before doing anything with the second one.

5066

Age (days ago)

5069

Last active (days ago)

List overview

Download

9 comments

3 participants

tags (0)

participants (3)

Liam Girdwood
Mark Brown
Peter Ujfalusi