[PATCH] ALSA: make snd_kcontrol_new name a normal string
From: Arnd Bergmann arnd@arndb.de
When building with W=2, there are lots of warnings about the snd_kcontrol_new name field being an array of 'unsigned char' but initialized to a string:
include/sound/soc.h:93:48: warning: pointer targets in initialization of 'const unsigned char *' from 'char *' differ in signedness [-Wpointer-sign]
Make it a regular 'char *' to avoid flooding the build log with this.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Arnd Bergmann arnd@arndb.de --- include/sound/control.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/sound/control.h b/include/sound/control.h index e128cff10dfa..77d9fa10812d 100644 --- a/include/sound/control.h +++ b/include/sound/control.h @@ -42,7 +42,7 @@ struct snd_kcontrol_new { snd_ctl_elem_iface_t iface; /* interface identifier */ unsigned int device; /* device/client number */ unsigned int subdevice; /* subdevice (substream) number */ - const unsigned char *name; /* ASCII name of item */ + const char *name; /* ASCII name of item */ unsigned int index; /* index of item */ unsigned int access; /* access rights */ unsigned int count; /* count of same elements */
On Mon, 26 Oct 2020 17:52:18 +0100, Arnd Bergmann wrote:
From: Arnd Bergmann arnd@arndb.de
When building with W=2, there are lots of warnings about the snd_kcontrol_new name field being an array of 'unsigned char' but initialized to a string:
include/sound/soc.h:93:48: warning: pointer targets in initialization of 'const unsigned char *' from 'char *' differ in signedness [-Wpointer-sign]
Make it a regular 'char *' to avoid flooding the build log with this.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Arnd Bergmann arnd@arndb.de
I'm fine to apply this, but I thought we agreed to ignore pointer signedness intentionally? There are lots of such places and we were fed up in the past when gcc complained a lot about those...
thanks,
Takashi
On Mon, Oct 26, 2020 at 6:03 PM Takashi Iwai tiwai@suse.de wrote:
On Mon, 26 Oct 2020 17:52:18 +0100, Arnd Bergmann wrote:
From: Arnd Bergmann arnd@arndb.de
When building with W=2, there are lots of warnings about the snd_kcontrol_new name field being an array of 'unsigned char' but initialized to a string:
include/sound/soc.h:93:48: warning: pointer targets in initialization of 'const unsigned char *' from 'char *' differ in signedness [-Wpointer-sign]
Make it a regular 'char *' to avoid flooding the build log with this.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Arnd Bergmann arnd@arndb.de
I'm fine to apply this, but I thought we agreed to ignore pointer signedness intentionally? There are lots of such places and we were fed up in the past when gcc complained a lot about those...
I'm only sending fixes for the ones in headers that get included in a lot of places. There are good reasons for building being able to build specific drivers or directories with W=2, but it's less helpful if there are many identical warnings.
Arnd
On Mon, 26 Oct 2020 20:03:39 +0100, Arnd Bergmann wrote:
On Mon, Oct 26, 2020 at 6:03 PM Takashi Iwai tiwai@suse.de wrote:
On Mon, 26 Oct 2020 17:52:18 +0100, Arnd Bergmann wrote:
From: Arnd Bergmann arnd@arndb.de
When building with W=2, there are lots of warnings about the snd_kcontrol_new name field being an array of 'unsigned char' but initialized to a string:
include/sound/soc.h:93:48: warning: pointer targets in initialization of 'const unsigned char *' from 'char *' differ in signedness [-Wpointer-sign]
Make it a regular 'char *' to avoid flooding the build log with this.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Arnd Bergmann arnd@arndb.de
I'm fine to apply this, but I thought we agreed to ignore pointer signedness intentionally? There are lots of such places and we were fed up in the past when gcc complained a lot about those...
I'm only sending fixes for the ones in headers that get included in a lot of places. There are good reasons for building being able to build specific drivers or directories with W=2, but it's less helpful if there are many identical warnings.
OK, now I applied the patch. Thanks!
Takashi
participants (2)
-
Arnd Bergmann
-
Takashi Iwai