[alsa-devel] [PATCH] ASoC: Improve error reporting in Speyside WM8962 driver
![](https://secure.gravatar.com/avatar/d28dfe03ea754ea1153719f4ced12649.jpg?s=120&d=mm&r=g)
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com --- sound/soc/samsung/speyside_wm8962.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/sound/soc/samsung/speyside_wm8962.c b/sound/soc/samsung/speyside_wm8962.c index c0ba0bf..55233e8 100644 --- a/sound/soc/samsung/speyside_wm8962.c +++ b/sound/soc/samsung/speyside_wm8962.c @@ -30,14 +30,16 @@ static int speyside_wm8962_set_bias_level(struct snd_soc_card *card, WM8962_FLL_MCLK, 32768, 44100 * 256); if (ret < 0) - pr_err("Failed to start FLL\n"); + pr_err("Failed to start FLL: %d\n");
ret = snd_soc_dai_set_sysclk(codec_dai, WM8962_SYSCLK_FLL, 44100 * 256, SND_SOC_CLOCK_IN); - if (ret < 0) + if (ret < 0) { + pr_err("Failed to set SYSCLK: %d\n"); return ret; + } } break;
@@ -59,13 +61,15 @@ static int speyside_wm8962_set_bias_level_post(struct snd_soc_card *card, case SND_SOC_BIAS_STANDBY: ret = snd_soc_dai_set_sysclk(codec_dai, WM8962_SYSCLK_MCLK, 32768, SND_SOC_CLOCK_IN); - if (ret < 0) + if (ret < 0) { + pr_err("Failed to switch away from FLL: %d\n", ret); return ret; + }
ret = snd_soc_dai_set_pll(codec_dai, WM8962_FLL, 0, 0, 0); if (ret < 0) { - pr_err("Failed to stop FLL\n"); + pr_err("Failed to stop FLL: %d\n", ret); return ret; } break;
![](https://secure.gravatar.com/avatar/d28dfe03ea754ea1153719f4ced12649.jpg?s=120&d=mm&r=g)
On Fri, Jul 01, 2011 at 12:56:17AM +0800, Lu Guanqun wrote:
On Thu, Jun 30, 2011 at 05:18:51AM +0800, Mark Brown wrote:
if (ret < 0)
pr_err("Failed to start FLL\n");
pr_err("Failed to start FLL: %d\n");
missed 'ret' here? :)
Fixed locally, Liam I'll not bother reposting if you're otherwise OK?
![](https://secure.gravatar.com/avatar/acb6dd942d6ee829a354f51f218f82f8.jpg?s=120&d=mm&r=g)
On Fri, Jul 01, 2011 at 02:02:28AM +0800, Mark Brown wrote:
On Fri, Jul 01, 2011 at 12:56:17AM +0800, Lu Guanqun wrote:
On Thu, Jun 30, 2011 at 05:18:51AM +0800, Mark Brown wrote:
if (ret < 0)
pr_err("Failed to start FLL\n");
pr_err("Failed to start FLL: %d\n");
missed 'ret' here? :)
Fixed locally, Liam I'll not bother reposting if you're otherwise OK?
I just randomly read the patches and spotted it... Sorry for the noise. :)
![](https://secure.gravatar.com/avatar/e41b8238bfaf058ba740f2a0dd1579d4.jpg?s=120&d=mm&r=g)
On 30/06/11 19:02, Mark Brown wrote:
On Fri, Jul 01, 2011 at 12:56:17AM +0800, Lu Guanqun wrote:
On Thu, Jun 30, 2011 at 05:18:51AM +0800, Mark Brown wrote:
if (ret < 0)
pr_err("Failed to start FLL\n");
pr_err("Failed to start FLL: %d\n");
missed 'ret' here? :)
Fixed locally, Liam I'll not bother reposting if you're otherwise OK?
I'm OK.
Liam
participants (3)
-
Liam Girdwood
-
Lu Guanqun
-
Mark Brown