[PATCH] ASoC: dt-bindings: Add samsung,abox-generic document
Add soundcard bindings for the abox generic of exynus automotive.
Signed-off-by: ew kim ew.kim@samsung.com --- .../bindings/sound/samsung,abox-generic.yaml | 77 +++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml
diff --git a/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml b/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml new file mode 100644 index 000000000000..bf641a197903 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml @@ -0,0 +1,77 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/samsung/abox-generic.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Samsung Exynos Automotive Abox Generic + +maintainers: + - name: Eunwoo Kim + email: ew.kim@samsung.com + +description: | + Samsung Exynos Automotive Abox Generic core node. + + This node represents the generic Abox controller which manages + various Abox sub-drivers and acts as a hub connecting them to + SoC-level audio drivers. It provides PCM playback and capture + configuration, as well as dummy I2S backend handling, enabling + integration between Abox IP blocks and the SoC audio subsystem. + + Typically, this node is used to initialize and configure playback, + capture, and routing between the Abox and other SoC audio components. + +properties: + compatible: + const: samsung,abox_generic + + samsung,num-of-pcm_playback: + description: Number of PCM playback instances. + $ref: /schemas/types.yaml#/definitions/uint32 + + samsung,num-of-pcm_capture: + description: Number of PCM capture instances. + $ref: /schemas/types.yaml#/definitions/uint32 + + samsung,num-of-i2s-dummy-backend: + description: Number of dummy I2S backend instances. + $ref: /schemas/types.yaml#/definitions/uint32 + + status: + description: Availability status. + enum: [ "okay", "disabled" ] + + '#address-cells': + description: Number of address cells in the node. + const: 2 + + '#size-cells': + description: Number of size cells in the node. + const: 1 + + ranges: + description: Standard `ranges` property for bus address mapping. + type: object + +required: + - compatible + - samsung,num-of-pcm_playback + - samsung,num-of-pcm_capture + - samsung,num-of-i2s-dummy-backend + +additionalProperties: false + +examples: + - | + abox_generic: abox_generic@generic { + compatible = "samsung,abox_generic"; + samsung,num-of-pcm_playback = <32>; + samsung,num-of-pcm_capture = <32>; + samsung,num-of-i2s-dummy-backend = <5>; + status = "disabled"; + #address-cells = <2>; + #size-cells = <1>; + ranges; + }; +
On Wed, 09 Jul 2025 09:12:39 +0900, ew kim wrote:
Add soundcard bindings for the abox generic of exynus automotive.
Signed-off-by: ew kim ew.kim@samsung.com
.../bindings/sound/samsung,abox-generic.yaml | 77 +++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors: ./Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml:4:6: [error] string value is redundantly quoted with any quotes (quoted-strings) ./Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml:5:10: [error] string value is redundantly quoted with any quotes (quoted-strings) ./Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml:43:13: [error] string value is redundantly quoted with any quotes (quoted-strings) ./Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml:43:21: [error] string value is redundantly quoted with any quotes (quoted-strings)
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml: maintainers:0: {'name': 'Eunwoo Kim', 'email': 'ew.kim@samsung.com'} is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/base.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml: properties:ranges: 'anyOf' conditional failed, one must be fixed: 'maxItems' is a required property hint: Only "maxItems" is required for a single entry if there are no constraints defined for the values. 'type' is not one of ['maxItems', 'description', 'deprecated'] hint: Only "maxItems" is required for a single entry if there are no constraints defined for the values. Additional properties are not allowed ('type' was unexpected) hint: Arrays must be described with a combination of minItems/maxItems/items 'type' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf'] hint: cell array properties must define how many entries and what the entries are when there is more than one entry. from schema $id: http://devicetree.org/meta-schemas/core.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/soc/samsung/abox-generic.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml Documentation/devicetree/bindings/sound/samsung,abox-generic.example.dts:26.11-18: Warning (ranges_format): /example-0/abox_generic@generic:ranges: empty "ranges" property but its #address-cells (2) differs from /example-0 (1) Documentation/devicetree/bindings/sound/samsung,abox-generic.example.dts:18.44-27.11: Warning (unit_address_vs_reg): /example-0/abox_generic@generic: node has a unit name, but no reg or ranges property /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/samsung,abox-generic.example.dtb: abox_generic@generic (samsung,abox_generic): ranges: True is not of type 'object' from schema $id: http://devicetree.org/schemas/soc/samsung/abox-generic.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/2025070900123...
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 09/07/2025 02:12, ew kim wrote:
Add soundcard bindings for the abox generic of exynus automotive.
This wasn't ever tested, so very short review. You have typos here and there. But more important - this should not be a "generic" thing, but binding for your sound card.
What's more important, there is no user of it, so anyway this cannot be accepted as it makes no sense without user.
Signed-off-by: ew kim ew.kim@samsung.com
.../bindings/sound/samsung,abox-generic.yaml | 77 +++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml
diff --git a/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml b/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml new file mode 100644 index 000000000000..bf641a197903 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml @@ -0,0 +1,77 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/samsung/abox-generic.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
But the quality of the patch and lack of testing makes me thinking if you could not get some help inside Samsung in posting a proper patch?
Best regards, Krzysztof
participants (3)
-
ew kim -
Krzysztof Kozlowski -
Rob Herring (Arm)