[alsa-devel] Debugged improper setting of PLL fields in WM8580 driver
Bug was caught while trying to use WM8580 as I2S master on SMDK. Symptoms were lesser LRCLK read by CRO(41.02 instead of 44.1 KHz) Solved by referring to WM8580A manual and setting mask value correctly and making the code to not touch 'reserved' bits of PLL4 register.
Signed-off-by: Jassi jassi.brar@samsung.com
diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c index d547347..6bded8c 100644 --- a/sound/soc/codecs/wm8580.c +++ b/sound/soc/codecs/wm8580.c @@ -458,12 +458,12 @@ static int wm8580_set_dai_pll(struct snd_soc_dai *codec_dai, return 0;
snd_soc_write(codec, WM8580_PLLA1 + offset, pll_div.k & 0x1ff); - snd_soc_write(codec, WM8580_PLLA2 + offset, (pll_div.k >> 9) & 0xff); + snd_soc_write(codec, WM8580_PLLA2 + offset, (pll_div.k >> 9) & 0x1ff); snd_soc_write(codec, WM8580_PLLA3 + offset, (pll_div.k >> 18 & 0xf) | (pll_div.n << 4));
reg = snd_soc_read(codec, WM8580_PLLA4 + offset); - reg &= ~0x3f; + reg &= ~0x1b; reg |= pll_div.prescale | pll_div.postscale << 1 | pll_div.freqmode << 3;
On Tue, Sep 01, 2009 at 11:35:08AM +0900, jassi brar wrote:
Bug was caught while trying to use WM8580 as I2S master on SMDK. Symptoms were lesser LRCLK read by CRO(41.02 instead of 44.1 KHz) Solved by referring to WM8580A manual and setting mask value correctly and making the code to not touch 'reserved' bits of PLL4 register.
Signed-off-by: Jassi jassi.brar@samsung.com
I've applied this, thanks. However, I had to hand hack the patch to apply it since it was broken in several ways - your MUA had word wrapped it and there was a missing line at the end of the patch. Please try to avoid these issues, hand fixups are time consuming and only possible for very small patches. Also, it looks like you used the output of git show for the patch - doing that corrupts the commit message by indenting it, you should use git format-patch for e-mail.
I'd suggest looking into using git format-patch and git send-email to send patches, they will get most things right for you. The GMail web interface definately doesn't work for this, if that is all you have access to due to firewall restrictions you'll need to use an attachment rather than sending the patch in the body of the e-mail as normal. If your firewall is a bit more open then GMail supports sending via SMTP which allows you to use git send-email to avoid the word wrapping.
participants (2)
-
jassi brar -
Mark Brown