[alsa-devel] [PATCH] fix one memory leak in sound jack
Signed-off-by: Lu Guanqun guanqun.lu@intel.com --- sound/core/jack.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/core/jack.c b/sound/core/jack.c index 4902ae5..53b53e9 100644 --- a/sound/core/jack.c +++ b/sound/core/jack.c @@ -141,6 +141,7 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
fail_input: input_free_device(jack->input_dev); + kfree(jack->id); kfree(jack); return err; }
Guanqun, it helps to point out the commit that first introduced the problem.
Reviewed-by: Wu Fengguang fengguang.wu@intel.com
On Mon, Feb 21, 2011 at 01:45:04PM +0800, Lu Guanqun wrote:
Signed-off-by: Lu Guanqun guanqun.lu@intel.com
sound/core/jack.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/core/jack.c b/sound/core/jack.c index 4902ae5..53b53e9 100644 --- a/sound/core/jack.c +++ b/sound/core/jack.c @@ -141,6 +141,7 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
fail_input: input_free_device(jack->input_dev);
- kfree(jack->id); kfree(jack); return err;
}
1.7.2.3
At Mon, 21 Feb 2011 13:45:04 +0800, Lu Guanqun wrote:
Signed-off-by: Lu Guanqun guanqun.lu@intel.com
Applied now. Thanks.
Takashi
sound/core/jack.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/core/jack.c b/sound/core/jack.c index 4902ae5..53b53e9 100644 --- a/sound/core/jack.c +++ b/sound/core/jack.c @@ -141,6 +141,7 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
fail_input: input_free_device(jack->input_dev);
- kfree(jack->id); kfree(jack); return err;
}
1.7.2.3
participants (3)
-
Lu Guanqun -
Takashi Iwai -
Wu Fengguang