Re: [alsa-devel] [PATCH v2 6/6] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c
![](https://secure.gravatar.com/avatar/d1655deafb11e717d2e378ef44f00143.jpg?s=120&d=mm&r=g)
Hi!
Thanks for the patch set.
Would you mind fixing also the following issues raised by checkpatch.pl?:
WARNING: Missing a blank line after declarations #376: FILE: drivers/platform/x86/dell-wmi-led.c:64:
- struct bios_args args;
...
The fixes could be placed in an incremental patch after this one.
Anyway, move itself is ok (and the checkpatch issues are not that serious anyway.)
Thanks,
Acked-by: Pavel Machek pavel@ucw.cz
![](https://secure.gravatar.com/avatar/5ee5918d6ee3618ec173b170fee3668a.jpg?s=120&d=mm&r=g)
On Tuesday 17 January 2017 12:08:09 Pavel Machek wrote:
Hi!
Thanks for the patch set.
Would you mind fixing also the following issues raised by checkpatch.pl?:
WARNING: Missing a blank line after declarations #376: FILE: drivers/platform/x86/dell-wmi-led.c:64:
- struct bios_args args;
...
The fixes could be placed in an incremental patch after this one.
Anyway, move itself is ok (and the checkpatch issues are not that serious anyway.)
Thanks,
Acked-by: Pavel Machek pavel@ucw.cz
Yes, this patch does not change code, just move one file to other location. You can add my Reviewed-by.
participants (2)
-
Pali Rohár
-
Pavel Machek