[alsa-devel] [PATCH] ASoC DAPM switching for reentrant codec paths.
This patch fixes an issue whereby power was applied to any inactive analog path that would leave and reenter a codec (e.g. ACOP -> ACIN on WM8753). This change now checks for such paths and DAPM will power them down when not in use.
Signed-off-by: Seth Forshee seth.forshee@gmail.com Signed-off-by: Liam Girdwood lg@opensource.wolfsonmicro.com
At Mon, 16 Apr 2007 13:19:06 +0100, Liam Girdwood wrote:
This patch fixes an issue whereby power was applied to any inactive analog path that would leave and reenter a codec (e.g. ACOP -> ACIN on WM8753). This change now checks for such paths and DAPM will power them down when not in use.
Looks like the current ML server strips attachments. I don't know whether all kind of attachments are stripped, but, at least I can't see your patch now...
Thus, when you submit patches, please post it directly to me and add Cc to alsa-devel to be sure.
thanks,
Takashi
On Mon, 2007-04-16 at 14:40 +0200, Takashi Iwai wrote:
At Mon, 16 Apr 2007 13:19:06 +0100, Liam Girdwood wrote:
This patch fixes an issue whereby power was applied to any inactive analog path that would leave and reenter a codec (e.g. ACOP -> ACIN on WM8753). This change now checks for such paths and DAPM will power them down when not in use.
Looks like the current ML server strips attachments. I don't know whether all kind of attachments are stripped, but, at least I can't see your patch now...
Thus, when you submit patches, please post it directly to me and add Cc to alsa-devel to be sure.
Np, attached.
Btw, I have a ASoC git tree here :-
http://opensource.wolfsonmicro.com/cgi-bin/gitweb/gitweb.cgi?p=linux-2.6-aso...
Would pulling from this tree be acceptable in the future. (e.g after the next merge window - as I need to cleanup some branches) This would save me some time creating patches.
Liam
At Mon, 16 Apr 2007 14:16:11 +0100, Liam Girdwood wrote:
On Mon, 2007-04-16 at 14:40 +0200, Takashi Iwai wrote:
At Mon, 16 Apr 2007 13:19:06 +0100, Liam Girdwood wrote:
This patch fixes an issue whereby power was applied to any inactive analog path that would leave and reenter a codec (e.g. ACOP -> ACIN on WM8753). This change now checks for such paths and DAPM will power them down when not in use.
Looks like the current ML server strips attachments. I don't know whether all kind of attachments are stripped, but, at least I can't see your patch now...
Thus, when you submit patches, please post it directly to me and add Cc to alsa-devel to be sure.
Np, attached.
Btw, I have a ASoC git tree here :-
http://opensource.wolfsonmicro.com/cgi-bin/gitweb/gitweb.cgi?p=linux-2.6-aso...
Would pulling from this tree be acceptable in the future. (e.g after the next merge window - as I need to cleanup some branches) This would save me some time creating patches.
Pulling doesn't work so well between git and HG repos :) Also, pulling skips reviews, so it's not suitable in our case.
I'll check the patches now.
thanks,
Takashi
At Mon, 16 Apr 2007 15:33:58 +0200, I wrote:
At Mon, 16 Apr 2007 14:16:11 +0100, Liam Girdwood wrote:
On Mon, 2007-04-16 at 14:40 +0200, Takashi Iwai wrote:
At Mon, 16 Apr 2007 13:19:06 +0100, Liam Girdwood wrote:
This patch fixes an issue whereby power was applied to any inactive analog path that would leave and reenter a codec (e.g. ACOP -> ACIN on WM8753). This change now checks for such paths and DAPM will power them down when not in use.
Looks like the current ML server strips attachments. I don't know whether all kind of attachments are stripped, but, at least I can't see your patch now...
Thus, when you submit patches, please post it directly to me and add Cc to alsa-devel to be sure.
Np, attached.
Btw, I have a ASoC git tree here :-
http://opensource.wolfsonmicro.com/cgi-bin/gitweb/gitweb.cgi?p=linux-2.6-aso...
Would pulling from this tree be acceptable in the future. (e.g after the next merge window - as I need to cleanup some branches) This would save me some time creating patches.
Pulling doesn't work so well between git and HG repos :) Also, pulling skips reviews, so it's not suitable in our case.
I'll check the patches now.
They look fine. Applied to HG tree now.
Thanks,
Takashi
participants (2)
-
Liam Girdwood -
Takashi Iwai