[alsa-devel] [PATCH] ASoC: jack: remove unused variable in snd_soc_jack_report()
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
The variable oldstatus is initialized but never used otherwise, so remove the unused variable.
dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn --- sound/soc/soc-jack.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index fa0fd8d..933eb25 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c @@ -66,7 +66,6 @@ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask) struct snd_soc_dapm_context *dapm; struct snd_soc_jack_pin *pin; int enable; - int oldstatus;
trace_snd_soc_jack_report(jack, mask, status);
@@ -78,8 +77,6 @@ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask)
mutex_lock(&jack->mutex);
- oldstatus = jack->status; - jack->status &= ~mask; jack->status |= status & mask;
On Thu, Oct 18, 2012 at 10:49:19PM +0800, Wei Yongjun wrote:
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
The variable oldstatus is initialized but never used otherwise, so remove the unused variable.
Applied, thanks. However for changes like this you should really consider in your changelog why the variable is unused - is the bug that the result is ignored or that it is needlessly generated?
participants (2)
-
Mark Brown
-
Wei Yongjun