[PATCH v7 1/2] ASoC: rt5575: Add the codec driver for the ALC5575
The ALC5575 integrates an audio DSP that typically loads its firmware from an external flash via its own SPI host interface. In certain hardware configurations, the firmware can alternatively be loaded through the SPI client interface. The driver provides basic mute and volume control functions. When the SPI client interface is enabled, firmware loading is handled by the SPI driver.
Signed-off-by: Oder Chiou oder_chiou@realtek.com --- sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 4 + sound/soc/codecs/rt5575-spi.c | 86 ++++++++ sound/soc/codecs/rt5575-spi.h | 16 ++ sound/soc/codecs/rt5575.c | 370 ++++++++++++++++++++++++++++++++++ sound/soc/codecs/rt5575.h | 54 +++++ 6 files changed, 540 insertions(+) create mode 100644 sound/soc/codecs/rt5575-spi.c create mode 100644 sound/soc/codecs/rt5575-spi.h create mode 100644 sound/soc/codecs/rt5575.c create mode 100644 sound/soc/codecs/rt5575.h
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index a0dfef57200c..a3ea5febd1e0 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -211,6 +211,7 @@ config SND_SOC_ALL_CODECS imply SND_SOC_RT1305 imply SND_SOC_RT1308 imply SND_SOC_RT5514 + imply SND_SOC_RT5575 imply SND_SOC_RT5616 imply SND_SOC_RT5631 imply SND_SOC_RT5640 @@ -1767,6 +1768,15 @@ config SND_SOC_RT5514_SPI_BUILTIN bool # force RT5514_SPI to be built-in to avoid link errors default SND_SOC_RT5514=y && SND_SOC_RT5514_SPI=m
+config SND_SOC_RT5575 + tristate "Realtek ALC5575 Codec - I2C" + depends on I2C + +config SND_SOC_RT5575_SPI + tristate "Realtek ALC5575 Codec - SPI" + depends on SPI_MASTER + select SND_SOC_RT5575 + config SND_SOC_RT5616 tristate "Realtek RT5616 CODEC" depends on I2C diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile index 39138d96a720..82f660cbe8ec 100644 --- a/sound/soc/codecs/Makefile +++ b/sound/soc/codecs/Makefile @@ -252,6 +252,8 @@ snd-soc-rt286-y := rt286.o snd-soc-rt298-y := rt298.o snd-soc-rt5514-y := rt5514.o snd-soc-rt5514-spi-y := rt5514-spi.o +snd-soc-rt5575-y := rt5575.o +snd-soc-rt5575-spi-y := rt5575-spi.o snd-soc-rt5616-y := rt5616.o snd-soc-rt5631-y := rt5631.o snd-soc-rt5640-y := rt5640.o @@ -684,6 +686,8 @@ obj-$(CONFIG_SND_SOC_RT298) += snd-soc-rt298.o obj-$(CONFIG_SND_SOC_RT5514) += snd-soc-rt5514.o obj-$(CONFIG_SND_SOC_RT5514_SPI) += snd-soc-rt5514-spi.o obj-$(CONFIG_SND_SOC_RT5514_SPI_BUILTIN) += snd-soc-rt5514-spi.o +obj-$(CONFIG_SND_SOC_RT5575) += snd-soc-rt5575.o +obj-$(CONFIG_SND_SOC_RT5575_SPI) += snd-soc-rt5575-spi.o obj-$(CONFIG_SND_SOC_RT5616) += snd-soc-rt5616.o obj-$(CONFIG_SND_SOC_RT5631) += snd-soc-rt5631.o obj-$(CONFIG_SND_SOC_RT5640) += snd-soc-rt5640.o diff --git a/sound/soc/codecs/rt5575-spi.c b/sound/soc/codecs/rt5575-spi.c new file mode 100644 index 000000000000..9dbc8170fb76 --- /dev/null +++ b/sound/soc/codecs/rt5575-spi.c @@ -0,0 +1,86 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * rt5575-spi.c -- ALC5575 SPI driver + * + * Copyright(c) 2025 Realtek Semiconductor Corp. + * + */ + +#include <linux/of.h> +#include <linux/spi/spi.h> + +#include "rt5575-spi.h" + +#define RT5575_SPI_CMD_BURST_WRITE 5 +#define RT5575_SPI_BUF_LEN 240 + +struct rt5575_spi_burst_write { + u8 cmd; + u32 addr; + u8 data[RT5575_SPI_BUF_LEN]; + u8 dummy; +} __packed; + +bool rt5575_spi_ready; +static struct spi_device *rt5575_spi; + +/** + * rt5575_spi_burst_write - Write data to SPI by rt5575 address. + * @addr: Start address. + * @txbuf: Data buffer for writing. + * @len: Data length. + * + */ +int rt5575_spi_burst_write(u32 addr, const u8 *txbuf, size_t len) +{ + struct rt5575_spi_burst_write buf = { + .cmd = RT5575_SPI_CMD_BURST_WRITE + }; + unsigned int end, offset = 0; + + while (offset < len) { + if (offset + RT5575_SPI_BUF_LEN <= len) + end = RT5575_SPI_BUF_LEN; + else + end = len % RT5575_SPI_BUF_LEN; + + buf.addr = cpu_to_le32(addr + offset); + + memcpy(&buf.data, &txbuf[offset], end); + + spi_write(rt5575_spi, &buf, sizeof(buf)); + + offset += RT5575_SPI_BUF_LEN; + } + + return 0; +} +EXPORT_SYMBOL_GPL(rt5575_spi_burst_write); + +static int rt5575_spi_probe(struct spi_device *spi) +{ + rt5575_spi = spi; + + rt5575_spi_ready = true; + + return 0; +} + +static const struct of_device_id rt5575_of_match[] = { + { .compatible = "realtek,rt5575" }, + { } +}; +MODULE_DEVICE_TABLE(of, rt5575_of_match); + +static struct spi_driver rt5575_spi_driver = { + .driver = { + .name = "rt5575", + .of_match_table = of_match_ptr(rt5575_of_match), + }, + .probe = rt5575_spi_probe, +}; +module_spi_driver(rt5575_spi_driver); + +MODULE_DESCRIPTION("ALC5575 SPI driver"); +MODULE_AUTHOR("Oder Chiou oder_chiou@realtek.com"); +MODULE_LICENSE("GPL"); diff --git a/sound/soc/codecs/rt5575-spi.h b/sound/soc/codecs/rt5575-spi.h new file mode 100644 index 000000000000..cafe49a7ecc2 --- /dev/null +++ b/sound/soc/codecs/rt5575-spi.h @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * rt5575-spi.h -- ALC5575 SPI driver + * + * Copyright(c) 2025 Realtek Semiconductor Corp. + * + */ + +#ifndef __RT5575_SPI_H__ +#define __RT5575_SPI_H__ + +extern bool rt5575_spi_ready; + +int rt5575_spi_burst_write(u32 addr, const u8 *txbuf, size_t len); + +#endif /* __RT5575_SPI_H__ */ diff --git a/sound/soc/codecs/rt5575.c b/sound/soc/codecs/rt5575.c new file mode 100644 index 000000000000..58508d643273 --- /dev/null +++ b/sound/soc/codecs/rt5575.c @@ -0,0 +1,370 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * rt5575.c -- ALC5575 ALSA SoC audio component driver + * + * Copyright(c) 2025 Realtek Semiconductor Corp. + * + */ + +#include <linux/firmware.h> +#include <linux/i2c.h> +#include <sound/soc.h> +#include <sound/tlv.h> + +#include "rt5575.h" +#if IS_ENABLED(CONFIG_SND_SOC_RT5575_SPI) +#include "rt5575-spi.h" +#endif + +static bool rt5575_readable_register(struct device *dev, unsigned int reg) +{ + switch (reg) { + case RT5575_ID: + case RT5575_ID_1: + case RT5575_MIXL_VOL: + case RT5575_MIXR_VOL: + case RT5575_PROMPT_VOL: + case RT5575_SPK01_VOL: + case RT5575_SPK23_VOL: + case RT5575_MIC1_VOL: + case RT5575_MIC2_VOL: + case RT5575_WNC_CTRL: + case RT5575_MODE_CTRL: + case RT5575_I2S_RATE_CTRL: + case RT5575_SLEEP_CTRL: + case RT5575_ALG_BYPASS_CTRL: + case RT5575_PINMUX_CTRL_2: + case RT5575_GPIO_CTRL_1: + case RT5575_DSP_BUS_CTRL: + case RT5575_SW_INT: + case RT5575_DSP_BOOT_ERR: + case RT5575_DSP_READY: + case RT5575_DSP_CMD_ADDR: + case RT5575_EFUSE_DATA_2: + case RT5575_EFUSE_DATA_3: + return true; + default: + return false; + } +} + +static const DECLARE_TLV_DB_SCALE(ob_tlv, -9525, 75, 0); + +#if IS_ENABLED(CONFIG_SND_SOC_RT5575_SPI) +static void rt5575_fw_load_by_spi(const struct firmware *fw, void *context) +{ + struct rt5575_priv *rt5575 = context; + struct i2c_client *i2c = rt5575->i2c; + const struct firmware *firmware; + static const char * const fw_path[] = { + "realtek/rt5575/rt5575_fw2.bin", + "realtek/rt5575/rt5575_fw3.bin", + "realtek/rt5575/rt5575_fw4.bin" + }; + static const u32 fw_addr[] = { 0x5f600000, 0x5f7fe000, 0x5f7ff000 }; + int i, ret; + + regmap_write(rt5575->dsp_regmap, 0xfafafafa, 0x00000004); + regmap_write(rt5575->dsp_regmap, 0x18008064, 0x00000000); + regmap_write(rt5575->dsp_regmap, 0x18008068, 0x0002ffff); + + rt5575_spi_burst_write(0x5f400000, fw->data, fw->size); + release_firmware(fw); + + for (i = 0; i < ARRAY_SIZE(fw_addr); i++) { + ret = request_firmware(&firmware, fw_path[i], &i2c->dev); + if (!ret) { + rt5575_spi_burst_write(fw_addr[i], firmware->data, firmware->size); + release_firmware(firmware); + } else { + dev_err(&i2c->dev, "Request firmware failure: %d\n", ret); + return; + } + } + + regmap_write(rt5575->dsp_regmap, 0x18000000, 0x00000000); + + regmap_update_bits(rt5575->regmap, RT5575_SW_INT, 1, 1); + + regmap_read_poll_timeout(rt5575->regmap, RT5575_SW_INT, ret, !ret, 100000, 10000000); + + if (ret) + dev_err(&i2c->dev, "Run firmware failure: %d\n", ret); +} +#endif + +static const struct snd_kcontrol_new rt5575_snd_controls[] = { + SOC_DOUBLE("Speaker CH-01 Playback Switch", RT5575_SPK01_VOL, 31, 15, 1, 1), + SOC_DOUBLE_TLV("Speaker CH-01 Playback Volume", RT5575_SPK01_VOL, 17, 1, 167, 0, ob_tlv), + SOC_DOUBLE("Speaker CH-23 Playback Switch", RT5575_SPK23_VOL, 31, 15, 1, 1), + SOC_DOUBLE_TLV("Speaker CH-23 Playback Volume", RT5575_SPK23_VOL, 17, 1, 167, 0, ob_tlv), + SOC_DOUBLE("Mic1 Capture Switch", RT5575_MIC1_VOL, 31, 15, 1, 1), + SOC_DOUBLE_TLV("Mic1 Capture Volume", RT5575_MIC1_VOL, 17, 1, 167, 0, ob_tlv), + SOC_DOUBLE("Mic2 Capture Switch", RT5575_MIC2_VOL, 31, 15, 1, 1), + SOC_DOUBLE_TLV("Mic2 Capture Volume", RT5575_MIC2_VOL, 17, 1, 167, 0, ob_tlv), + SOC_DOUBLE_R("Mix Playback Switch", RT5575_MIXL_VOL, RT5575_MIXR_VOL, 31, 1, 1), + SOC_DOUBLE_R_TLV("Mix Playback Volume", RT5575_MIXL_VOL, RT5575_MIXR_VOL, 1, 127, 0, + ob_tlv), + SOC_DOUBLE("Prompt Playback Switch", RT5575_PROMPT_VOL, 31, 15, 1, 1), + SOC_DOUBLE_TLV("Prompt Playback Volume", RT5575_PROMPT_VOL, 17, 1, 167, 0, ob_tlv), +}; + +static const struct snd_soc_dapm_widget rt5575_dapm_widgets[] = { + SND_SOC_DAPM_AIF_IN("AIF1RX", "AIF1 Playback", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT("AIF1TX", "AIF1 Capture", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_IN("AIF2RX", "AIF2 Playback", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT("AIF2TX", "AIF2 Capture", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_IN("AIF3RX", "AIF3 Playback", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT("AIF3TX", "AIF3 Capture", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_IN("AIF4RX", "AIF4 Playback", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT("AIF4TX", "AIF4 Capture", 0, SND_SOC_NOPM, 0, 0), + + SND_SOC_DAPM_INPUT("INPUT"), + SND_SOC_DAPM_OUTPUT("OUTPUT"), +}; + +static const struct snd_soc_dapm_route rt5575_dapm_routes[] = { + { "AIF1TX", NULL, "INPUT" }, + { "AIF2TX", NULL, "INPUT" }, + { "AIF3TX", NULL, "INPUT" }, + { "AIF4TX", NULL, "INPUT" }, + { "OUTPUT", NULL, "AIF1RX" }, + { "OUTPUT", NULL, "AIF2RX" }, + { "OUTPUT", NULL, "AIF3RX" }, + { "OUTPUT", NULL, "AIF4RX" }, +}; + +static long long rt5575_get_priv_id(struct rt5575_priv *rt5575) +{ + int priv_id_low, priv_id_high; + + regmap_write(rt5575->regmap, RT5575_EFUSE_PID, 0xa0000000); + regmap_read(rt5575->regmap, RT5575_EFUSE_DATA_2, &priv_id_low); + regmap_read(rt5575->regmap, RT5575_EFUSE_DATA_3, &priv_id_high); + regmap_write(rt5575->regmap, RT5575_EFUSE_PID, 0); + + return ((long long)priv_id_high << 32) | (long long)priv_id_low; +} + +static int rt5575_probe(struct snd_soc_component *component) +{ + struct rt5575_priv *rt5575 = snd_soc_component_get_drvdata(component); + + rt5575->component = component; + + dev_info(component->dev, "Private ID: %llx\n", rt5575_get_priv_id(rt5575)); + +#if IS_ENABLED(CONFIG_SND_SOC_RT5575_SPI) + request_firmware_nowait(THIS_MODULE, FW_ACTION_UEVENT, "realtek/rt5575/rt5575_fw1.bin", + component->dev, GFP_KERNEL, rt5575, rt5575_fw_load_by_spi); +#endif + + return 0; +} + +#define RT5575_STEREO_RATES SNDRV_PCM_RATE_8000_192000 +#define RT5575_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \ + SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S8 | \ + SNDRV_PCM_FMTBIT_S32_LE) + +static struct snd_soc_dai_driver rt5575_dai[] = { + { + .name = "rt5575-aif1", + .id = RT5575_AIF1, + .playback = { + .stream_name = "AIF1 Playback", + .channels_min = 1, + .channels_max = 8, + .rates = RT5575_STEREO_RATES, + .formats = RT5575_FORMATS, + }, + .capture = { + .stream_name = "AIF1 Capture", + .channels_min = 1, + .channels_max = 8, + .rates = RT5575_STEREO_RATES, + .formats = RT5575_FORMATS, + }, + }, + { + .name = "rt5575-aif2", + .id = RT5575_AIF2, + .playback = { + .stream_name = "AIF2 Playback", + .channels_min = 1, + .channels_max = 8, + .rates = RT5575_STEREO_RATES, + .formats = RT5575_FORMATS, + }, + .capture = { + .stream_name = "AIF2 Capture", + .channels_min = 1, + .channels_max = 8, + .rates = RT5575_STEREO_RATES, + .formats = RT5575_FORMATS, + }, + }, + { + .name = "rt5575-aif3", + .id = RT5575_AIF3, + .playback = { + .stream_name = "AIF3 Playback", + .channels_min = 1, + .channels_max = 8, + .rates = RT5575_STEREO_RATES, + .formats = RT5575_FORMATS, + }, + .capture = { + .stream_name = "AIF3 Capture", + .channels_min = 1, + .channels_max = 8, + .rates = RT5575_STEREO_RATES, + .formats = RT5575_FORMATS, + }, + }, + { + .name = "rt5575-aif4", + .id = RT5575_AIF4, + .playback = { + .stream_name = "AIF4 Playback", + .channels_min = 1, + .channels_max = 8, + .rates = RT5575_STEREO_RATES, + .formats = RT5575_FORMATS, + }, + .capture = { + .stream_name = "AIF4 Capture", + .channels_min = 1, + .channels_max = 8, + .rates = RT5575_STEREO_RATES, + .formats = RT5575_FORMATS, + }, + }, +}; + +static const struct snd_soc_component_driver rt5575_soc_component_dev = { + .probe = rt5575_probe, + .controls = rt5575_snd_controls, + .num_controls = ARRAY_SIZE(rt5575_snd_controls), + .dapm_widgets = rt5575_dapm_widgets, + .num_dapm_widgets = ARRAY_SIZE(rt5575_dapm_widgets), + .dapm_routes = rt5575_dapm_routes, + .num_dapm_routes = ARRAY_SIZE(rt5575_dapm_routes), + .use_pmdown_time = 1, + .endianness = 1, +}; + +static const struct regmap_config rt5575_dsp_regmap = { + .name = "dsp", + .reg_bits = 32, + .val_bits = 32, + .reg_stride = 2, +}; + +static int rt5575_i2c_read(void *context, unsigned int reg, unsigned int *val) +{ + struct i2c_client *client = context; + struct rt5575_priv *rt5575 = i2c_get_clientdata(client); + + regmap_read(rt5575->dsp_regmap, reg | RT5575_DSP_MAPPING, val); + + return 0; +} + +static int rt5575_i2c_write(void *context, unsigned int reg, unsigned int val) +{ + struct i2c_client *client = context; + struct rt5575_priv *rt5575 = i2c_get_clientdata(client); + + regmap_write(rt5575->dsp_regmap, reg | RT5575_DSP_MAPPING, val); + + return 0; +} + +static const struct regmap_config rt5575_regmap = { + .reg_bits = 16, + .val_bits = 32, + .reg_stride = 4, + .max_register = 0xfffc, + .readable_reg = rt5575_readable_register, + .reg_read = rt5575_i2c_read, + .reg_write = rt5575_i2c_write, + .use_single_read = true, + .use_single_write = true, +}; + +static const struct i2c_device_id rt5575_i2c_id[] = { + { "rt5575" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, rt5575_i2c_id); + +static int rt5575_i2c_probe(struct i2c_client *i2c) +{ + struct rt5575_priv *rt5575; + int ret, val; + +#if IS_ENABLED(CONFIG_SND_SOC_RT5575_SPI) + if (!rt5575_spi_ready) + return -EPROBE_DEFER; +#endif + + rt5575 = devm_kzalloc(&i2c->dev, sizeof(struct rt5575_priv), + GFP_KERNEL); + if (rt5575 == NULL) + return -ENOMEM; + + i2c_set_clientdata(i2c, rt5575); + + rt5575->i2c = i2c; + + rt5575->dsp_regmap = devm_regmap_init_i2c(i2c, &rt5575_dsp_regmap); + if (IS_ERR(rt5575->dsp_regmap)) { + ret = PTR_ERR(rt5575->dsp_regmap); + dev_err(&i2c->dev, "Failed to allocate register map: %d\n", ret); + return ret; + } + + rt5575->regmap = devm_regmap_init(&i2c->dev, NULL, i2c, &rt5575_regmap); + if (IS_ERR(rt5575->regmap)) { + ret = PTR_ERR(rt5575->regmap); + dev_err(&i2c->dev, "Failed to allocate register map: %d\n", ret); + return ret; + } + + regmap_read(rt5575->regmap, RT5575_ID, &val); + if (val != RT5575_DEVICE_ID) { + dev_err(&i2c->dev, "Device with ID register %08x is not rt5575\n", val); + return -ENODEV; + } + + regmap_read(rt5575->regmap, RT5575_ID_1, &val); + if (!val) { + dev_err(&i2c->dev, "This is not formal version\n"); + return -ENODEV; + } + + return devm_snd_soc_register_component(&i2c->dev, &rt5575_soc_component_dev, rt5575_dai, + ARRAY_SIZE(rt5575_dai)); +} + +static const struct of_device_id rt5575_of_match[] = { + { .compatible = "realtek,rt5575" }, + { } +}; +MODULE_DEVICE_TABLE(of, rt5575_of_match); + +static struct i2c_driver rt5575_i2c_driver = { + .driver = { + .name = "rt5575", + .owner = THIS_MODULE, + .of_match_table = of_match_ptr(rt5575_of_match), + }, + .probe = rt5575_i2c_probe, + .id_table = rt5575_i2c_id, +}; +module_i2c_driver(rt5575_i2c_driver); + +MODULE_DESCRIPTION("ASoC ALC5575 driver"); +MODULE_AUTHOR("Oder Chiou oder_chiou@realtek.com"); +MODULE_LICENSE("GPL"); diff --git a/sound/soc/codecs/rt5575.h b/sound/soc/codecs/rt5575.h new file mode 100644 index 000000000000..11149612274a --- /dev/null +++ b/sound/soc/codecs/rt5575.h @@ -0,0 +1,54 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * rt5575.h -- ALC5575 ALSA SoC audio driver + * + * Copyright(c) 2025 Realtek Semiconductor Corp. + * + */ + +#ifndef __RT5575_H__ +#define __RT5575_H__ + +#define RT5575_DEVICE_ID 0x10ec5575 +#define RT5575_DSP_MAPPING 0x18000000 + +#define RT5575_ID 0x8008 +#define RT5575_ID_1 0x800c +#define RT5575_MIXL_VOL 0x8a14 +#define RT5575_MIXR_VOL 0x8a18 +#define RT5575_PROMPT_VOL 0x8a84 +#define RT5575_SPK01_VOL 0x8a88 +#define RT5575_SPK23_VOL 0x8a8c +#define RT5575_MIC1_VOL 0x8a98 +#define RT5575_MIC2_VOL 0x8a9c +#define RT5575_WNC_CTRL 0x80ec +#define RT5575_MODE_CTRL 0x80f0 +#define RT5575_I2S_RATE_CTRL 0x80f4 +#define RT5575_SLEEP_CTRL 0x80f8 +#define RT5575_ALG_BYPASS_CTRL 0x80fc +#define RT5575_PINMUX_CTRL_2 0x81a4 +#define RT5575_GPIO_CTRL_1 0x8208 +#define RT5575_DSP_BUS_CTRL 0x880c +#define RT5575_SW_INT 0x0018 +#define RT5575_DSP_BOOT_ERR 0x8e14 +#define RT5575_DSP_READY 0x8e24 +#define RT5575_DSP_CMD_ADDR 0x8e28 +#define RT5575_EFUSE_DATA_2 0xc638 +#define RT5575_EFUSE_DATA_3 0xc63c +#define RT5575_EFUSE_PID 0xc660 + +enum { + RT5575_AIF1, + RT5575_AIF2, + RT5575_AIF3, + RT5575_AIF4, + RT5575_AIFS, +}; + +struct rt5575_priv { + struct i2c_client *i2c; + struct snd_soc_component *component; + struct regmap *dsp_regmap, *regmap; +}; + +#endif /* __RT5575_H__ */
Realtek ALC5575 is a highly advanced DSP and microphone CODEC that has been designed for AI audio technology. Its impressive features include an advanced HiFi-5 DSP core, a Neural Network Processing Unit (NPU) owned by Realtek, and embedded 4MB memory, which enables it to operate highly advanced AI audio algorithms. The ALC5575 supports 4xA-mic input and 8xD-mic input, as well as a rich set of interfaces such as I2S, I2C, SPI, and UART.
Signed-off-by: Oder Chiou oder_chiou@realtek.com --- .../bindings/sound/realtek,rt5575.yaml | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5575.yaml
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5575.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5575.yaml new file mode 100644 index 000000000000..cc7540278ad9 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/realtek,rt5575.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/realtek,rt5575.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ALC5575 audio CODEC + +maintainers: + - Oder Chiou oder_chiou@realtek.com + +description: + The device supports both I2C and SPI. I2C is mandatory, while SPI is + optional depending on the hardware configuration. + +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + - $ref: dai-common.yaml# + +properties: + compatible: + const: realtek,rt5575 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + codec@57 { + compatible = "realtek,rt5575"; + reg = <0x57>; + }; + };
On Fri, Nov 21, 2025 at 04:41:12PM +0800, Oder Chiou wrote:
Realtek ALC5575 is a highly advanced DSP and microphone CODEC that has been designed for AI audio technology. Its impressive features include an advanced HiFi-5 DSP core, a Neural Network Processing Unit (NPU) owned by Realtek, and embedded 4MB memory, which enables it to operate highly advanced AI audio algorithms. The ALC5575 supports 4xA-mic input and 8xD-mic input, as well as a rich set of interfaces such as I2S, I2C, SPI, and UART.
Signed-off-by: Oder Chiou oder_chiou@realtek.com
You still did not respond to my comments from v5. You did not implemented some of them and I already asked for improvements.
I will not review this and I mark it as changes requested in patchwork.
Best regards, Krzysztof
On 2025-11-21 9:41 AM, Oder Chiou wrote:
The ALC5575 integrates an audio DSP that typically loads its firmware from an external flash via its own SPI host interface. In certain hardware configurations, the firmware can alternatively be loaded through the SPI client interface. The driver provides basic mute and volume control functions. When the SPI client interface is enabled, firmware loading is handled by the SPI driver.
Signed-off-by: Oder Chiou oder_chiou@realtek.com
Please CC the reviewers who actively review your patches, makes it easier not miss the follow ups.
Not talking about the tag-area, just the email Cc :)
sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 4 + sound/soc/codecs/rt5575-spi.c | 86 ++++++++ sound/soc/codecs/rt5575-spi.h | 16 ++ sound/soc/codecs/rt5575.c | 370 ++++++++++++++++++++++++++++++++++ sound/soc/codecs/rt5575.h | 54 +++++ 6 files changed, 540 insertions(+) create mode 100644 sound/soc/codecs/rt5575-spi.c create mode 100644 sound/soc/codecs/rt5575-spi.h create mode 100644 sound/soc/codecs/rt5575.c create mode 100644 sound/soc/codecs/rt5575.h
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index a0dfef57200c..a3ea5febd1e0 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -211,6 +211,7 @@ config SND_SOC_ALL_CODECS imply SND_SOC_RT1305 imply SND_SOC_RT1308 imply SND_SOC_RT5514
- imply SND_SOC_RT5575 imply SND_SOC_RT5616 imply SND_SOC_RT5631 imply SND_SOC_RT5640
@@ -1767,6 +1768,15 @@ config SND_SOC_RT5514_SPI_BUILTIN bool # force RT5514_SPI to be built-in to avoid link errors default SND_SOC_RT5514=y && SND_SOC_RT5514_SPI=m
+config SND_SOC_RT5575
- tristate "Realtek ALC5575 Codec - I2C"
- depends on I2C
+config SND_SOC_RT5575_SPI
- tristate "Realtek ALC5575 Codec - SPI"
- depends on SPI_MASTER
- select SND_SOC_RT5575
- config SND_SOC_RT5616 tristate "Realtek RT5616 CODEC" depends on I2C
diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile index 39138d96a720..82f660cbe8ec 100644 --- a/sound/soc/codecs/Makefile +++ b/sound/soc/codecs/Makefile @@ -252,6 +252,8 @@ snd-soc-rt286-y := rt286.o snd-soc-rt298-y := rt298.o snd-soc-rt5514-y := rt5514.o snd-soc-rt5514-spi-y := rt5514-spi.o +snd-soc-rt5575-y := rt5575.o +snd-soc-rt5575-spi-y := rt5575-spi.o snd-soc-rt5616-y := rt5616.o snd-soc-rt5631-y := rt5631.o snd-soc-rt5640-y := rt5640.o @@ -684,6 +686,8 @@ obj-$(CONFIG_SND_SOC_RT298) += snd-soc-rt298.o obj-$(CONFIG_SND_SOC_RT5514) += snd-soc-rt5514.o obj-$(CONFIG_SND_SOC_RT5514_SPI) += snd-soc-rt5514-spi.o obj-$(CONFIG_SND_SOC_RT5514_SPI_BUILTIN) += snd-soc-rt5514-spi.o +obj-$(CONFIG_SND_SOC_RT5575) += snd-soc-rt5575.o +obj-$(CONFIG_SND_SOC_RT5575_SPI) += snd-soc-rt5575-spi.o obj-$(CONFIG_SND_SOC_RT5616) += snd-soc-rt5616.o obj-$(CONFIG_SND_SOC_RT5631) += snd-soc-rt5631.o obj-$(CONFIG_SND_SOC_RT5640) += snd-soc-rt5640.o diff --git a/sound/soc/codecs/rt5575-spi.c b/sound/soc/codecs/rt5575-spi.c new file mode 100644 index 000000000000..9dbc8170fb76 --- /dev/null +++ b/sound/soc/codecs/rt5575-spi.c @@ -0,0 +1,86 @@ +// SPDX-License-Identifier: GPL-2.0-only +/*
- rt5575-spi.c -- ALC5575 SPI driver
- Copyright(c) 2025 Realtek Semiconductor Corp.
- */
+#include <linux/of.h> +#include <linux/spi/spi.h>
+#include "rt5575-spi.h"
+#define RT5575_SPI_CMD_BURST_WRITE 5 +#define RT5575_SPI_BUF_LEN 240
+struct rt5575_spi_burst_write {
- u8 cmd;
- u32 addr;
- u8 data[RT5575_SPI_BUF_LEN];
- u8 dummy;
+} __packed;
+bool rt5575_spi_ready;
I believe the patch is dead on arrival, unfortunately as it won't compile as =m (module) when CONFIG_SND_SOC_RT5575_SPI is enabled as =m simultaneously. EXPORT_SYMBOL_GPL() or a friend of his is missing.
+static struct spi_device *rt5575_spi;
+/**
- rt5575_spi_burst_write - Write data to SPI by rt5575 address.
- @addr: Start address.
- @txbuf: Data buffer for writing.
- @len: Data length.
- */
+int rt5575_spi_burst_write(u32 addr, const u8 *txbuf, size_t len) +{
- struct rt5575_spi_burst_write buf = {
.cmd = RT5575_SPI_CMD_BURST_WRITE- };
- unsigned int end, offset = 0;
- while (offset < len) {
if (offset + RT5575_SPI_BUF_LEN <= len)end = RT5575_SPI_BUF_LEN;elseend = len % RT5575_SPI_BUF_LEN;buf.addr = cpu_to_le32(addr + offset);memcpy(&buf.data, &txbuf[offset], end);spi_write(rt5575_spi, &buf, sizeof(buf));offset += RT5575_SPI_BUF_LEN;- }
- return 0;
+} +EXPORT_SYMBOL_GPL(rt5575_spi_burst_write);
+static int rt5575_spi_probe(struct spi_device *spi) +{
- rt5575_spi = spi;
- rt5575_spi_ready = true;
I still do not understand the logic behind having rt5575_spi _and_ rt5575_spi_ready. The latter is used just one, in the I2C-device probe. rt5575_spi is static and will be by default initialized to NULL. Statement 'if (!rt5575_spi)' is enough to cover that single occurrence in your code.
- return 0;
+}
...
diff --git a/sound/soc/codecs/rt5575.c b/sound/soc/codecs/rt5575.c new file mode 100644 index 000000000000..58508d643273 --- /dev/null +++ b/sound/soc/codecs/rt5575.c
...
+static int rt5575_probe(struct snd_soc_component *component) +{
- struct rt5575_priv *rt5575 = snd_soc_component_get_drvdata(component);
- rt5575->component = component;
- dev_info(component->dev, "Private ID: %llx\n", rt5575_get_priv_id(rt5575));
+#if IS_ENABLED(CONFIG_SND_SOC_RT5575_SPI)
- request_firmware_nowait(THIS_MODULE, FW_ACTION_UEVENT, "realtek/rt5575/rt5575_fw1.bin",
component->dev, GFP_KERNEL, rt5575, rt5575_fw_load_by_spi);
I do not believe this is OK. If the SPI component exists, from the code-perspective it looks like the firmware-loading procedure is essential and failing to load the firmware should halt driver's operations.
See below as this touches on the driver design which looks off and I haven't found any valid argumentation in your previous message that would clarify the situation.
+#endif
- return 0;
+}
...
+static const struct i2c_device_id rt5575_i2c_id[] = {
- { "rt5575" },
- { }
+}; +MODULE_DEVICE_TABLE(i2c, rt5575_i2c_id);
+static int rt5575_i2c_probe(struct i2c_client *i2c) +{
- struct rt5575_priv *rt5575;
- int ret, val;
+#if IS_ENABLED(CONFIG_SND_SOC_RT5575_SPI)
- if (!rt5575_spi_ready)
return -EPROBE_DEFER;+#endif
I finally understood what's off in the design, and this part is crucial to the subject.
If CONFIG_SND_SOC_RT5575_SPI is enabled, and the SPI kept failing for whatever reason, the I2C device probe would get deferred continuously. As the kconfig looks optional, the question is: Does rt5575 codec exist in a "without SPI flash" version or, is it always shipped with SPI flash?
If it does exist as a standalone component - without SPI - then enabling CONFIG_SND_SOC_RT5575_SPI effectively renders the driver dysfunctional.
- rt5575 = devm_kzalloc(&i2c->dev, sizeof(struct rt5575_priv),
GFP_KERNEL);- if (rt5575 == NULL)
return -ENOMEM;- i2c_set_clientdata(i2c, rt5575);
- rt5575->i2c = i2c;
- rt5575->dsp_regmap = devm_regmap_init_i2c(i2c, &rt5575_dsp_regmap);
- if (IS_ERR(rt5575->dsp_regmap)) {
ret = PTR_ERR(rt5575->dsp_regmap);dev_err(&i2c->dev, "Failed to allocate register map: %d\n", ret);return ret;- }
- rt5575->regmap = devm_regmap_init(&i2c->dev, NULL, i2c, &rt5575_regmap);
- if (IS_ERR(rt5575->regmap)) {
ret = PTR_ERR(rt5575->regmap);dev_err(&i2c->dev, "Failed to allocate register map: %d\n", ret);return ret;- }
- regmap_read(rt5575->regmap, RT5575_ID, &val);
- if (val != RT5575_DEVICE_ID) {
dev_err(&i2c->dev, "Device with ID register %08x is not rt5575\n", val);return -ENODEV;- }
- regmap_read(rt5575->regmap, RT5575_ID_1, &val);
- if (!val) {
dev_err(&i2c->dev, "This is not formal version\n");return -ENODEV;- }
- return devm_snd_soc_register_component(&i2c->dev, &rt5575_soc_component_dev, rt5575_dai,
ARRAY_SIZE(rt5575_dai));+}
+static const struct of_device_id rt5575_of_match[] = {
- { .compatible = "realtek,rt5575" },
- { }
+}; +MODULE_DEVICE_TABLE(of, rt5575_of_match);
+static struct i2c_driver rt5575_i2c_driver = {
- .driver = {
.name = "rt5575",.owner = THIS_MODULE,.of_match_table = of_match_ptr(rt5575_of_match),- },
- .probe = rt5575_i2c_probe,
- .id_table = rt5575_i2c_id,
+}; +module_i2c_driver(rt5575_i2c_driver);
+MODULE_DESCRIPTION("ASoC ALC5575 driver"); +MODULE_AUTHOR("Oder Chiou oder_chiou@realtek.com"); +MODULE_LICENSE("GPL");
-----Original Message----- From: Cezary Rojewski cezary.rojewski@intel.com Sent: Monday, November 24, 2025 6:45 PM To: Oder Chiou oder_chiou@realtek.com Cc: perex@perex.cz; linux-sound@vger.kernel.org; devicetree@vger.kernel.org; alsa-devel@alsa-project.org; Flove(HsinFu) flove@realtek.com; Shuming [范 書銘] shumingf@realtek.com; Jack Yu jack.yu@realtek.com; Derek [方德 義] derek.fang@realtek.com; broonie@kernel.org; lgirdwood@gmail.com; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org Subject: Re: [PATCH v7 1/2] ASoC: rt5575: Add the codec driver for the ALC5575
External mail : This email originated from outside the organization. Do not reply, click links, or open attachments unless you recognize the sender and know the content is safe.
On 2025-11-21 9:41 AM, Oder Chiou wrote:
The ALC5575 integrates an audio DSP that typically loads its firmware from an external flash via its own SPI host interface. In certain hardware configurations, the firmware can alternatively be loaded through the SPI client interface. The driver provides basic mute and volume control functions. When the SPI client interface is enabled, firmware loading is handled by the SPI driver.
Signed-off-by: Oder Chiou oder_chiou@realtek.com
Please CC the reviewers who actively review your patches, makes it easier not miss the follow ups.
Not talking about the tag-area, just the email Cc :)
sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 4 + sound/soc/codecs/rt5575-spi.c | 86 ++++++++ sound/soc/codecs/rt5575-spi.h | 16 ++ sound/soc/codecs/rt5575.c | 370
++++++++++++++++++++++++++++++++++
sound/soc/codecs/rt5575.h | 54 +++++ 6 files changed, 540 insertions(+) create mode 100644 sound/soc/codecs/rt5575-spi.c create mode 100644 sound/soc/codecs/rt5575-spi.h create mode 100644 sound/soc/codecs/rt5575.c create mode 100644 sound/soc/codecs/rt5575.h
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index a0dfef57200c..a3ea5febd1e0 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -211,6 +211,7 @@ config SND_SOC_ALL_CODECS imply SND_SOC_RT1305 imply SND_SOC_RT1308 imply SND_SOC_RT5514
imply SND_SOC_RT5575 imply SND_SOC_RT5616 imply SND_SOC_RT5631 imply SND_SOC_RT5640@@ -1767,6 +1768,15 @@ config SND_SOC_RT5514_SPI_BUILTIN bool # force RT5514_SPI to be built-in to avoid link errors default SND_SOC_RT5514=y && SND_SOC_RT5514_SPI=m
+config SND_SOC_RT5575
tristate "Realtek ALC5575 Codec - I2C"depends on I2C+config SND_SOC_RT5575_SPI
tristate "Realtek ALC5575 Codec - SPI"depends on SPI_MASTERselect SND_SOC_RT5575- config SND_SOC_RT5616 tristate "Realtek RT5616 CODEC" depends on I2C
diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile index 39138d96a720..82f660cbe8ec 100644 --- a/sound/soc/codecs/Makefile +++ b/sound/soc/codecs/Makefile @@ -252,6 +252,8 @@ snd-soc-rt286-y := rt286.o snd-soc-rt298-y := rt298.o snd-soc-rt5514-y := rt5514.o snd-soc-rt5514-spi-y := rt5514-spi.o +snd-soc-rt5575-y := rt5575.o +snd-soc-rt5575-spi-y := rt5575-spi.o snd-soc-rt5616-y := rt5616.o snd-soc-rt5631-y := rt5631.o snd-soc-rt5640-y := rt5640.o @@ -684,6 +686,8 @@ obj-$(CONFIG_SND_SOC_RT298) +=
snd-soc-rt298.o
obj-$(CONFIG_SND_SOC_RT5514) += snd-soc-rt5514.o obj-$(CONFIG_SND_SOC_RT5514_SPI) += snd-soc-rt5514-spi.o obj-$(CONFIG_SND_SOC_RT5514_SPI_BUILTIN) +=
snd-soc-rt5514-spi.o
+obj-$(CONFIG_SND_SOC_RT5575) += snd-soc-rt5575.o +obj-$(CONFIG_SND_SOC_RT5575_SPI) += snd-soc-rt5575-spi.o obj-$(CONFIG_SND_SOC_RT5616) += snd-soc-rt5616.o obj-$(CONFIG_SND_SOC_RT5631) += snd-soc-rt5631.o obj-$(CONFIG_SND_SOC_RT5640) += snd-soc-rt5640.o diff --git a/sound/soc/codecs/rt5575-spi.c b/sound/soc/codecs/rt5575-spi.c new file mode 100644 index 000000000000..9dbc8170fb76 --- /dev/null +++ b/sound/soc/codecs/rt5575-spi.c @@ -0,0 +1,86 @@ +// SPDX-License-Identifier: GPL-2.0-only +/*
- rt5575-spi.c -- ALC5575 SPI driver
- Copyright(c) 2025 Realtek Semiconductor Corp.
- */
+#include <linux/of.h> +#include <linux/spi/spi.h>
+#include "rt5575-spi.h"
+#define RT5575_SPI_CMD_BURST_WRITE 5 +#define RT5575_SPI_BUF_LEN 240
+struct rt5575_spi_burst_write {
u8 cmd;u32 addr;u8 data[RT5575_SPI_BUF_LEN];u8 dummy;+} __packed;
+bool rt5575_spi_ready;
I believe the patch is dead on arrival, unfortunately as it won't compile as =m (module) when CONFIG_SND_SOC_RT5575_SPI is enabled as =m simultaneously. EXPORT_SYMBOL_GPL() or a friend of his is missing.
+static struct spi_device *rt5575_spi;
+/**
- rt5575_spi_burst_write - Write data to SPI by rt5575 address.
- @addr: Start address.
- @txbuf: Data buffer for writing.
- @len: Data length.
- */
+int rt5575_spi_burst_write(u32 addr, const u8 *txbuf, size_t len) +{
struct rt5575_spi_burst_write buf = {.cmd = RT5575_SPI_CMD_BURST_WRITE};unsigned int end, offset = 0;while (offset < len) {if (offset + RT5575_SPI_BUF_LEN <= len)end = RT5575_SPI_BUF_LEN;elseend = len % RT5575_SPI_BUF_LEN;buf.addr = cpu_to_le32(addr + offset);memcpy(&buf.data, &txbuf[offset], end);spi_write(rt5575_spi, &buf, sizeof(buf));offset += RT5575_SPI_BUF_LEN;}return 0;+} +EXPORT_SYMBOL_GPL(rt5575_spi_burst_write);
+static int rt5575_spi_probe(struct spi_device *spi) +{
rt5575_spi = spi;rt5575_spi_ready = true;I still do not understand the logic behind having rt5575_spi _and_ rt5575_spi_ready. The latter is used just one, in the I2C-device probe. rt5575_spi is static and will be by default initialized to NULL. Statement 'if (!rt5575_spi)' is enough to cover that single occurrence in your code.
The variable rt5575_spi_ready will be removed. Declare the rt5575_spi as extern variable, adds it in EXPORT_SYMBOL_GPL(), and uses the statement 'if (!rt5575_spi)' in the i2c_probe.
return 0;+}
...
diff --git a/sound/soc/codecs/rt5575.c b/sound/soc/codecs/rt5575.c new file mode 100644 index 000000000000..58508d643273 --- /dev/null +++ b/sound/soc/codecs/rt5575.c
...
+static int rt5575_probe(struct snd_soc_component *component) +{
struct rt5575_priv *rt5575 =snd_soc_component_get_drvdata(component);
rt5575->component = component;dev_info(component->dev, "Private ID: %llx\n",rt5575_get_priv_id(rt5575));
+#if IS_ENABLED(CONFIG_SND_SOC_RT5575_SPI)
request_firmware_nowait(THIS_MODULE, FW_ACTION_UEVENT,"realtek/rt5575/rt5575_fw1.bin",
component->dev, GFP_KERNEL, rt5575,rt5575_fw_load_by_spi);
I do not believe this is OK. If the SPI component exists, from the code-perspective it looks like the firmware-loading procedure is essential and failing to load the firmware should halt driver's operations.
See below as this touches on the driver design which looks off and I haven't found any valid argumentation in your previous message that would clarify the situation.
+#endif
return 0;+}
...
+static const struct i2c_device_id rt5575_i2c_id[] = {
{ "rt5575" },{ }+}; +MODULE_DEVICE_TABLE(i2c, rt5575_i2c_id);
+static int rt5575_i2c_probe(struct i2c_client *i2c) +{
struct rt5575_priv *rt5575;int ret, val;+#if IS_ENABLED(CONFIG_SND_SOC_RT5575_SPI)
if (!rt5575_spi_ready)return -EPROBE_DEFER;+#endif
I finally understood what's off in the design, and this part is crucial to the subject.
If CONFIG_SND_SOC_RT5575_SPI is enabled, and the SPI kept failing for whatever reason, the I2C device probe would get deferred continuously. As the kconfig looks optional, the question is: Does rt5575 codec exist in a "without SPI flash" version or, is it always shipped with SPI flash?
Yes, the customers can choose 2 different hardware configurations in w/wo external SPI flash.
If it does exist as a standalone component - without SPI - then enabling CONFIG_SND_SOC_RT5575_SPI effectively renders the driver dysfunctional.
The multiple compatible names can distinguish between w/wo flash to avoid it.
static const struct of_device_id rt5575_of_match[] = { { .compatible = "realtek,rt5575" }, { .compatible = "realtek,rt5575-with-spi" }, { } };
#if IS_ENABLED(CONFIG_SND_SOC_RT5575_SPI) if (!rt5575_spi && of_device_is_compatible(dev->of_node, rt5575_of_match[1].compatible)) return -EPROBE_DEFER; #endif
rt5575 = devm_kzalloc(&i2c->dev, sizeof(struct rt5575_priv),GFP_KERNEL);if (rt5575 == NULL)return -ENOMEM;i2c_set_clientdata(i2c, rt5575);rt5575->i2c = i2c;rt5575->dsp_regmap = devm_regmap_init_i2c(i2c,&rt5575_dsp_regmap);
if (IS_ERR(rt5575->dsp_regmap)) {ret = PTR_ERR(rt5575->dsp_regmap);dev_err(&i2c->dev, "Failed to allocate register map: %d\n",ret);
return ret;}rt5575->regmap = devm_regmap_init(&i2c->dev, NULL, i2c,&rt5575_regmap);
if (IS_ERR(rt5575->regmap)) {ret = PTR_ERR(rt5575->regmap);dev_err(&i2c->dev, "Failed to allocate register map: %d\n",ret);
return ret;}regmap_read(rt5575->regmap, RT5575_ID, &val);if (val != RT5575_DEVICE_ID) {dev_err(&i2c->dev, "Device with ID register %08x is notrt5575\n", val);
return -ENODEV;}regmap_read(rt5575->regmap, RT5575_ID_1, &val);if (!val) {dev_err(&i2c->dev, "This is not formal version\n");return -ENODEV;}return devm_snd_soc_register_component(&i2c->dev,&rt5575_soc_component_dev, rt5575_dai,
ARRAY_SIZE(rt5575_dai));+}
+static const struct of_device_id rt5575_of_match[] = {
{ .compatible = "realtek,rt5575" },{ }+}; +MODULE_DEVICE_TABLE(of, rt5575_of_match);
+static struct i2c_driver rt5575_i2c_driver = {
.driver = {.name = "rt5575",.owner = THIS_MODULE,.of_match_table = of_match_ptr(rt5575_of_match),},.probe = rt5575_i2c_probe,.id_table = rt5575_i2c_id,+}; +module_i2c_driver(rt5575_i2c_driver);
+MODULE_DESCRIPTION("ASoC ALC5575 driver"); +MODULE_AUTHOR("Oder Chiou oder_chiou@realtek.com"); +MODULE_LICENSE("GPL");
On Fri, 21 Nov 2025 16:41:11 +0800, Oder Chiou wrote:
The ALC5575 integrates an audio DSP that typically loads its firmware from an external flash via its own SPI host interface. In certain hardware configurations, the firmware can alternatively be loaded through the SPI client interface. The driver provides basic mute and volume control functions. When the SPI client interface is enabled, firmware loading is handled by the SPI driver.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: rt5575: Add the codec driver for the ALC5575 commit: c7ac7499ac5bb50ab3e00add121822c5c904bc91 [2/2] ASoC: dt-bindings: realtek,rt5575: add bindings for ALC5575 (no commit info)
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (4)
-
Cezary Rojewski -
Krzysztof Kozlowski -
Mark Brown -
Oder Chiou