[alsa-devel] [PATCH 00/28] remove .owner for most platform_drivers: the missing bits
Generated with coccinelle. The big cleanup was pulled in this merge window. This series catches the bits fallen through. The patches shall go in via the subsystem trees. If possible for 3.19 to increase consistency I'd say, but you decide, of course.
cocci-file used:
@match1@ declarer name module_platform_driver; declarer name module_platform_driver_probe; declarer name for_each_node_by_type; identifier __driver; @@ ( module_platform_driver(__driver); | module_platform_driver_probe(__driver, ...); )
@fix1 depends on match1@ identifier match1.__driver; @@ static struct platform_driver __driver = { .driver = { - .owner = THIS_MODULE, } };
@match2@ identifier __driver; @@ ( platform_driver_register(&__driver) | platform_driver_probe(&__driver, ...) | platform_create_bundle(&__driver, ...) )
@fix2 depends on match2@ identifier match2.__driver; @@ static struct platform_driver __driver = { .driver = { - .owner = THIS_MODULE, } };
Thanks again to Julia Lawall for support. And hey, we fixed a coccinelle bug on the way :)
Wolfram Sang (28): ARM: mach-exynos: drop owner assignment from platform_drivers mips: lantiq: xway: drop owner assignment from platform_drivers mips: pci: drop owner assignment from platform_drivers char: ipmi: drop owner assignment from platform_drivers cpufreq: drop owner assignment from platform_drivers dma: drop owner assignment from platform_drivers gpio: drop owner assignment from platform_drivers gpu: drm: rockchip: drop owner assignment from platform_drivers iommu: drop owner assignment from platform_drivers net: ethernet: stmicro: stmmac: drop owner assignment from platform_drivers net: wireless: ath: ath5k: drop owner assignment from platform_drivers of: drop owner assignment from platform_drivers pci: host: drop owner assignment from platform_drivers phy: drop owner assignment from platform_drivers pinctrl: intel: drop owner assignment from platform_drivers rtc: drop owner assignment from platform_drivers scsi: drop owner assignment from platform_drivers thermal: drop owner assignment from platform_drivers thermal: int340x_thermal: drop owner assignment from platform_drivers tty: serial: 8250: drop owner assignment from platform_drivers usb: gadget: udc: bdc: drop owner assignment from platform_drivers watchdog: drop owner assignment from platform_drivers ASoC: intel: drop owner assignment from platform_drivers ASoC: intel: sst: drop owner assignment from platform_drivers ASoC: omap: drop owner assignment from platform_drivers ASoC: pxa: drop owner assignment from platform_drivers ASoC: samsung: drop owner assignment from platform_drivers macintosh: drop owner assignment from platform_drivers
arch/arm/mach-exynos/pmu.c | 1 - arch/mips/lantiq/xway/vmmc.c | 1 - arch/mips/pci/pci-ar2315.c | 1 - arch/mips/pci/pci-rt2880.c | 1 - drivers/char/ipmi/ipmi_powernv.c | 1 - drivers/cpufreq/ls1x-cpufreq.c | 1 - drivers/dma/at_xdmac.c | 1 - drivers/gpio/gpio-vf610.c | 1 - drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - drivers/iommu/rockchip-iommu.c | 1 - drivers/macintosh/windfarm_pm112.c | 1 - drivers/macintosh/windfarm_pm72.c | 1 - drivers/macintosh/windfarm_rm31.c | 1 - drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 - drivers/net/wireless/ath/ath5k/ahb.c | 1 - drivers/of/unittest.c | 1 - drivers/pci/host/pci-layerscape.c | 1 - drivers/phy/phy-armada375-usb2.c | 1 - drivers/phy/phy-berlin-usb.c | 1 - drivers/phy/phy-miphy28lp.c | 1 - drivers/pinctrl/intel/pinctrl-cherryview.c | 1 - drivers/rtc/rtc-opal.c | 1 - drivers/scsi/atari_scsi.c | 1 - drivers/scsi/mac_scsi.c | 1 - drivers/scsi/sun3_scsi.c | 1 - drivers/thermal/int340x_thermal/int3400_thermal.c | 1 - drivers/thermal/int340x_thermal/int3402_thermal.c | 1 - drivers/thermal/rockchip_thermal.c | 1 - drivers/tty/serial/8250/8250_omap.c | 1 - drivers/usb/gadget/udc/bdc/bdc_core.c | 1 - drivers/watchdog/cadence_wdt.c | 1 - drivers/watchdog/meson_wdt.c | 1 - sound/soc/intel/bytcr_dpcm_rt5640.c | 1 - sound/soc/intel/cht_bsw_rt5672.c | 1 - sound/soc/intel/sst/sst_acpi.c | 1 - sound/soc/omap/omap-hdmi-audio.c | 1 - sound/soc/pxa/spitz.c | 1 - sound/soc/samsung/arndale_rt5631.c | 1 - 38 files changed, 38 deletions(-)
This platform_driver does not need to set an owner, it will be populated by the driver core.
Signed-off-by: Wolfram Sang wsa@the-dreams.de --- Generated with coccinelle. SmPL file is in the introductory msg. The big cleanup was pulled in this merge window. This series catches the bits fallen through. The patches shall go in via the subsystem trees.
sound/soc/intel/bytcr_dpcm_rt5640.c | 1 - sound/soc/intel/cht_bsw_rt5672.c | 1 - 2 files changed, 2 deletions(-)
diff --git a/sound/soc/intel/bytcr_dpcm_rt5640.c b/sound/soc/intel/bytcr_dpcm_rt5640.c index f5d0fc1ab10c..9277f2baefb1 100644 --- a/sound/soc/intel/bytcr_dpcm_rt5640.c +++ b/sound/soc/intel/bytcr_dpcm_rt5640.c @@ -215,7 +215,6 @@ static int snd_byt_mc_probe(struct platform_device *pdev)
static struct platform_driver snd_byt_mc_driver = { .driver = { - .owner = THIS_MODULE, .name = "bytt100_rt5640", .pm = &snd_soc_pm_ops, }, diff --git a/sound/soc/intel/cht_bsw_rt5672.c b/sound/soc/intel/cht_bsw_rt5672.c index 9b8b561171b7..a406c6104897 100644 --- a/sound/soc/intel/cht_bsw_rt5672.c +++ b/sound/soc/intel/cht_bsw_rt5672.c @@ -270,7 +270,6 @@ static int snd_cht_mc_probe(struct platform_device *pdev)
static struct platform_driver snd_cht_mc_driver = { .driver = { - .owner = THIS_MODULE, .name = "cht-bsw-rt5672", .pm = &snd_soc_pm_ops, },
On Sun, Dec 21, 2014 at 10:14:44PM +0100, Wolfram Sang wrote:
This platform_driver does not need to set an owner, it will be populated by the driver core.
This doesn't apply, I've already got a patch for it.
This platform_driver does not need to set an owner, it will be populated by the driver core.
Signed-off-by: Wolfram Sang wsa@the-dreams.de --- Generated with coccinelle. SmPL file is in the introductory msg. The big cleanup was pulled in this merge window. This series catches the bits fallen through. The patches shall go in via the subsystem trees.
sound/soc/intel/sst/sst_acpi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/intel/sst/sst_acpi.c b/sound/soc/intel/sst/sst_acpi.c index 3abc29e8a928..f1180ffdc393 100644 --- a/sound/soc/intel/sst/sst_acpi.c +++ b/sound/soc/intel/sst/sst_acpi.c @@ -366,7 +366,6 @@ MODULE_DEVICE_TABLE(acpi, sst_acpi_ids); static struct platform_driver sst_acpi_driver = { .driver = { .name = "intel_sst_acpi", - .owner = THIS_MODULE, .acpi_match_table = ACPI_PTR(sst_acpi_ids), .pm = &intel_sst_pm, },
On Sun, Dec 21, 2014 at 10:14:45PM +0100, Wolfram Sang wrote:
This platform_driver does not need to set an owner, it will be populated by the driver core.
Applied, thanks.
This platform_driver does not need to set an owner, it will be populated by the driver core.
Signed-off-by: Wolfram Sang wsa@the-dreams.de --- Generated with coccinelle. SmPL file is in the introductory msg. The big cleanup was pulled in this merge window. This series catches the bits fallen through. The patches shall go in via the subsystem trees.
sound/soc/omap/omap-hdmi-audio.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/omap/omap-hdmi-audio.c b/sound/soc/omap/omap-hdmi-audio.c index 3f9ac7dbdc80..ccfb41c22e53 100644 --- a/sound/soc/omap/omap-hdmi-audio.c +++ b/sound/soc/omap/omap-hdmi-audio.c @@ -393,7 +393,6 @@ static int omap_hdmi_audio_remove(struct platform_device *pdev) static struct platform_driver hdmi_audio_driver = { .driver = { .name = DRV_NAME, - .owner = THIS_MODULE, }, .probe = omap_hdmi_audio_probe, .remove = omap_hdmi_audio_remove,
On Sun, Dec 21, 2014 at 10:14:46PM +0100, Wolfram Sang wrote:
This platform_driver does not need to set an owner, it will be populated by the driver core.
Applied, thanks.
This platform_driver does not need to set an owner, it will be populated by the driver core.
Signed-off-by: Wolfram Sang wsa@the-dreams.de --- Generated with coccinelle. SmPL file is in the introductory msg. The big cleanup was pulled in this merge window. This series catches the bits fallen through. The patches shall go in via the subsystem trees.
sound/soc/pxa/spitz.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/pxa/spitz.c b/sound/soc/pxa/spitz.c index d7d5fb20ea6f..a6d680acd907 100644 --- a/sound/soc/pxa/spitz.c +++ b/sound/soc/pxa/spitz.c @@ -352,7 +352,6 @@ static int spitz_remove(struct platform_device *pdev) static struct platform_driver spitz_driver = { .driver = { .name = "spitz-audio", - .owner = THIS_MODULE, .pm = &snd_soc_pm_ops, }, .probe = spitz_probe,
This platform_driver does not need to set an owner, it will be populated by the driver core.
Signed-off-by: Wolfram Sang wsa@the-dreams.de --- Generated with coccinelle. SmPL file is in the introductory msg. The big cleanup was pulled in this merge window. This series catches the bits fallen through. The patches shall go in via the subsystem trees.
sound/soc/samsung/arndale_rt5631.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/samsung/arndale_rt5631.c b/sound/soc/samsung/arndale_rt5631.c index 1e2b61ca8db2..8bf2e2c4bafb 100644 --- a/sound/soc/samsung/arndale_rt5631.c +++ b/sound/soc/samsung/arndale_rt5631.c @@ -135,7 +135,6 @@ MODULE_DEVICE_TABLE(of, samsung_arndale_rt5631_of_match); static struct platform_driver arndale_audio_driver = { .driver = { .name = "arndale-audio", - .owner = THIS_MODULE, .pm = &snd_soc_pm_ops, .of_match_table = of_match_ptr(samsung_arndale_rt5631_of_match), },
On Sun, Dec 21, 2014 at 10:14:48PM +0100, Wolfram Sang wrote:
This platform_driver does not need to set an owner, it will be populated by the driver core.
Applied, thanks.
participants (2)
-
Mark Brown -
Wolfram Sang