[alsa-devel] [PATCH] a52: Ignore start request if we're already running
When trying to start a PCM that's already running, the result is EBADFD. We might have implicitly started the buffer by filling it up, so just ignore this request if we're already running.
Reported-by: Chow Loong Jin hyperair@ubuntu.com Signed-off-by: David Henningsson david.henningsson@canonical.com --- a52/pcm_a52.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/a52/pcm_a52.c b/a52/pcm_a52.c index b467ec8..59e25cb 100644 --- a/a52/pcm_a52.c +++ b/a52/pcm_a52.c @@ -482,6 +482,12 @@ static int a52_start(snd_pcm_ioplug_t *io) { struct a52_ctx *rec = io->private_data;
+ /* When trying to start a PCM that's already running, the result is + EBADFD. We might have implicitly started the buffer by filling it + up, so just ignore this request if we're already running. */ + if (snd_pcm_state(rec->slave) == SND_PCM_STATE_RUNNING) + return 0; + return snd_pcm_start(rec->slave); }
At Wed, 12 Nov 2014 15:55:43 +0100, David Henningsson wrote:
When trying to start a PCM that's already running, the result is EBADFD. We might have implicitly started the buffer by filling it up, so just ignore this request if we're already running.
Reported-by: Chow Loong Jin hyperair@ubuntu.com Signed-off-by: David Henningsson david.henningsson@canonical.com
Thanks, applied.
Takashi
a52/pcm_a52.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/a52/pcm_a52.c b/a52/pcm_a52.c index b467ec8..59e25cb 100644 --- a/a52/pcm_a52.c +++ b/a52/pcm_a52.c @@ -482,6 +482,12 @@ static int a52_start(snd_pcm_ioplug_t *io) { struct a52_ctx *rec = io->private_data;
- /* When trying to start a PCM that's already running, the result is
EBADFD. We might have implicitly started the buffer by filling it
up, so just ignore this request if we're already running. */
- if (snd_pcm_state(rec->slave) == SND_PCM_STATE_RUNNING)
return 0;
- return snd_pcm_start(rec->slave);
}
-- 1.9.1
participants (2)
-
David Henningsson
-
Takashi Iwai