[PATCH] soundwire: qcom: remove redundant wait for completion
Remove wait_for_completion_timeout from soundwire probe as it seems unnecessary and device enumeration is anyway not happening here. Also, as device enumeration event is dependent on wcd938x probe to be completed, its of no use waiting here.
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Co-developed-by: Venkata Prasad Potturu quic_potturu@quicinc.com Signed-off-by: Venkata Prasad Potturu quic_potturu@quicinc.com --- drivers/soundwire/qcom.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index 5481341..9a32a24 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -1309,8 +1309,6 @@ static int qcom_swrm_probe(struct platform_device *pdev) }
qcom_swrm_init(ctrl); - wait_for_completion_timeout(&ctrl->enumeration, - msecs_to_jiffies(TIMEOUT_MS)); ret = qcom_swrm_register_dais(ctrl); if (ret) goto err_master_add;
On 25/02/2022 13:27, Srinivasa Rao Mandadapu wrote:
Remove wait_for_completion_timeout from soundwire probe as it seems unnecessary and device enumeration is anyway not happening here.
May be some details on the side effects of this wait would be good to add in the log.
Also, as device enumeration event is dependent on wcd938x probe to be completed, its of no use waiting here.
fix tag is missing
Fixes: 06dd96738d618 ("soundwire: qcom: wait for enumeration to be complete in probe")
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Co-developed-by: Venkata Prasad Potturu quic_potturu@quicinc.com Signed-off-by: Venkata Prasad Potturu quic_potturu@quicinc.com
drivers/soundwire/qcom.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index 5481341..9a32a24 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -1309,8 +1309,6 @@ static int qcom_swrm_probe(struct platform_device *pdev) }
qcom_swrm_init(ctrl);
- wait_for_completion_timeout(&ctrl->enumeration,
msecs_to_jiffies(TIMEOUT_MS));
On 2/25/2022 7:07 PM, Srinivas Kandagatla wrote: Thanks for Your time Srini!!
On 25/02/2022 13:27, Srinivasa Rao Mandadapu wrote:
Remove wait_for_completion_timeout from soundwire probe as it seems unnecessary and device enumeration is anyway not happening here.
May be some details on the side effects of this wait would be good to add in the log.
Okay. Will elaborate issue observed here.
Also, as device enumeration event is dependent on wcd938x probe to be completed, its of no use waiting here.
fix tag is missing
Fixes: 06dd96738d618 ("soundwire: qcom: wait for enumeration to be complete in probe")
Okay. Will add and re post.
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Co-developed-by: Venkata Prasad Potturu quic_potturu@quicinc.com Signed-off-by: Venkata Prasad Potturu quic_potturu@quicinc.com
drivers/soundwire/qcom.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index 5481341..9a32a24 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -1309,8 +1309,6 @@ static int qcom_swrm_probe(struct platform_device *pdev) } qcom_swrm_init(ctrl); - wait_for_completion_timeout(&ctrl->enumeration, - msecs_to_jiffies(TIMEOUT_MS)); ret = qcom_swrm_register_dais(ctrl); if (ret) goto err_master_add;
participants (2)
-
Srinivas Kandagatla -
Srinivasa Rao Mandadapu