Re: [alsa-devel] [PATCH 2/3] ASoC: DaVinci: pcm, rename variables in prep for ping/pong
On Wed, Sep 09, 2009 at 18:03:58, Caglar Akyuz wrote:
On Wednesday 09 September 2009 15:08:42 Nori, Sekhar wrote:
[...]
However, with or without your patch, I noticed a segmentation fault for the first time the 'arecord | aplay' loop is created. There is no fault the second time around. I haven't spent time debugging this yet.
This is due to these lines in davinci_pcm_enqueue_dma:
data_type = prtd->params->data_type; count = period_size / data_type;
First time running data_type is set to 0. This is a long time issue, I remember modifying my kernels to check for zero before this division..
Ah, thanks! Planning to submit a fix for this? We can work on the patch if you are busy otherwise.
Regards, Sekhar
-----Original Message----- From: davinci-linux-open-source-bounces@linux.davincidsp.com [mailto:davinci-linux-open-source-bounces@linux.davincidsp.com] On Behalf Of Nori, Sekhar Sent: Wednesday, September 09, 2009 9:06 AM To: caglarakyuz@gmail.com; davinci-linux-open-source@linux.davincidsp.com Cc: alsa-devel@alsa-project.org; Mark Brown Subject: RE: [alsa-devel] [PATCH 2/3] ASoC: DaVinci: pcm, rename variables in prep for ping/pong
On Wed, Sep 09, 2009 at 18:03:58, Caglar Akyuz wrote:
On Wednesday 09 September 2009 15:08:42 Nori, Sekhar wrote:
[...]
However, with or without your patch, I noticed a segmentation fault
for the
first time the 'arecord | aplay' loop is created. There is no fault
the
second time around. I haven't spent time debugging this yet.
This is due to these lines in davinci_pcm_enqueue_dma:
data_type = prtd->params->data_type; count = period_size / data_type;
First time running data_type is set to 0. This is a long time issue, I remember modifying my kernels to check for zero before this division..
Ah, thanks! Planning to submit a fix for this? We can work on the patch if you are busy otherwise.
There was a patch from Arun Mani on Arago linux-davinci staging tree -
http://arago-project.org/git/projects/?p=linux-davinci.git;a=commitdiff;h=00...
Thanks Sneha
Regards, Sekhar _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
On Wed, Sep 09, 2009 at 08:22:49AM -0500, Narnakaje, Snehaprabha wrote:
There was a patch from Arun Mani on Arago linux-davinci staging tree -
http://arago-project.org/git/projects/?p=linux-davinci.git;a=commitdiff;h=00...
Sounds like something that should be submitted to mainline for 2.6.32.
participants (3)
-
Mark Brown
-
Narnakaje, Snehaprabha
-
Nori, Sekhar