[alsa-devel] [PATCH] Add quirk for HP Samba (ALC888)
Hi,
This patch fixes 5.1 surround output for the HP Samba using the same quirk as the HP Lucknow. If HP machines are uniform in their wiring, I think we should rename ALC888_HP_NETTLE to ALC888_6ST_HP and ALC888_HP_LUCKNOW to ALC888_3ST_HP for generic HP 6stack and 3stack configurations.
I'll probably receive more HP machines soon, so I'll see if this is the case.
Best regards, Claudio
At Thu, 12 Jul 2007 19:41:18 -0300, Claudio Matsuoka wrote:
Hi,
This patch fixes 5.1 surround output for the HP Samba using the same quirk as the HP Lucknow. If HP machines are uniform in their wiring, I think we should rename ALC888_HP_NETTLE to ALC888_6ST_HP and ALC888_HP_LUCKNOW to ALC888_3ST_HP for generic HP 6stack and 3stack configurations.
That sounds good, but if we do, we should do it ASAP before merging to the upstream kernel. Could you prepare a patch?
Anyway I applied the patch now to ALSA HG tree. Thanks.
Takashi
On 7/13/07, Takashi Iwai tiwai@suse.de wrote:
At Thu, 12 Jul 2007 19:41:18 -0300, Claudio Matsuoka wrote:
If HP machines are uniform in their wiring, I think we should rename ALC888_HP_NETTLE to ALC888_6ST_HP and ALC888_HP_LUCKNOW to ALC888_3ST_HP for generic HP 6stack and 3stack configurations.
That sounds good, but if we do, we should do it ASAP before merging to the upstream kernel. Could you prepare a patch?
Done. The generic model names will be better for owners of unlisted HP models to guess which one they should pick as well, since Nettle and Lucknow are board names that can be used in different products.
Best regards, Claudio
At Fri, 13 Jul 2007 09:18:07 -0300, Claudio Matsuoka wrote:
[1 <text/plain; ISO-8859-1 (7bit)>] On 7/13/07, Takashi Iwai tiwai@suse.de wrote:
At Thu, 12 Jul 2007 19:41:18 -0300, Claudio Matsuoka wrote:
If HP machines are uniform in their wiring, I think we should rename ALC888_HP_NETTLE to ALC888_6ST_HP and ALC888_HP_LUCKNOW to ALC888_3ST_HP for generic HP 6stack and 3stack configurations.
That sounds good, but if we do, we should do it ASAP before merging to the upstream kernel. Could you prepare a patch?
Done. The generic model names will be better for owners of unlisted HP models to guess which one they should pick as well, since Nettle and Lucknow are board names that can be used in different products.
Thanks. I applied it now togethe with fixes for ALSA-Configuration.txt.
Takashi
participants (2)
-
Claudio Matsuoka -
Takashi Iwai