Re: [alsa-devel] [PATCH] ASoC/kirkwood: patch for the useless 'break' removal.
Hi Mark,
How about this patch? My other patch seem to be applied, but this one still be hung.
在 2010年6月2日 下午4:03,Wan ZongShun mcuos.com@gmail.com 写道:
This patch to remove the 'break;', when the 'switch' jumps to the 'default' branch, the 'return -EINVAL' will be return with a error number, so the 'break;' code never be run, it is unuseful and should be removed here.
Signed-off-by: Wan ZongShunmcuos.com@gmail.com
sound/soc/kirkwood/kirkwood-i2s.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c index 0adc597..0fdc7db 100644 --- a/sound/soc/kirkwood/kirkwood-i2s.c +++ b/sound/soc/kirkwood/kirkwood-i2s.c @@ -296,7 +296,6 @@ static int kirkwood_i2s_rec_trigger(struct snd_pcm_substream *substream,
default: return -EINVAL;
- break;
}
return 0;
1.6.3.3
On Sat, 2010-06-05 at 15:04 +0800, Wan ZongShun wrote:
Hi Mark,
How about this patch? My other patch seem to be applied, but this one still be hung.
在 2010年6月2日 下午4:03,Wan ZongShun mcuos.com@gmail.com 写道:
This patch to remove the 'break;', when the 'switch' jumps to the 'default' branch, the 'return -EINVAL' will be return with a error number, so the 'break;' code never be run, it is unuseful and should be removed here.
Signed-off-by: Wan ZongShunmcuos.com@gmail.com
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
On Mon, Jun 07, 2010 at 01:53:21PM +0100, Liam Girdwood wrote:
On Sat, 2010-06-05 at 15:04 +0800, Wan ZongShun wrote:
Signed-off-by: Wan ZongShunmcuos.com@gmail.com
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
Applied, thanks.
participants (3)
-
Liam Girdwood
-
Mark Brown
-
Wan ZongShun